WIP: perf(vk): a descriptor build asks for its stages' descriptor lists first #2045

Draft
siantm wants to merge 1 commit from siantm/Longshot:perf/vk-desc-lists-first into main
Contributor

Summary

The busiest instructions of a descriptor build (build_descriptors, gpu/vk/vk_draw.cpp) were the first loads of each stage's descriptor lists, kept inside the stage's Shader::Info (about ten cache lines of it): a miss a list, one after another. The build now asks for each stage's Info lines (from the uniform buffers' used sizes to the end of the image descriptors) before anything else, so the misses overlap. A hint only: the descriptors written are the same; the result expected is a shorter build.

No switch; a revert gives back main's code.

From f61b2820 on exp/x86-asm-sync.

Read first: the prefetch at the start of build_descriptors in gpu/vk/vk_draw.cpp.

Testing

Tested: Windows 11, i7-9700, RTX 4060, the builder's llvm-mingw clang 23; head 41c1c6de on main @ 75317e1f. Every check ran through tests/run_all.py --strict --exact in build jobs of the PC's job queue, in a hidden console (log t-dc3-vk-desc-lists-first):

  • Its own: tests/test_desc_info_prefetch.py (new: the prefetch is the build's first work and every list the build reads lies inside the prefetched range of Shader::Info, in shader_info.h's order): pass.
  • The 161 checks that read a file this change touches (--changed 75317e1f; its own are among them): 146 passed, 15 failed. Failed: tests/test_sampler_admission.py, tests/test_fsr_uniform_ownership.py, tests/test_pipeline_play_cache.py, tests/test_draw_stream_visibility.py, tests/test_device_lost_exit.py, tests/test_draw_binds.py, tests/test_dev_packs.py, tests/test_frame_overlap.py, tests/test_linux_pressure.py, tests/test_mesh_conv.py, tests/test_prepare_cache_save.py, tests/test_recorder_own_idle.py, tests/test_upscaler_rows.py, tests/test_vk_occlusion_queries.py: each fails on main @ 75317e1f too (the same checks on main in the same queue batch, log t-dc3-base). tests/test_recording_admission.py also failed in that run (its parallel case, "worker slot ownership") and passed when run again on this head (log t-dc4-vk-desc-lists-first); main passed it in that batch and in five runs of the next (logs t-dc4-base-ra1 to t-dc4-base-ra5).

It has NOT run in the game on this PC yet.

Still to test:

  • Windows 11, i7-9700, RTX 4060 (this PC): start in Kokiri Forest from the scene's save, play a minute (walking, turning the camera), main @ 75317e1f against this PR, each warmed a minute in the scene first, then interleaved (main, this PR, this PR, main), two runs each, expecting the same picture and the replay's time a frame the same as or lower than main's (by hand)
  • Linux NVIDIA and AMD, Windows AMD and Intel, Steam Deck: start in Kokiri Forest from the scene's save, play a minute (walking, turning the camera), main against this PR, warmed, in ABBA order, expecting the same picture every way and no crash or validation error (@Beanstalk linux+nvidia, linux+amd, windows+amd, windows+intel, steamdeck: Kokiri Forest a minute, main against this PR, ABBA, the same picture)
  • Linux (any GPU): build the renderer and run tests/test_desc_info_prefetch.py with --cxx g++ and --cxx clang++, expecting PASS (by hand)

Measurements

Verdict: with the stages' lists out of the caches (a build's first look at a program) a build takes 8-15 % less (1.09-1.17x; 19-140 ns a build), in both builds; with them in cache and work between the lists it is the same (1.00x), with no work 1.03-1.10x. Whether the lists are out of cache in play, and how often, is not measured; the third party's in-game run below showed no difference within about 5 %. A micro-benchmark on authored input; not measured in play.

Micro-benchmark (vk_desc_lists_first_bench.py: a script on this PC, not in this PR): the head's prefetch loop cut out of build_descriptors, put in front of an authored walk of the lists in the build's order (the old side: the walk alone), each descriptor followed by an authored amount of dependent work (rounds of a multiply-xorshift, a stand-in for its write); vk_shader.h's Stage with Eden's real Shader::Info (848 bytes a stage); programs of a vertex stage (3 uniform buffers, 1 storage buffer, 2 textures) and a fragment stage (4, 2, 8 and 1 image), a third (2, 3, 1) in the 3-stage case; three rounds run alone in this PC's job queue (2026-11-22, 01:21-01:23 UTC; log bench-vk-walks.log), the builder's llvm-mingw clang 23.1.5 at -O2 for baseline x86-64 and at -O2 -march=native (this PC's i7-9700, as the game is built here), 301 repetitions a case, old and new taking turns on the same authored inputs, their results equal at every repetition. Each cell: ns per build, the median of the three rounds' medians, in parentheses the lowest and highest of them; Δ: old over new (above 1, this PR is quicker).

Case (input; build) Before: main @ 75317e1f After: this PR @ 41c1c6de Δ (old/new)
cold-2stages-work0: lists flushed from every cache, 2 stages, no work; 64 programs; x86-64 baseline 238 ns (233-241) 216 ns (212-216) 1.10x
cold-2stages-work0: lists flushed from every cache, 2 stages, no work; 64 programs; -march=native 233 ns (233-236) 214 ns (211-216) 1.09x
cold-2stages-work24: flushed, 2 stages, 24 rounds a descriptor; 64 programs; x86-64 baseline 967 ns (936-970) 828 ns (816-841) 1.17x
cold-2stages-work24: flushed, 2 stages, 24 rounds a descriptor; 64 programs; -march=native 964 ns (948-983) 839 ns (827-853) 1.15x
cold-3stages-work24: flushed, 3 stages, 24 rounds; 64 programs; x86-64 baseline 1211 ns (1211-1228) 1092 ns (1081-1097) 1.11x
cold-3stages-work24: flushed, 3 stages, 24 rounds; 64 programs; -march=native 1219 ns (1209-1225) 1097 ns (1083-1102) 1.11x
warm-2stages-work0: in cache, 2 stages, no work; 8 programs x 64; x86-64 baseline 35.35 ns (35.16-35.35) 32.03 ns (32.03-33.40) 1.10x
warm-2stages-work0: in cache, 2 stages, no work; 8 programs x 64; -march=native 31.25 ns (31.05-31.45) 30.47 ns (30.27-30.66) 1.03x
warm-2stages-work24: in cache, 2 stages, 24 rounds; 8 programs x 64; x86-64 baseline 465 ns (465-467) 466 ns (466-467) 1.00x
warm-2stages-work24: in cache, 2 stages, 24 rounds; 8 programs x 64; -march=native 465 ns (465-465) 466 ns (466-466) 1.00x

zeldaootr's result (#issuecomment-69131), as posted:

Before: main @ 9dd41326 After: this PR @ 41c1c6de (merged into main 9dd41326) Δ
fps (each run) 26.2 / 26.7 / 26.7 (median 26.7) 26.4 / 27.0 / 26.5 (median 26.5) −0.6 %
1% low fps (1000 / p99) 17.1 17.5 +2.1 %
median frame time 36.51 ms 36.62 ms +0.11 ms
p99 frame time 58.35 ms 57.17 ms −1.18 ms

Hardware and settings: Steam Deck OLED, SteamOS 3.9.5, RADV VANGOGH, Mesa 26.2.0-devel, GPU clock set to 1600 MHz, headless; Minimum, render 50 % (640x400), output 1280x800, uncapped, V-Sync and frame generation off. Method: dev.py ab (with a local change to compare two prebuilt runtimes), the Market, three interleaved pairs of 60 s after the warm-up, the median; no FATAL, device-lost, VK_ERROR or validation line in the six logs. Its own stated limits: three runs a side on one Deck in one standing scene resolve about 5 %, so a saving of a few tenths of a millisecond of the replay's CPU time a frame would not show.

Risks

None for the picture: a prefetch changes no value. It could cost a little where the lines were already in cache (more loads issued); that is what the in-game A/B is for. A revert is enough (no switch). The renderer is compiled again after updating.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says. Not yet: it has not run in the game.
  • mise run test passes (any failure that also fails on main is named). Not yet: only the checks in Testing ran.
  • Measured against main, or Measurements says why there is nothing to measure. Not yet (Measurements).
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. Not yet: only the checks' cuts compiled (Testing).
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
## Summary The busiest instructions of a descriptor build (`build_descriptors`, `gpu/vk/vk_draw.cpp`) were the first loads of each stage's descriptor lists, kept inside the stage's `Shader::Info` (about ten cache lines of it): a miss a list, one after another. The build now asks for each stage's `Info` lines (from the uniform buffers' used sizes to the end of the image descriptors) before anything else, so the misses overlap. A hint only: the descriptors written are the same; the result expected is a shorter build. No switch; a revert gives back main's code. From f61b2820 on `exp/x86-asm-sync`. Read first: the prefetch at the start of `build_descriptors` in `gpu/vk/vk_draw.cpp`. ## Testing **Tested:** Windows 11, i7-9700, RTX 4060, the builder's llvm-mingw clang 23; head 41c1c6de on main @ 75317e1f. Every check ran through `tests/run_all.py --strict --exact` in build jobs of the PC's job queue, in a hidden console (log `t-dc3-vk-desc-lists-first`): - Its own: `tests/test_desc_info_prefetch.py` (new: the prefetch is the build's first work and every list the build reads lies inside the prefetched range of `Shader::Info`, in `shader_info.h`'s order): pass. - The 161 checks that read a file this change touches (`--changed 75317e1f`; its own are among them): 146 passed, 15 failed. Failed: `tests/test_sampler_admission.py`, `tests/test_fsr_uniform_ownership.py`, `tests/test_pipeline_play_cache.py`, `tests/test_draw_stream_visibility.py`, `tests/test_device_lost_exit.py`, `tests/test_draw_binds.py`, `tests/test_dev_packs.py`, `tests/test_frame_overlap.py`, `tests/test_linux_pressure.py`, `tests/test_mesh_conv.py`, `tests/test_prepare_cache_save.py`, `tests/test_recorder_own_idle.py`, `tests/test_upscaler_rows.py`, `tests/test_vk_occlusion_queries.py`: each fails on main @ 75317e1f too (the same checks on main in the same queue batch, log `t-dc3-base`). `tests/test_recording_admission.py` also failed in that run (its `parallel` case, "worker slot ownership") and passed when run again on this head (log `t-dc4-vk-desc-lists-first`); main passed it in that batch and in five runs of the next (logs `t-dc4-base-ra1` to `t-dc4-base-ra5`). It has NOT run in the game on this PC yet. **Still to test:** - Windows 11, i7-9700, RTX 4060 (this PC): start in Kokiri Forest from the scene's save, play a minute (walking, turning the camera), main @ 75317e1f against this PR, each warmed a minute in the scene first, then interleaved (main, this PR, this PR, main), two runs each, expecting the same picture and the replay's time a frame the same as or lower than main's (by hand) - Linux NVIDIA and AMD, Windows AMD and Intel, Steam Deck: start in Kokiri Forest from the scene's save, play a minute (walking, turning the camera), main against this PR, warmed, in ABBA order, expecting the same picture every way and no crash or validation error (@Beanstalk linux+nvidia, linux+amd, windows+amd, windows+intel, steamdeck: Kokiri Forest a minute, main against this PR, ABBA, the same picture) - Linux (any GPU): build the renderer and run `tests/test_desc_info_prefetch.py` with `--cxx g++` and `--cxx clang++`, expecting PASS (by hand) ## Measurements **Verdict:** with the stages' lists out of the caches (a build's first look at a program) a build takes 8-15 % less (1.09-1.17x; 19-140 ns a build), in both builds; with them in cache and work between the lists it is the same (1.00x), with no work 1.03-1.10x. Whether the lists are out of cache in play, and how often, is not measured; the third party's in-game run below showed no difference within about 5 %. A micro-benchmark on authored input; not measured in play. Micro-benchmark (`vk_desc_lists_first_bench.py`: a script on this PC, not in this PR): the head's prefetch loop cut out of `build_descriptors`, put in front of an authored walk of the lists in the build's order (the old side: the walk alone), each descriptor followed by an authored amount of dependent work (rounds of a multiply-xorshift, a stand-in for its write); vk_shader.h's `Stage` with Eden's real `Shader::Info` (848 bytes a stage); programs of a vertex stage (3 uniform buffers, 1 storage buffer, 2 textures) and a fragment stage (4, 2, 8 and 1 image), a third (2, 3, 1) in the 3-stage case; three rounds run alone in this PC's job queue (2026-11-22, 01:21-01:23 UTC; log `bench-vk-walks.log`), the builder's llvm-mingw clang 23.1.5 at -O2 for baseline x86-64 and at -O2 -march=native (this PC's i7-9700, as the game is built here), 301 repetitions a case, old and new taking turns on the same authored inputs, their results equal at every repetition. Each cell: ns per build, the median of the three rounds' medians, in parentheses the lowest and highest of them; Δ: old over new (above 1, this PR is quicker). | Case (input; build) | Before: main @ 75317e1f | After: this PR @ 41c1c6de | Δ (old/new) | |---|---|---|---| | cold-2stages-work0: lists flushed from every cache, 2 stages, no work; 64 programs; x86-64 baseline | 238 ns (233-241) | 216 ns (212-216) | 1.10x | | cold-2stages-work0: lists flushed from every cache, 2 stages, no work; 64 programs; -march=native | 233 ns (233-236) | 214 ns (211-216) | 1.09x | | cold-2stages-work24: flushed, 2 stages, 24 rounds a descriptor; 64 programs; x86-64 baseline | 967 ns (936-970) | 828 ns (816-841) | 1.17x | | cold-2stages-work24: flushed, 2 stages, 24 rounds a descriptor; 64 programs; -march=native | 964 ns (948-983) | 839 ns (827-853) | 1.15x | | cold-3stages-work24: flushed, 3 stages, 24 rounds; 64 programs; x86-64 baseline | 1211 ns (1211-1228) | 1092 ns (1081-1097) | 1.11x | | cold-3stages-work24: flushed, 3 stages, 24 rounds; 64 programs; -march=native | 1219 ns (1209-1225) | 1097 ns (1083-1102) | 1.11x | | warm-2stages-work0: in cache, 2 stages, no work; 8 programs x 64; x86-64 baseline | 35.35 ns (35.16-35.35) | 32.03 ns (32.03-33.40) | 1.10x | | warm-2stages-work0: in cache, 2 stages, no work; 8 programs x 64; -march=native | 31.25 ns (31.05-31.45) | 30.47 ns (30.27-30.66) | 1.03x | | warm-2stages-work24: in cache, 2 stages, 24 rounds; 8 programs x 64; x86-64 baseline | 465 ns (465-467) | 466 ns (466-467) | 1.00x | | warm-2stages-work24: in cache, 2 stages, 24 rounds; 8 programs x 64; -march=native | 465 ns (465-465) | 466 ns (466-466) | 1.00x | zeldaootr's result ([#issuecomment-69131](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/2045#issuecomment-69131)), as posted: | | Before: main @ 9dd41326 | After: this PR @ 41c1c6de (merged into main 9dd41326) | Δ | |---|---|---|---| | fps (each run) | 26.2 / 26.7 / 26.7 (median 26.7) | 26.4 / 27.0 / 26.5 (median 26.5) | −0.6 % | | 1% low fps (1000 / p99) | 17.1 | 17.5 | +2.1 % | | median frame time | 36.51 ms | 36.62 ms | +0.11 ms | | p99 frame time | 58.35 ms | 57.17 ms | −1.18 ms | Hardware and settings: Steam Deck OLED, SteamOS 3.9.5, RADV VANGOGH, Mesa 26.2.0-devel, GPU clock set to 1600 MHz, headless; Minimum, render 50 % (640x400), output 1280x800, uncapped, V-Sync and frame generation off. Method: `dev.py ab` (with a local change to compare two prebuilt runtimes), the Market, three interleaved pairs of 60 s after the warm-up, the median; no FATAL, device-lost, `VK_ERROR` or validation line in the six logs. Its own stated limits: three runs a side on one Deck in one standing scene resolve about 5 %, so a saving of a few tenths of a millisecond of the replay's CPU time a frame would not show. ## Risks None for the picture: a prefetch changes no value. It could cost a little where the lines were already in cache (more loads issued); that is what the in-game A/B is for. A revert is enough (no switch). The renderer is compiled again after updating. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [ ] Tested on my own PC, in the game for a change the game runs, as Testing says. Not yet: it has not run in the game. - [ ] `mise run test` passes (any failure that also fails on `main` is named). Not yet: only the checks in Testing ran. - [ ] Measured against `main`, or Measurements says why there is nothing to measure. Not yet (Measurements). - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. Not yet: only the checks' cuts compiled (Testing). - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers.
perf(vk): a descriptor build asks for its stages' descriptor lists first
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 29s
beanstalk/approval waiting for a BigBean's 👍 on the request
41c1c6de5e
build_descriptors' busiest instructions were the first loads of each stage's descriptor lists (kept inside the
Stage's Shader::Info, ~10 cache lines of it): a miss a list, one after another. The build now prefetches each
stage's Info from the uniform buffers' used sizes to the end of the image descriptors before anything else, so the
misses overlap. A hint only: the same writes.

Not measured for this port: no micro-benchmark, no run in play (the batch it came in on the branch, cc4c6c42,
showed no difference in play).

Test: tests/test_desc_info_prefetch.py checks the prefetch is the build's first work and that every list the build
reads lies inside the prefetched range of Shader::Info (shader_info.h's order). No switch.

Assisted-by: Claude Code
Author
Contributor

@Beanstalk This changes how the renderer builds descriptors, lists first (gpu/vk), for every draw. No switch: a revert gives back main's code. It has not run in the game on these PCs yet. Please play Kokiri Forest and Hyrule Field, two minutes each, the PR against main on the same PC, with a picture in each compared with main's, on Linux with NVIDIA, Linux with AMD (RADV), Windows with Intel and the Steam Deck. The same picture as main, no crash, device lost, validation error or FATAL line; frame time p99 equal to main's or better, within the run-to-run spread.

@Beanstalk This changes how the renderer builds descriptors, lists first (gpu/vk), for every draw. No switch: a revert gives back main's code. It has not run in the game on these PCs yet. Please play Kokiri Forest and Hyrule Field, two minutes each, the PR against main on the same PC, with a picture in each compared with main's, on Linux with NVIDIA, Linux with AMD (RADV), Windows with Intel and the Steam Deck. The same picture as main, no crash, device lost, validation error or FATAL line; frame time p99 equal to main's or better, within the run-to-run spread.
Member

@siantm only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@siantm only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Contributor

Steam Deck result: I ran this PR against main on a Steam Deck OLED, standing in the Market, three pairs. It showed no difference the Deck can resolve (-0.6 % on the median, the two sides' runs overlapping), and no errors in any log.

main @ 9dd41326 main + this PR @ 41c1c6de Δ
fps (each run) 26.2 / 26.7 / 26.7 (median 26.7) 26.4 / 27.0 / 26.5 (median 26.5) -0.6 %
1% low fps (1000 / p99) 17.1 17.5 +2.1 %
median frame time 36.51 ms 36.62 ms +0.11 ms
p99 frame time 58.35 ms 57.17 ms -1.18 ms
frames of 50 ms or more (each run) 95 / 85 / 79 97 / 64 / 84

dev.py ab's verdict: no difference shown: -0.6 % fps (median 26.5 against 26.7), within the runs' spread (A 26.2 to 26.7, B 26.4 to 27.0). No FATAL, device-lost, VK_ERROR or validation line in the 6 logs; every run exited normally.

Hardware: Steam Deck OLED, SteamOS 3.9.5, RADV VANGOGH, Mesa 26.2.0-devel, GPU clock manual 1600 MHz, headless.
Settings: Minimum, Render 50 % (640x400), output 1280x800, uncapped, V-Sync and frame generation off.
Game data: complete (the dump, with the three damaged textures replaced).
Built: main @ 9dd41326 and main 9dd41326 with this PR's head 41c1c6de merged in (1 commit, no conflicts), x86-64-v3, shaders prepared on the Deck; only the renderer differs.
Measured: dev.py ab, Market, 3 interleaved pairs of 60 s after the warm-up, the median (the project's tool, with a local change to compare two prebuilt runtimes, since the Deck does not build).

Limits: three runs a side on one Deck, headless, one standing scene; on this Deck that resolves about 5 %, so a saving of a few tenths of a millisecond of the replay's CPU a frame would not show.

Steam Deck result: I ran this PR against main on a Steam Deck OLED, standing in the Market, three pairs. It showed no difference the Deck can resolve (-0.6 % on the median, the two sides' runs overlapping), and no errors in any log. | | main @ 9dd41326 | main + this PR @ 41c1c6de | Δ | |---|---|---|---| | fps (each run) | 26.2 / 26.7 / 26.7 (median 26.7) | 26.4 / 27.0 / 26.5 (median 26.5) | -0.6 % | | 1% low fps (1000 / p99) | 17.1 | 17.5 | +2.1 % | | median frame time | 36.51 ms | 36.62 ms | +0.11 ms | | p99 frame time | 58.35 ms | 57.17 ms | -1.18 ms | | frames of 50 ms or more (each run) | 95 / 85 / 79 | 97 / 64 / 84 | | `dev.py ab`'s verdict: **no difference shown**: -0.6 % fps (median 26.5 against 26.7), within the runs' spread (A 26.2 to 26.7, B 26.4 to 27.0). No `FATAL`, device-lost, `VK_ERROR` or validation line in the 6 logs; every run exited normally. Hardware: Steam Deck OLED, SteamOS 3.9.5, RADV VANGOGH, Mesa 26.2.0-devel, GPU clock manual 1600 MHz, headless. Settings: Minimum, Render 50 % (640x400), output 1280x800, uncapped, V-Sync and frame generation off. Game data: complete (the dump, with the three damaged textures replaced). Built: main @ 9dd41326 and main 9dd41326 with this PR's head 41c1c6de merged in (1 commit, no conflicts), x86-64-v3, shaders prepared on the Deck; only the renderer differs. Measured: `dev.py ab`, Market, 3 interleaved pairs of 60 s after the warm-up, the median (the project's tool, with a local change to compare two prebuilt runtimes, since the Deck does not build). Limits: three runs a side on one Deck, headless, one standing scene; on this Deck that resolves about 5 %, so a saving of a few tenths of a millisecond of the replay's CPU a frame would not show.
Author
Contributor

@zeldaootr thank you for running this on a Steam Deck OLED and for writing down the setup and its limits. It is now cited in Measurements as your run, with the about 5 % it resolves, beside the A/B still to do on this PC; 41c1c6de is still this pull request's head.

@zeldaootr thank you for running this on a Steam Deck OLED and for writing down the setup and its limits. It is now cited in Measurements as your run, with the about 5 % it resolves, beside the A/B still to do on this PC; 41c1c6de is still this pull request's head.
Author
Contributor

@Beanstalk This replaces my request 65289 on this head, so that it follows the farm's picture and hardware rules. This changes how the renderer builds descriptors for every draw, asking for its stages' descriptor lists first (gpu/vk). No switch: a revert gives back main's code. Please start from the kokiri-start save and take the picture right after it loads and settles, before any input, with a main-against-itself picture on the same PC at that point; then, for frame times only, play Kokiri Forest and Hyrule Field, two minutes each; at least two starts a side, interleaved, the PR against main on the same PC, on Windows with an RTX 4070, Windows with an Arc B580, Linux with an RX 6600 (RADV) and the Steam Deck. The same picture as main within main's own difference from itself; frame time p99 equal to main's or better, within the run-to-run spread. The log must have no FATAL, device lost or validation error line.

@Beanstalk This replaces my request 65289 on this head, so that it follows the farm's picture and hardware rules. This changes how the renderer builds descriptors for every draw, asking for its stages' descriptor lists first (gpu/vk). No switch: a revert gives back main's code. Please start from the kokiri-start save and take the picture right after it loads and settles, before any input, with a main-against-itself picture on the same PC at that point; then, for frame times only, play Kokiri Forest and Hyrule Field, two minutes each; at least two starts a side, interleaved, the PR against main on the same PC, on Windows with an RTX 4070, Windows with an Arc B580, Linux with an RX 6600 (RADV) and the Steam Deck. The same picture as main within main's own difference from itself; frame time p99 equal to main's or better, within the run-to-run spread. The log must have no FATAL, device lost or validation error line.
Member

@siantm only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@siantm only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Author
Contributor

Measurements: a micro-benchmark on authored input (old against new, three rounds, x86-64 baseline and -march=native; not measured in play) and the Verdict rewritten to match; the third party's in-game run kept.

Measurements: a micro-benchmark on authored input (old against new, three rounds, x86-64 baseline and -march=native; not measured in play) and the Verdict rewritten to match; the third party's in-game run kept.
Author
Contributor

@Beanstalk One correction to my request 69679 above, for its picture point: please take each picture 5 s (300 frames at 60 fps) after the first frame whose picture is not a single uniform colour, with no input in between, and take the main-against-itself picture from the same point. A picture taken during the load's fade-in from black is not comparable: run 70269 on #2156 caught the fade in 3 of 4 starts.

@Beanstalk One correction to my request 69679 above, for its picture point: please take each picture 5 s (300 frames at 60 fps) after the first frame whose picture is not a single uniform colour, with no input in between, and take the main-against-itself picture from the same point. A picture taken during the load's fade-in from black is not comparable: run 70269 on #2156 caught the fade in 3 of 4 starts.
Member

@siantm only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@siantm only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 29s
beanstalk/approval waiting for a BigBean's 👍 on the request
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'perf/vk-desc-lists-first:siantm-perf/vk-desc-lists-first'
git switch 'siantm-perf/vk-desc-lists-first'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2045
No description provided.