test(vk): the image reaper's threads check ends its process at once, as the game does on Linux #2000

Open
cuecuemoar wants to merge 1 commit from cuecuemoar/Longshot:fix/reap-cap-linux-build into main
Contributor

Summary

tests/test_image_reaper_threads.py runs the image reaper of gpu/vk/vk_vma.cpp on threads against stubs. It could not finish on Linux. Until #1941 it did not compile there (the reaper's cap lambda, #1914). With that fixed, every case passes and the program prints image reaper, on threads: ok, and then never exits: the reaper is a detached thread waiting on the namespace-level condition variable reap_cv, and a return from main runs that variable's destructor, which blocks on glibc while a thread still waits on it. The runner waits out its 120 s and fails the check. A failing case ends the same way, through return 1, so a broken reaper hung for the same 120 s and its FAIL: ... line, buffered in the pipe, was lost with the killed process.

To see it on main (Linux, Ubuntu 22.04 under WSL2, glibc 2.35): python -I -B tests/test_image_reaper_threads.py --cxx clang++ prints the ok line and does not return; tests/run_all.py reports it failed after 121.6 s.

The game does not end like that: host/posix/win32_posix.c ExitProcess is _exit, "at once, as Windows ends the other threads first: exit() would run static destructors under running threads". The fixture now ends the same way on both paths: finish() flushes its output and calls std::_Exit, and CHECK uses it. Read first: finish and CHECK in the fixture. Test-only: no game code, no switch, no docs.

Testing

Tested: On Linux (Ubuntu 22.04 under WSL2, clang++ 23.1.5 and g++ 13.4) at c4d385a8, on main f1f2dc5b: the check passes in 1 to 2 s with both compilers. On main it hangs with both (killed after 45 s; at a7646537 with both compilers, at 6e1521a7 with clang++; the runner's own limit is 120 s and it failed after 121.6 s in the suite run below). With a copy of vk_vma.cpp edited to break the reaper (--vma), the check now fails in about a second with its own message: a reaper that frees inside a compaction pass gives FAIL: a free was made while a compaction pass was open, and one that keeps no count gives FAIL: reaper_bytes is not 0 once the queue drained; before this change both hung for the full limit. On Windows (llvm-mingw's clang++ from the Longshot Builder's tools, run from WSL): the check passes in 3 s, with this change and with main's original, so the Windows behaviour is the same. tests/test_image_reaper.py (the same source, read as text) passes.

The whole suite (tests/run_all.py in WSL on Ubuntu 22.04, without --strict), at 7a02e64e (this change before the rebase onto one more main commit, a host change that touches nothing this check reads) and at its base, main 6e1521a7, one after the other: 794 passed, 93 failed, 18 skipped on the PR head; 793 passed, 94 failed, 18 skipped on main. No check fails only on the PR head; the one that differs is this one (121.6 s and failing on main, 2.1 s and passing here), and the other 92 failing files are the same on both, named in the comment posted with this description. One check is skipped here because dav1d is not installed, and --strict would fail it.

Still to test: None. (Not run: this check by hand on a Linux machine other than this one.)

Measurements

Nothing to measure: it changes how a test program ends, and no game code runs.

Risks

None for the game: no game code changes. The fixture ends its process without running static destructors, as the game's own ExitProcess does on Linux; A revert restores the hang.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit. (Rebased onto main f1f2dc5b when pushed.)
  • Tested on my own PC, in the game for a change the game runs, as Testing says. (A test-only change: no game code runs.)
  • mise run test passes (any failure that also fails on main is named). (tests/run_all.py without --strict: no check fails only on the PR head; the 92 files that fail on it also fail on main, named in the comment posted with this description; see Testing.)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here. (The check itself: it fails on main after 121.6 s and passes here in 2.1 s.)
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VxeaZmyPR6ARfQnykGHqw6

## Summary `tests/test_image_reaper_threads.py` runs the image reaper of `gpu/vk/vk_vma.cpp` on threads against stubs. It could not finish on Linux. Until #1941 it did not compile there (the reaper's cap lambda, #1914). With that fixed, every case passes and the program prints `image reaper, on threads: ok`, and then never exits: the reaper is a detached thread waiting on the namespace-level condition variable `reap_cv`, and a `return` from `main` runs that variable's destructor, which blocks on glibc while a thread still waits on it. The runner waits out its 120 s and fails the check. A failing case ends the same way, through `return 1`, so a broken reaper hung for the same 120 s and its `FAIL: ...` line, buffered in the pipe, was lost with the killed process. To see it on main (Linux, Ubuntu 22.04 under WSL2, glibc 2.35): `python -I -B tests/test_image_reaper_threads.py --cxx clang++` prints the `ok` line and does not return; `tests/run_all.py` reports it failed after 121.6 s. The game does not end like that: `host/posix/win32_posix.c` `ExitProcess` is `_exit`, "at once, as Windows ends the other threads first: exit() would run static destructors under running threads". The fixture now ends the same way on both paths: `finish()` flushes its output and calls `std::_Exit`, and `CHECK` uses it. Read first: `finish` and `CHECK` in the fixture. Test-only: no game code, no switch, no docs. ## Testing **Tested:** On Linux (Ubuntu 22.04 under WSL2, clang++ 23.1.5 and g++ 13.4) at c4d385a8, on main f1f2dc5b: the check passes in 1 to 2 s with both compilers. On main it hangs with both (killed after 45 s; at a7646537 with both compilers, at 6e1521a7 with clang++; the runner's own limit is 120 s and it failed after 121.6 s in the suite run below). With a copy of `vk_vma.cpp` edited to break the reaper (`--vma`), the check now fails in about a second with its own message: a reaper that frees inside a compaction pass gives `FAIL: a free was made while a compaction pass was open`, and one that keeps no count gives `FAIL: reaper_bytes is not 0 once the queue drained`; before this change both hung for the full limit. On Windows (llvm-mingw's clang++ from the Longshot Builder's tools, run from WSL): the check passes in 3 s, with this change and with main's original, so the Windows behaviour is the same. `tests/test_image_reaper.py` (the same source, read as text) passes. The whole suite (`tests/run_all.py` in WSL on Ubuntu 22.04, without `--strict`), at 7a02e64e (this change before the rebase onto one more main commit, a host change that touches nothing this check reads) and at its base, main 6e1521a7, one after the other: 794 passed, 93 failed, 18 skipped on the PR head; 793 passed, 94 failed, 18 skipped on main. No check fails only on the PR head; the one that differs is this one (121.6 s and failing on main, 2.1 s and passing here), and the other 92 failing files are the same on both, named in the comment posted with this description. One check is skipped here because dav1d is not installed, and `--strict` would fail it. **Still to test:** None. (Not run: this check by hand on a Linux machine other than this one.) ## Measurements Nothing to measure: it changes how a test program ends, and no game code runs. ## Risks None for the game: no game code changes. The fixture ends its process without running static destructors, as the game's own `ExitProcess` does on Linux; A revert restores the hang. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. (Rebased onto main f1f2dc5b when pushed.) - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. (A test-only change: no game code runs.) - [x] `mise run test` passes (any failure that also fails on `main` is named). (`tests/run_all.py` without `--strict`: no check fails only on the PR head; the 92 files that fail on it also fail on main, named in the comment posted with this description; see Testing.) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. (The check itself: it fails on main after 121.6 s and passes here in 2.1 s.) - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01VxeaZmyPR6ARfQnykGHqw6
test(vk): the image reaper's threads check ends its process at once, as the game does on Linux
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
c4d385a839
tests/test_image_reaper_threads.py runs the reaper of gpu/vk/vk_vma.cpp on threads against stubs. It did not compile on
Linux until the reaper's cap lambda was fixed (#1941). Now that it does, every case passes and the program then never
exits: the reaper is a detached thread waiting on the namespace-level condition variable reap_cv, and a return from main
runs that variable's destructor, which blocks on glibc while a thread still waits on it. The runner waits out its 120 s
and fails the check.

A failed case ends the same way, through `return 1`, so a broken reaper hung for the same 120 s and its "FAIL: ..." line,
buffered in the pipe, was lost with the killed process.

The game does not end like that: host/posix/win32_posix.c ExitProcess is _exit, "at once, as Windows ends the other
threads first". The fixture ends the same way, after flushing its result, on both paths (finish): the check now passes in
about a second on clang++ and g++ 13, and a reaper that frees inside a compaction pass, or that keeps no count, fails in
about a second with its own message.

Assisted-by: Claude Code
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01VxeaZmyPR6ARfQnykGHqw6
Author
Contributor

The suite, on the exact commits (tests/run_all.py, WSL on Ubuntu 22.04, not --strict, 32 at once), one after the other: this change at 7a02e64e (before a rebase onto one more main commit, f1f2dc5b, a host change that touches nothing this check reads; the check was run again on c4d385a8 and passes in 1 to 2 s with clang++ and g++ 13) and its base, main 6e1521a7:

  • PR head: 794 passed, 93 failed, 18 skipped
  • main: 793 passed, 94 failed, 18 skipped

No check fails only on the PR head. The one that differs is this one: tests/test_image_reaper_threads.py fails on main after 121.6 s (the runner's limit) and passes here in 2.1 s. The other 92 check files fail on both, so they are not this change's:

nx2/test_coop_spirv.py
tests/test_appimage_player_build.py
tests/test_bug_report_defaults.py
tests/test_capture_read_once.py
tests/test_capture_readback_visibility.py
tests/test_cpp_preflight.py
tests/test_crash_dialog.py
tests/test_crash_record.py
tests/test_crt_options.py
tests/test_damage_debug_menu.py
tests/test_dev_ab.py
tests/test_dev_packs.py
tests/test_dev_update.py
tests/test_device_lost_exit.py
tests/test_display_startup_failure.py
tests/test_dlss_actor.py
tests/test_dlss_feature_size.py
tests/test_draw_binds.py
tests/test_draw_stream_visibility.py
tests/test_failed_compile_keeps_objects.py
tests/test_flush_nothing_held.py
tests/test_frame_overlap.py
tests/test_fsr3_math.py
tests/test_fsr3_shaders.py
tests/test_fsr3fi_hud_layer.py
tests/test_fsr3fi_hudless_colour.py
tests/test_fsr_image_retirement.py
tests/test_fsr_uniform_ownership.py
tests/test_gpu_wait_stats.py
tests/test_guest_imported.py
tests/test_high_fps_fixes.py
tests/test_host_guest_writes.py
tests/test_late_fix_shaders.py
tests/test_libc_hooks.py
tests/test_lift_cache.py
tests/test_linux_preflight.py
tests/test_linux_pressure.py
tests/test_linux_tools.py
tests/test_linux_update.py
tests/test_log_open_failure.py
tests/test_low_vram_texture_mips.py
tests/test_make_game_ngx.py
tests/test_menu_module_slots.py
tests/test_menu_modules.py
tests/test_menu_sections.py
tests/test_mesh_conv.py
tests/test_mesh_unreachable_outputs.py
tests/test_mise_build.py
tests/test_missing_nup.py
tests/test_mods_list.py
tests/test_mods_size_table.py
tests/test_ngx_sdk.py
tests/test_nonuniform_image_arrays.py
tests/test_obj_cache_size.py
tests/test_oot_shadow_fit.py
tests/test_pads_after_menu.py
tests/test_pass_barrier.py
tests/test_pending_guest_import.py
tests/test_pipeline_play_cache.py
tests/test_pipelines_outlive_cache_format.py
tests/test_prepare_cache_save.py
tests/test_present_queue_default.py
tests/test_present_source_crop.py
tests/test_prof_clock.py
tests/test_profiling_mode.py
tests/test_program_cache_cleanup.py
tests/test_program_cache_one_variant.py
tests/test_psychov35_fsr3_fg.py
tests/test_reactive_mask.py
tests/test_readback_timeout_source.py
tests/test_recorder_own_idle.py
tests/test_recorder_sync.py
tests/test_reflex_swapchain_lifetime.py
tests/test_renderer_new_handler.py
tests/test_renhdrum.py
tests/test_replay_write_order.py
tests/test_sampler_admission.py
tests/test_settings_table.py
tests/test_slow_frames.py
tests/test_song_note_cue.py
tests/test_sparse_mirror.py
tests/test_spirv_pack.py
tests/test_sprint.py
tests/test_staging_burst.py
tests/test_target_reuse_memory.py
tests/test_texel_buffer_ownership.py
tests/test_ub_update_batch.py
tests/test_ui_record.py
tests/test_upscaler_rows.py
tests/test_vcore_escape.py
tests/test_vcore_mask0.py
tests/test_vk_occlusion_queries.py

From the failure output (not every test): tests that cut code out of main's source and no longer find it, and checks that regenerate or validate SPIR-V with the glslang 11.8 and spirv-tools 2022.1 of Ubuntu 22.04, older than the repository's pins. One check, test_dav1d_av1, is skipped here because dav1d is not installed.

The suite, on the exact commits (`tests/run_all.py`, WSL on Ubuntu 22.04, not `--strict`, 32 at once), one after the other: this change at 7a02e64e (before a rebase onto one more main commit, f1f2dc5b, a host change that touches nothing this check reads; the check was run again on c4d385a8 and passes in 1 to 2 s with clang++ and g++ 13) and its base, main 6e1521a7: - PR head: **794 passed, 93 failed, 18 skipped** - main: **793 passed, 94 failed, 18 skipped** No check fails only on the PR head. The one that differs is this one: `tests/test_image_reaper_threads.py` fails on main after 121.6 s (the runner's limit) and passes here in 2.1 s. The other 92 check files fail on both, so they are not this change's: ``` nx2/test_coop_spirv.py tests/test_appimage_player_build.py tests/test_bug_report_defaults.py tests/test_capture_read_once.py tests/test_capture_readback_visibility.py tests/test_cpp_preflight.py tests/test_crash_dialog.py tests/test_crash_record.py tests/test_crt_options.py tests/test_damage_debug_menu.py tests/test_dev_ab.py tests/test_dev_packs.py tests/test_dev_update.py tests/test_device_lost_exit.py tests/test_display_startup_failure.py tests/test_dlss_actor.py tests/test_dlss_feature_size.py tests/test_draw_binds.py tests/test_draw_stream_visibility.py tests/test_failed_compile_keeps_objects.py tests/test_flush_nothing_held.py tests/test_frame_overlap.py tests/test_fsr3_math.py tests/test_fsr3_shaders.py tests/test_fsr3fi_hud_layer.py tests/test_fsr3fi_hudless_colour.py tests/test_fsr_image_retirement.py tests/test_fsr_uniform_ownership.py tests/test_gpu_wait_stats.py tests/test_guest_imported.py tests/test_high_fps_fixes.py tests/test_host_guest_writes.py tests/test_late_fix_shaders.py tests/test_libc_hooks.py tests/test_lift_cache.py tests/test_linux_preflight.py tests/test_linux_pressure.py tests/test_linux_tools.py tests/test_linux_update.py tests/test_log_open_failure.py tests/test_low_vram_texture_mips.py tests/test_make_game_ngx.py tests/test_menu_module_slots.py tests/test_menu_modules.py tests/test_menu_sections.py tests/test_mesh_conv.py tests/test_mesh_unreachable_outputs.py tests/test_mise_build.py tests/test_missing_nup.py tests/test_mods_list.py tests/test_mods_size_table.py tests/test_ngx_sdk.py tests/test_nonuniform_image_arrays.py tests/test_obj_cache_size.py tests/test_oot_shadow_fit.py tests/test_pads_after_menu.py tests/test_pass_barrier.py tests/test_pending_guest_import.py tests/test_pipeline_play_cache.py tests/test_pipelines_outlive_cache_format.py tests/test_prepare_cache_save.py tests/test_present_queue_default.py tests/test_present_source_crop.py tests/test_prof_clock.py tests/test_profiling_mode.py tests/test_program_cache_cleanup.py tests/test_program_cache_one_variant.py tests/test_psychov35_fsr3_fg.py tests/test_reactive_mask.py tests/test_readback_timeout_source.py tests/test_recorder_own_idle.py tests/test_recorder_sync.py tests/test_reflex_swapchain_lifetime.py tests/test_renderer_new_handler.py tests/test_renhdrum.py tests/test_replay_write_order.py tests/test_sampler_admission.py tests/test_settings_table.py tests/test_slow_frames.py tests/test_song_note_cue.py tests/test_sparse_mirror.py tests/test_spirv_pack.py tests/test_sprint.py tests/test_staging_burst.py tests/test_target_reuse_memory.py tests/test_texel_buffer_ownership.py tests/test_ub_update_batch.py tests/test_ui_record.py tests/test_upscaler_rows.py tests/test_vcore_escape.py tests/test_vcore_mask0.py tests/test_vk_occlusion_queries.py ``` From the failure output (not every test): tests that cut code out of main's source and no longer find it, and checks that regenerate or validate SPIR-V with the glslang 11.8 and spirv-tools 2022.1 of Ubuntu 22.04, older than the repository's pins. One check, `test_dav1d_av1`, is skipped here because dav1d is not installed.
cuecuemoar changed title from WIP: test(vk): the image reaper's threads check ends its process at once, as the game does on Linux to test(vk): the image reaper's threads check ends its process at once, as the game does on Linux 2026-11-21 03:50:24 +00:00
BeanBot left a comment

Recommendation: Request changes. The fixture fix addresses the Linux shutdown hang and preserves failure messages. The PR needs to correct its checked test requirement and account for the reported suite failures before merge.

The threaded image-reaper test flushes its result and exits before static teardown can block on the detached worker. The change is small, preserves the existing assertions, and affects only the test process.

@fix will do (3)

  1. L1: The PR ticks the mise run test box and says there is nothing still to test. That task runs with --strict, while the reported suite run omitted it and skipped a check for missing dav1d. Untick the box and list the strict suite comparison as outstanding until the required checks have run and any shared failures have been identified.
  2. L2: The description points to a comment naming the shared failures, but the PR has no comments. It also reports 93 failures on the PR and 94 on main while accounting for only 92 shared failures and the reaper timeout. Post the failure list for both runs and reconcile the totals, including any failing suite check outside the file list.
  3. L3 (minor): Testing omits the mise run lint result that CONTRIBUTING.md asks authors to report. Add the lint result for the current head, including the Python check for the changed fixture.

Checks: Still running: CI / Conventional Commit title (pull_request), CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request), CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request), CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request), CI / Workflow lint (actionlint) (pull_request), CI / Website build and checks (pull_request), Guide screenshots / Guide images and local UI source review (pull_request), Third-party parts / As their notes say (pull_request), Third-party parts / The same as upstream (pull_request), PR description / Description follows the template (pull_request_target).

More: does it help, other systems, switches, what was read

Does it help: Yes. The reported WSL2 suite comparison went from a 121.6 s timeout on 6e1521a7 to a 2.1 s pass on 7a02e64e. The author reports 1–2 s passes at c4d385a8 with clang++ and g++, and a roughly 3 s pass on both sides with Windows llvm-mingw. Two deliberately broken reapers reportedly failed in about a second with their expected diagnostics. These are test timings.

Other systems: The change is confined to the compiled fixture. The Python runner still checks the child exit status, enforces its timeout, and cleans up the temporary directory. The successful switch-off case still returns normally because it starts no worker. GPU vendors, drivers, Steam Deck gameplay, memory budgets, saves, audio, input, and game builds are outside the changed path.

Switches: None added, changed, or removed. The existing RX_VK_REAPER default is on. The fixture tests both settings through its own stub and command-line argument, independent of the game environment.

Reviewed: c4d385a839 against f1f2dc5bd2: Read AGENTS.md, CONTRIBUTING.md, docs/dev/README.md, docs/dev/standards.md, the Forgejo PR template, the full diff and commit message, and every line of tests/test_image_reaper_threads.py twice. Read the extracted compaction and reaper code in gpu/vk/vk_vma.cpp, the companion source check, the POSIX ExitProcess implementation, and the relevant runner, mise, and CI sections. No review checklist was present. Run evidence came from the PR description. There were no comments, prior reviews, generated files, or translations to inspect.; nothing run (a code review).

Checked and fine:

  • The threaded success path and all assertion failures flush stdout and exit with the expected status. Restoring the original threaded return would bring back the reported glibc hang.
  • The patch leaves the reaper synchronization and behavioral assertions intact. It adds no shared state, allocation, index, or file access.
  • The suite selects the compiler through CXX or a compiler on PATH. The patch adds no compiler path, CPU flag, or new tool invocation.
  • The commit contains the required AI assistance trailers. The diff contains only fixture source and adds no game data, build output, generated files, third-party changes, or renderer API changes.

Testing: Read-only review. The author reports Linux clang++ and g++ passes, a Windows llvm-mingw pass, a companion source-check pass, and both negative controls. The reported suite run was non-strict and used an earlier revision. CI was listed as pending.

Overlaps and merge order: None found. The referenced reaper compile fix #1941 is already in the base.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The fixture fix addresses the Linux shutdown hang and preserves failure messages. The PR needs to correct its checked test requirement and account for the reported suite failures before merge. The threaded image-reaper test flushes its result and exits before static teardown can block on the detached worker. The change is small, preserves the existing assertions, and affects only the test process. **`@fix` will do (3)** 1. **L1**: The PR ticks the `mise run test` box and says there is nothing still to test. That task runs with `--strict`, while the reported suite run omitted it and skipped a check for missing dav1d. Untick the box and list the strict suite comparison as outstanding until the required checks have run and any shared failures have been identified. 2. **L2**: The description points to a comment naming the shared failures, but the PR has no comments. It also reports 93 failures on the PR and 94 on main while accounting for only 92 shared failures and the reaper timeout. Post the failure list for both runs and reconcile the totals, including any failing suite check outside the file list. 3. **L3** (minor): Testing omits the `mise run lint` result that CONTRIBUTING.md asks authors to report. Add the lint result for the current head, including the Python check for the changed fixture. **Checks:** Still running: `CI / Conventional Commit title (pull_request)`, `CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request)`, `CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request)`, `CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request)`, `CI / Workflow lint (actionlint) (pull_request)`, `CI / Website build and checks (pull_request)`, `Guide screenshots / Guide images and local UI source review (pull_request)`, `Third-party parts / As their notes say (pull_request)`, `Third-party parts / The same as upstream (pull_request)`, `PR description / Description follows the template (pull_request_target)`. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes. The reported WSL2 suite comparison went from a 121.6 s timeout on 6e1521a7 to a 2.1 s pass on 7a02e64e. The author reports 1–2 s passes at c4d385a8 with clang++ and g++, and a roughly 3 s pass on both sides with Windows llvm-mingw. Two deliberately broken reapers reportedly failed in about a second with their expected diagnostics. These are test timings. **Other systems:** The change is confined to the compiled fixture. The Python runner still checks the child exit status, enforces its timeout, and cleans up the temporary directory. The successful switch-off case still returns normally because it starts no worker. GPU vendors, drivers, Steam Deck gameplay, memory budgets, saves, audio, input, and game builds are outside the changed path. **Switches:** None added, changed, or removed. The existing RX_VK_REAPER default is on. The fixture tests both settings through its own stub and command-line argument, independent of the game environment. **Reviewed:** c4d385a839a8 against f1f2dc5bd282: Read AGENTS.md, CONTRIBUTING.md, docs/dev/README.md, docs/dev/standards.md, the Forgejo PR template, the full diff and commit message, and every line of tests/test_image_reaper_threads.py twice. Read the extracted compaction and reaper code in gpu/vk/vk_vma.cpp, the companion source check, the POSIX ExitProcess implementation, and the relevant runner, mise, and CI sections. No review checklist was present. Run evidence came from the PR description. There were no comments, prior reviews, generated files, or translations to inspect.; nothing run (a code review). **Checked and fine:** - The threaded success path and all assertion failures flush stdout and exit with the expected status. Restoring the original threaded return would bring back the reported glibc hang. - The patch leaves the reaper synchronization and behavioral assertions intact. It adds no shared state, allocation, index, or file access. - The suite selects the compiler through CXX or a compiler on PATH. The patch adds no compiler path, CPU flag, or new tool invocation. - The commit contains the required AI assistance trailers. The diff contains only fixture source and adds no game data, build output, generated files, third-party changes, or renderer API changes. **Testing:** Read-only review. The author reports Linux clang++ and g++ passes, a Windows llvm-mingw pass, a companion source-check pass, and both negative controls. The reported suite run was non-strict and used an earlier revision. CI was listed as pending. **Overlaps and merge order:** None found. The referenced reaper compile fix #1941 is already in the base. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/reap-cap-linux-build:cuecuemoar-fix/reap-cap-linux-build'
git switch 'cuecuemoar-fix/reap-cap-linux-build'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2000
No description provided.