feat(reshade): add Vulkan presets and live comparison #1861
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1861
Loading…
Reference in a new issue
No description provided.
Delete branch "Valerio85/Longshot:codex/reshade-presets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Graphics → Post-processing adds optional ReShade FX presets. Choose from the bundled grades or import an INI and its effects. The comparison view lets you toggle the effect and browse presets in the same scene. Back restores the saved selection.
Start with
gpu/vk/menu/reshade.cppfor the interface andgpu/vk/reshade/fx_runtime.cppfor the effect compiler and Vulkan pass scheduling. See the preset guide for import instructions, HDR behavior and the supported FX subset.The 20 Clarity profiles adapt names and settings from the CC0 Cemu graphics pack at
496df203. The shader and the five other built-in effects are Longshot code. The two new vendor directories carry the original BSD-3-Clause and MIT notices, which follow the compiler and PNG decoder into the builder and generated game folder. See the upstream Clarity license.Why ReShade built into the renderer, not an external app
Longshot runs ReShade FX effects inside its own Vulkan renderer instead of relying on an external injector. Here are the trade-offs.
Advantages
longshot_options.ini.Disadvantages and trade-offs
.iniand rescan..initoreshade/presets, the.fx/.fxhfiles toreshade/shadersand any PNG textures toreshade/textures, then use Rescan in the menu.An external ReShade is still the better choice for authoring and tuning a preset interactively. A preset made there can then be imported into Longshot.
Testing
Tested: Windows, NVIDIA GeForce RTX 5080, driver 617.42. At
d05f599, Warm ran before the HUD, the Italian comparison toggled the effect, browsed built-ins and both imported INI files, and Back restored the saved preset and file. Captured89c3d21andd05f599at the same position in the Kokiri Forest start save, plus the two- and three-row comparison views. Earlier topic revisions also ran linear Native HDR, Expanded HDR, depth and frame generation paths. The current renderer links on Windows with llvm-mingw and on Linux with clang. Twelve targeted checks passed on Windows, including the 14-language localization check, UTF-8 paths, FX import, HUD capture, AppImage notices and vendor provenance.The Windows strict game-free checks at
89c3d21and on the branch reported the same 77 failing checks and the same 180-second timeout intest_vbytes.py. Every non-passing check on the branch matched the result on main, as listed below. The initial runs stopped at the Windows queue fixture. An isolated run confirmed thattest_job_queue.pyfails on both revisions intest_a_game_and_a_jobs_gameandtest_ram_file_system. The remaining checks were resumed on both sides. The comparison action's settings-table fixture was corrected ate1ceac6and passed on rerun. Local totals with those reruns are 755 passes onmainand 756 on the branch, with 48 skips on each. The queue test completed in the Linux container, where the five Windows-only cases are skipped.Matching Windows check results
nx2/test_nup_paths.py(fail)tests/test_appimage_player_build.py(fail)tests/test_auto_handheld.py(fail)tests/test_bug_report_defaults.py(fail)tests/test_build_long_paths.py(fail)tests/test_capture_read_once.py(fail)tests/test_capture_readback_visibility.py(fail)tests/test_control.py(fail)tests/test_copy_writable.py(fail)tests/test_crash_dialog.py(fail)tests/test_crt_options.py(fail)tests/test_damage_debug_menu.py(fail)tests/test_dev_ab.py(fail)tests/test_dev_build.py(fail)tests/test_dev_migrate.py(fail)tests/test_dev_packs.py(fail)tests/test_display_startup_failure.py(fail)tests/test_dlss_feature_size.py(fail)tests/test_draw_binds.py(fail)tests/test_draw_stream_visibility.py(fail)tests/test_early_split_before_draw.py(fail)tests/test_failed_compile_keeps_objects.py(fail)tests/test_finish_output.py(fail)tests/test_frame_overlap.py(fail)tests/test_fsr3fi_hud_layer.py(fail)tests/test_fsr3fi_hudless_colour.py(fail)tests/test_fsr_image_retirement.py(fail)tests/test_fsr_uniform_ownership.py(fail)tests/test_game_menu_mouse_buttons.py(fail)tests/test_guest_imported.py(fail)tests/test_high_fps_fixes.py(fail)tests/test_hold_gpu.py(fail)tests/test_host_guest_writes.py(fail)tests/test_hud_layout_row.py(fail)tests/test_job_queue.py(fail on isolated rerun)tests/test_libc_hooks.py(fail)tests/test_lift_cache.py(fail)tests/test_linux_preflight.py(fail)tests/test_linux_pressure.py(fail)tests/test_long_paths.py(fail)tests/test_low_vram_texture_mips.py(fail)tests/test_make_game_cache.py(fail)tests/test_make_game_ngx.py(fail)tests/test_mise_build.py(fail)tests/test_missing_nup.py(fail)tests/test_mods_list.py(fail)tests/test_ngx_sdk.py(fail)tests/test_options_path.py(fail)tests/test_pads_after_menu.py(fail)tests/test_pass_barrier.py(fail)tests/test_pending_guest_import.py(fail)tests/test_perf_report.py(fail)tests/test_pipeline_cache_file.py(fail)tests/test_pipeline_play_cache.py(fail)tests/test_portable_builder_home.py(fail)tests/test_prepare_cache_save.py(fail)tests/test_present_queue_default.py(fail)tests/test_present_source_crop.py(fail)tests/test_profiling_mode.py(fail)tests/test_psychov35_fsr3_fg.py(fail)tests/test_readback_early.py(fail)tests/test_readback_late.py(fail)tests/test_readback_timeout_source.py(fail)tests/test_recording_admission.py(fail)tests/test_replay_write_order.py(fail)tests/test_sampler_admission.py(fail)tests/test_sdiv_overflow.py(fail)tests/test_slow_frames.py(fail)tests/test_song_note_cue.py(fail)tests/test_split_before_draw.py(fail)tests/test_staging_burst.py(fail)tests/test_texel_buffer_ownership.py(fail)tests/test_ub_update_batch.py(fail)tests/test_upscaler_rows.py(fail)tests/test_vbytes.py(timeout)tests/test_vcore_escape.py(fail)tests/test_vk_occlusion_queries.py(fail)tests/test_walk_key.py(fail)Still to test:
Measurements
Verdict: No regression was observed with ReShade Off in this scene. The median of the run averages was 143.96 FPS on main and 149.22 FPS with Off. Warm measured 147.56 FPS (-1.1% versus Off).
Setup: Windows, RTX 5080, driver 617.42. Kokiri Forest start save, identical release host executable and game files, fixed SDR settings, no FPS overlay or frame generation. Two interleaved 30-second samples per variant after 15 seconds in gameplay, using the present log. The renderer binaries are from main at
89c3d21and the branch atd05f599. The final commite1ceac6changes only a test.89c3d21d05f599d05f599Individual sample summaries from the present log
Risks
Off is the default and leaves the normal rendering path active. An enabled effect can add GPU time and use render targets. The menu and log report preparation errors when an imported preset uses unsupported FX features. Native HDR accepts bundled effects and imported effects marked for linear HDR. Expanded HDR is available for imported SDR presets. Longshot stores the selected preset as
reshade_presetinlongshot_options.iniand the selected user INI underreshade.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.The existing vendor copies are untouched. Two pinned upstream copies are added with their own provenance. Guide image source review flags pre-existing drift on
mainand one additional input,gpu/vk/menu_i18n.h, on this branch. The recorded image still needs a visual source review.When it applies
tests/that reads changed source is updated, not weakened.mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.Tested in game: Windows, RTX 5080, NVIDIA driver 617.42, Kokiri Forest start. Warm rendered before the HUD. The Italian comparison toggled the effect and browsed built-in presets and two imported INI files. Back restored the saved preset and file. Captured the same scene on main and the feature branch.
WIP: feat(reshade): add Vulkan presets and live comparisonto feat(reshade): add Vulkan presets and live comparisonHere some screenshots of the menu and the compare mode. Some preset are included, only those wich license allow us to freely distribuite them.
No regression in performance.
To use your own preset copy your .ini preset to reshade/presets, its .fx and .fxh files to reshade/shaders, and any required PNG textures to reshade/textures (keeping the subfolders referenced by the shader), then go to Graphics → Post-processing, select User, choose Rescan ReShade presets, and pick your .ini under User preset file.
Recommendation: Request changes. The design is sound and the Off path really is untouched. Four things need to change before merge. The build cost isn't measured, and every player's first build will compile the ReShade FX compiler, because it isn't in the prebuilt third-party set. Two saved menu values are fragile: appending a Clarity preset would renumber three other presets for every player, and a FROZEN key stores a list index that nothing reads back. The branch also conflicts with
main.For players this adds a Graphics → Post-processing section: 26 built-in grades (Warm, Cool, 20 Clarity looks, HDR Vibrance, two depth effects) plus their own ReShade FX presets. The effect runs inside the renderer after the gameplay upscale and before the HUD, and a compare toolbar shows it on and off in the same scene. It makes the code better as a feature. The integration is small and well placed: a few relaxed atomic loads on the hot path, everything else in
gpu/vk/reshade/and a menu module. The costs are about 25k vendored lines compiled into every renderer build, and two new parsers of player-supplied files running in the game's process.Does it help: not a perf change. For the Off path, by reading the code: its only additions are relaxed loads of
reshade::enabledinupscale_picture/finish_upscale_picture, ofneeds_tickindo_present, and ofdepth_requestedintemporal_note_scene_draw.framegen_hud_beforestill checksframes_wanted()itself, so the stub path's dropped guard changes nothing, and its call moving afterdump_ssbos/gprof_endchanges nothing either. The measured "+3.6% Off vs main" (143.96 → 149.22 fps, 2 × 30 s runs each) is run variance: nothing in the diff can make Off faster. Read it as "no cost seen". Warm costs −1.1% against Off in the same runs, which is within that noise. Heavy presets (depth, multi-pass) are not measured, which is fine for an opt-in feature.Other systems:
-O0) plus 6 of the PR's own, built intolongshot_vkon every player's build. Neither the time nor the size is measured. See Blocking 1.framegen_hud_beforecopies the picture, so FSR 3.1 FI's HUD mask and its inputs see the same graded frame. Earlier revisions were tested, the current head was not.create_image, soimage_bytescounts them.Switches: none (no
RX_/HOS_names). It adds one player-facing option,reshade_preset(default Off). That is right: this is taste, not something the team can measure and settle, like the CRT filter. Of the presets, Depth View is a debug visualisation and belongs in the Debug tab or nowhere (suggestion).Reviewed:
e1ceac60dcagainst merge-base89c3d21ea1. Read in full:gpu/vk/reshade/*(fx_runtime, fx_compile, fx_files, fx_preset, fx_texture, fx_pipeline_cache, fx_builtin, fx_clarity),gpu/vk/menu/reshade.{cpp,h}, the changes invk_draw.cpp,vk_menu.{cpp,h},vk_replay.cppandvk_temporal.{cpp,h},nx2/reshade_fx.py,nx2/build.py,nx2/make_game.py,scripts/linux/appimage.sh,scripts/reshade/check_fx.py, the docs, and every changed test. Skimmed:menu_i18n.h(the translations, for coverage only),scripts/reshade/fx_probe.cppand the example .fx/.ini. The vendoredthird_party/reshade_fxandthird_party/stb_imageI checked only for provenance, licence and the include/read paths ofeffect_preprocessor.cpp; I didn't read them in full. Nothing was run: this is a code review.Fixed in this review: nothing (the conflicts are not trivial; see Testing).
Checked and fine:
third_party/is not modified" holds. The two new parts are unmodified upstream copies withPROVENANCE.mdandtree-sha256. The one adaptation, the include resolver and file reader, is applied at build time bynx2/reshade_fx.py, outside the folder, and it fails loudly if upstream's text moves. CI's "Third-party parts / The same as upstream" will confirm the hashes; it is blocked on approval right now.make_game'slicenses/(test_appimage_licenses.pyupdated). Windows ships all ofthird_party/throughbuilder_package.py. Cemu graphic packs at496df203is CC0 1.0 (I checked its LICENSE.md). The Clarity entries are names and numeric settings, and the shader is Longshot's own..ini,.fx/.fxh, PNG andselected.txtare all read throughread_fx_file/fx_asset. Those takefs::canonical(symlinks resolved), refuse.., root paths and drive names, and keep the file inside its folder. Macro-expanded#includegoes throughresolve_fx_include(the probe test covers it). Reads are capped at 2 MB (16 MB for PNG), PNG decoding is PNG-only at up to 4096², and there are limits on techniques (32), passes (64), textures (24 / 128 MB) and uniforms (16 KB, numeric only). A failure gives a message and leaves the scene untouched.vk_retirement_value()and freed once the timeline passes it. PNG staging buffers are freed after their upload completes. A Program prepared for a stale revision is dropped before the GPU ever sees it.last_frame/last_value). The pointer is checked againsttexture_destroy_generation(), and its size, aspect, sample count and usage are checked before a depth-only view is made.mu, and nothing takes them in the other order.extern_guarded_*for modules and pipelines.bound().reset()follows the pass, so the draw path rebinds.gpu/vk/menu/reshade.cppunderMENU_MODULE, renderer code under#ifndef MENU_LAYOUT_ONLYwithMENU_HOOK, new keys in FROZEN, the settings table,test_menu_sectionsandtest_menu_modulesupdated, and every new text translated in all 14 tables.scripts/ornx2/downloads.check_fx.pycompiles the probe into a temporary folder and runs it on generated fixtures.Blocking (to change before merge)
nx2/reshade_fx.py:18, build time and size. The FX compiler's 7 vendored TUs build in every player's renderer build, and they are not in the prebuilt third-party set:nx2/third_party_objects.pySOURCEShas nothird_party/reshade_fx/, the generated preprocessor lives ingen_dir, and the jobs' headers don't end withtp_deps, sois_third_partynever marks them. Every player's first build, and every build after the object cache is emptied, pays for them. standards.md asks for the build time and size from a clean build for a build change. Please measure a clean renderer build and thelongshot_vksize onmainand here (Windows and Linux), and put the vendored TUs into the prebuilt set (add the folder toSOURCESand mark the jobs, keeping the adapted preprocessor's key stable). A lazy alternative would work too, if there is one.gpu/vk/reshade/fx_clarity.h:14/fx_builtin.h:11, stored preset numbers.reshade_presetis saved as the choice's index. The comment says "Append new entries", buthdr_preset,depth_view_presetanddepth_haze_presetare numbered after the Clarity block. The first Clarity preset someone appends will turn every player's saved HDR Vibrance into Depth View, and Depth Haze into whatever comes next. Put the non-Clarity built-ins before the Clarity block, so that appending is safe and the comment is true, or save the preset by name.gpu/vk/menu/reshade.cpp:218,reshade_user_pickshould not be a saved key. It saves an index into a list sorted by file name, while the real selection lives inreshade/selected.txt. Nothing reads the saved index back in a way that means anything:user_namesis empty until Rescan, so after a restart the row says "Choose a preset" while a user preset is active. Once it is in FROZEN, the key can never go. Drop the key and its FROZEN line, and filluser_nameswhen the menu opens with User selected (or when the row is shown). The row then showsuser_selection().main. The forge says the branch is not mergeable.mainhas moved the same parts ofvk_draw.cpp(upscale_picture, the end ofdispatch),vk_menu.cpp(menu_tick),vk_replay.cpp,vk_temporal.cpp,nx2/build.py,menu_i18n.h,docs/user/graphics-and-controls.mdand five menu tests. After the rebase, measure Off againstmainagain and re-run the game, because the hook sits in codemainchanged.Suggestions (the author may take or leave)
fx_runtime.cpp:421: each pass makes its own samplers withvkCreateSampler, up to 16 × 64 per Program, outsidesampler_room's count. The architecture rule is that samplers stay undermaxSamplerAllocationCount. Share one sampler per distinct create info, or at least count them against the room.fx_runtime.cpp:859: retired Programs are destroyed intick()on the render thread, during the present. On NVIDIA's Windows driver avmaDestroyImagecosts a millisecond or more, and browsing presets in the compare view will hitch. Hand the images todestroy_image_later.fx_pipeline_cache.cpp:29: the architecture rule is that pipeline caches are read and written through file mappings, never through a cache-sized buffer. This one reads up to 16 MB into a vector. Reuse the main cache's mapped reader, or say why this one differs.fx_builtin.h:97: Depth View is a debug view (depth to the power of 20, in grey), not a look a player picks. Move it to the Debug tab or drop it.reshade.cpp:211: the row's help explains HDR compatibility, not what the row does. Lead with "Applies a ReShade grade to the game before the HUD", then the HDR note.vk_menu.h:140: the comment "0 Off, 1 Warm, 2 Cool, 3 user preset" is out of date; there are 27 choices now. Point it atfx_builtin.h.vk_menu.cpp: the compare overlay takes overdraw_menu/menu_tickwithreshade_menu::calls. It would sit better as a module-owned overlay hook inmenu_module.hthan as feature code invk_menu.cpp, though it is small.Questions
upscale_picturematch more than one dispatch in a frame (a multi-pass gameplay network, a stand-in plus the network's last pass)? For the HUD copy that was harmless. A grade applied twice compounds. The same applies to two pictures of different sizes in one frame:s.attemptedwould then re-prepare back and forth.preparestill running on itsstd::asyncthread when the device is destroyed keeps creating objects. Is that reached, and does anything join it?Testing: the author ran the head's renderer (
d05f599;e1ceac6only changes a test) on Windows with an RTX 5080 and driver 617.42: Warm, the compare view, imported INIs, screenshots, and Off/Warm againstmainwith 2 runs each. Earlier revisions also ran HDR, depth and frame generation. Still to run: Linux on NVIDIA and RADV, the Steam Deck, the Tier 1 AMD cards on Windows, the HDR and FG combinations on the current head, and the packaged licences. CI is blocked on approval for this fork. These hold the merge (Tier 1 AMD especially), but they come after the blocking changes and a rebase.Overlaps and merge order: I found these by area, because the forge timed out on the file lists:
upscale_stub/stub_picturepath this hooks.retiredlist could live.None is a duplicate. Whichever of these merges first, the other rebases on it. Re-check the hook after #2043 or #1552.
@ -0,0 +215,4 @@.help = "Preview presets. Back restores your saved selection.",.kind = menu::Kind::Action,.on_activate = MENU_HOOK(start_comparison)}).row({.key = "reshade_user_pick", .label = "User preset file",Blocking: this saves an index into a sorted file list, while the real selection is
reshade/selected.txt. After a restartuser_namesis empty until Rescan, so the row shows "Choose a preset" with a user preset active. Drop the key (and its FROZEN line), and fill the list when the row is shown.@ -0,0 +94,4 @@})FX";inline constexpr const char* depth_fx = R"FX(Suggestion: Depth View is a debug visualisation rather than a look; the Debug tab, or drop it.
@ -0,0 +11,4 @@// SDR adaptations of the Clarity GFX presets by Jamie, Kiri, Crementif and the preset authors.// Background, license and the upstream revision are recorded in docs/user/reshade-presets.md.// The order is part of reshade_preset in longshot_options.ini. Append new entries.Blocking:
reshade_presetis saved as an index, and HDR Vibrance and Depth View/Haze are numbered after this block (fx_builtin.h:11). Appending here renumbers them for every player. Put the other built-ins before the Clarity block, or save by name.@ -0,0 +26,4 @@if (!root.empty()) path_ = root / "cache" / "reshade_vulkan.bin";std::vector<char> bytes;if (!path_.empty()) {std::ifstream file(path_, std::ios::binary | std::ios::ate);Suggestion: the architecture rule is that pipeline caches are read and written through file mappings, never through a cache-sized buffer.
@ -0,0 +418,4 @@si.addressModeU = address(s.address_u);si.addressModeV = address(s.address_v);si.addressModeW = address(s.address_w);VkSampler sampler{};Suggestion: per-pass
vkCreateSampler(up to 16 × 64 per Program) sits outsidesampler_room's count. The rule is that samplers stay undermaxSamplerAllocationCount. Share one per create info, or count them.@ -0,0 +856,4 @@}if (!s.retired.empty() || (s.active && s.active->uploaded_at)) {const auto completed = vk_timeline_completed();std::erase_if(s.retired, [completed](const auto& retired) { return retired.first && retired.first <= completed; });Suggestion: retired Programs are destroyed here on the render thread at present.
vmaDestroyImagecosts a millisecond or more on NVIDIA Windows, so browsing presets will hitch. Usedestroy_image_later.@ -0,0 +876,4 @@std::lock_guard lock(s.mutex);if (!s.request.preset) return false;const auto key = std::pair{s.request.revision, scene};if (!s.work.valid() && (!s.attempted || *s.attempted != key)) {Question: can more than one dispatch per frame reach here (a multi-pass network, two pictures of different sizes)? A grade applied twice compounds, and two sizes would make
attemptedre-prepare back and forth.@ -137,6 +137,7 @@ struct Options {int mic = 1; // (longshot) the ocarina's microphone: 0 Off, 1 the system's default, 2.. a device as host->mic_name lists it (host/nn_audio_in.c)int microphone_gain = 100; // software capture gain, 0..400%; leaves the system's input volume aloneint skip_title = 0; // (longshot) start with the most recent save, pressing through the title and its file list (host/oot_autoload.c); read at the startint reshade = 0; // 0 Off, 1 Warm, 2 Cool, 3 user preset (stored by filename)Nit: out of date; there are 27 choices now (see
fx_builtin.h).@ -0,0 +15,4 @@adapted = write_preprocessor(upstream, generated / "reshade_preprocessor.cpp")flags = vendor_flags + include + ["-fno-char8_t"] + (["-include", "share.h"] if windows else [])jobs = []for name in ("codegen_spirv", "expression", "lexer", "parser_exp", "parser_stmt", "preprocessor", "symbol_table"):Blocking: these 7 vendored TUs build in every player's renderer build and aren't in the prebuilt third-party set (
third_party_objects.SOURCEShas nothird_party/reshade_fx/, and these jobs' headers don't end withtp_deps). Please measure a clean build's time andlongshot_vksize on main and here, and add them to the prebuilt set.e1ceac60dc616ebdbdb9Resolved at
616ebdbdb9: the rebase and the three fixes are pushed (see the next review).Recommendation: Wait (on a game run of the rebased head). The four blocking points of my last review are fixed and pushed. The code is ready; what's missing is a run of this head in the game: Off and one preset, and the compare view.
Pushed to
codex/reshade-presets: old heade1ceac60dcc2, new head616ebdbdb9fd. Your ten commits are kept one by one, rebased from89c3d21ontomainatf836ca1d, and four commits are added on top:vk_draw.cpp:main'sroute_network_drawn(the FPS footer's upscale route) is kept besidefinish_upscale_picture. The route is published whereframegen_hud_beforeused to be, and the ReShade pass and the HUD copy still run aftergprof_end, as in your commit.main's new Accessibility section (Colour vision correction,after("hdr")) now comes before Post-processing (before("detail")).test_menu_modules.py,test_menu_sections.pyand the settings table say so.menu_i18n.h:maindropped "R stick press" and reworded the controller-icons line; your new strings are kept.build(reshade): the FX compiler's six upstream objects now end their dependencies with the third-party stamp, andthird_party/reshade_fx/is inthird_party_objects.py'sSOURCES, so the release's prebuilt set holds them. The adapted preprocessor is generated in the work folder, so it is still compiled locally. Build cost measured (a renderer-only clean build on Linux, 24 threads, through the job queue, nothing prebuilt): 56 s wall and 280 s of compiler time. Of that, the seven upstream files take ~10 s and the PR's ownfx_*.cppplusmenu/reshade.cpp~10 s, about 7 % of the renderer. With the set, a player compiles ~12 s of it.fix(reshade): the presets have fixed numbers. HDR Vibrance is 4, Depth View 5 and Depth Haze 6, and the Clarity looks are the last block, from 7, so a look appended toclarity_presetsmoves no savedreshade_preset. Astatic_assertkeeps the block last. The menu lists them in that order.fix(reshade): the User preset file row reads its list, and goes toreshade/selected.txt's file, the first time it is shown, so after a restart it no longer says "Choose a preset" until a Rescan. Thereshade_user_pickkey stays: it's the row's name, asoutput_deviceis the audio picker's. Its saved number is read over fromselected.txt. Leaving it out ofsave()would mean stubbing a new global in the ~17 fixtures that compilevk_menu.cpp's save code, so I leftsave()alone.docs(reshade):opts.reshade's comment names every number.Checked: the rebased renderer compiles and links with 0 failures, and
dev.py vkchecked its exports. No tests or game were run on my side: CI should run the checks, and the fork's workflow run is waiting for a maintainer to approve it.Still open:
dispatchmoved besidemain's route publishing.sampler_room, retiring Programs off the render thread, the cache file mapping, Depth View to Debug) are still yours to take or leave; none blocks.🤖 Generated with Claude Code