fix(build): keep legacy game icons out of the Windows link #1697
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1697
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Longshot:fix-windows-cached-game-icon"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Windows 11, llvm-mingw resource link-and-load smoke · Needs: packaged Windows game launch
TL;DR
A standalone Windows rebuild can fail when it reuses a game resource made before #1680. Longshot now strips the old icon from the resource it links and retains the title metadata. The original cached file is preserved.
Breakdown
Why
The Windows standalone linker can pick up an existing
longshot_game.resthat contains an icon and version strings. Since #1680,longshot_brand.resalso supplies icon IDs, so the linker rejects the duplicates. See #1680.How to reproduce
Seen on: Windows 11 with the official builder's llvm-mingw.
Settings and switches: Reuse a work folder with the pre-#1680 combined game resource.
Steps: Link an executable with the Windows standalone build's selected resources.
Expected: The executable links and shows Longshot's icon.
Actual:
ld.lldfails on duplicate ICON records.What changed
Measurements
Verdict: Restores the link on the legacy-cache path. Runtime performance measurement does not apply to executable resources.
Testing
Tested: Windows game-free regression and a Windows executable link-and-load smoke with the official builder's llvm-mingw. The smoke used the production resource selector and both icon and version information.
Not tested: Packaged game launch and full test suite.
Must be tested: Run a Windows standalone rebuild with a legacy combined cache and launch the resulting game. Verify the window and taskbar icon.
Risks
The filter runs during the link only when the brand icon is present. Clean, title-only resources use their existing path. Roll back by reverting the fix.
Checklist
WIP: fix(build): keep legacy game icons out of the Windows linkto fix(build): keep legacy game icons out of the Windows link