fix(vk): the blend check of #1631 reads dynamic_state's program, so the renderer compiles again #1659
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1659
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/equal-margin-compile"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux (Ryzen 9 7900X, RTX 3090), the renderer compiled and linked · Needs: nothing more
TL;DR
mainhas not compiled the Vulkan back end since #1631: its blend check namescur_program, whichdynamic_statedoesn't have. Every release run since stops in the AppImage job (vk_draw.cpp:5438: use of undeclared identifier 'cur_program'), so there is no nightly and no release. The program isdynamic_state's parameterp; this reads it.Breakdown
(!cur_program || target_write_mask(*cur_program, s, i))refers to a variable that is not in scope indynamic_state(it compiled on its branch, not after merging).target_write_mask(p, s, i), the programdynamic_stateis given.pis a reference, so the null check goes.dev_build.py vk, 214 files, 0 failed).Why
Release run 38286 (the v3.0.0 tag on
a7621bd7) failed in its appimage job:mainat10de79fbhas the same line.What changed
gpu/vk/vk_draw.cppdynamic_state: the blend check readstarget_write_mask(p, s, i).Measurements
Nothing to measure: a compile fix, the same behaviour #1631 describes.
Testing
Tested: Linux, the Vulkan back end built from this branch with the build tools of tools.lock (
python -I scripts/dev_build.py vk): compiled in 170 s, 0 failed,longshot_vk.solinked and its symbols checked.Not tested: a run in the game and
tests/run_all.py: no game runs or tests on this PC;tests/test_equal_depth_margin.pyreads this function and is left to CI. Opened without a game run at the maintainer's request, to unblock the nightlies.Must be tested: Intel, Death Mountain Trail's entrance: no khaki veil and no holes in the ground (#1631's own check), on the next nightly.
Risks
What could break: nothing beyond #1631's own change; this makes it compile.
Turning it off:
RX_VK_EQ_BIAS=0, as before.Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code