fix(release): a read the forge cuts off or fails with a 5xx is made again, as in the launcher's copy #1547
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1547
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/release-read-retry"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux (CachyOS, kernel 7.3.3), Python 3.12.16, no GPU needed:
tests/test_release.py(three new tests) andtests/run_all.py· Needs: noneTL;DR
The Longshot Launcher's v1.0.0-rc.11 stopped at its very last step, with every file built and signed: the forge cut off its list of releases halfway, and the release script gave up. This PR has the script ask again, up to four times, whenever a read from the forge breaks or the forge answers with a server error. A new test cuts the list off on purpose: it fails without the change and passes with it.
Breakdown
tests/run_all.pypass.Why
The launcher's v1.0.0-rc.11 run (LongshotLauncher's run 634), step Publish, ended:
The same evening a CI runner logged connection resets against git.magicbean.dev, and a long issue listing broke off the same way. This file is the same in both repositories (docs/releases.md), so the fix goes to both: LongshotLauncher#197.
How to reproduce
Seen on: CI's Sign and publish, Ubuntu runner, LongshotLauncher v1.0.0-rc.11
Settings and switches: defaults
Steps:
release.py publishwhile the forge cuts an answer off (tests/test_release.py'stest_a_list_of_releases_cut_off_is_asked_againdoes that on purpose)Expected: the list is asked for again and the release is published
Actual:
IncompleteRead, and the run ends with no releaseWhat changed
api()makes a GET again when it fails for the server's reasons. The launcher's copy's two small differences come with it, so the two repositories' files are the same again.scripts/release.py:api()makes a GET again,READ_TRIES(4) times in all, afterREAD_PAUSE(5 s) × the attempt; one request isapi_once().http.client.HTTPException(an answer cut off) counts as server trouble, forupload_file()'s retries too. From the launcher's copy:.nxamong the files never released (LongshotLauncher#77), andnightly-news's docstring without a nightly name.tests/test_release.py:FakeForgejo.read_troublecuts a GET off or answers it with a code. New tests: cut off then 502, published whole; cut off every time, nothing made; a POST answered 500 is not sent again byapi().Measurements
Nothing to measure: a release script, checked by its tests.
Flags and settings
None
Testing
Tested: on Linux,
python -I tests/test_release.pypasses (OK), and the cut-off test fails with the retry taken out.python -I -B tests/run_all.pyin a fresh clone (no build, no Vulkan or SPIR-V headers): 627 passed, 40 failed, 103 skipped. 39 of the 40 fail onmain(ef6038ab) in the same clone too: C++ and game tests that need a build or headers this clone doesn't have. The 40th,tests/test_compute_warm_apart.py, passes alone on this branch three times out of three (in the full run, clang stopped on an unused variable in its generated C++); it reads nothing ofrelease.py.The 40 failures, also failing on main
tests/test_bug_report.pytests/test_bug_report_defaults.pytests/test_compute_warm_apart.pytests/test_cpu_report.pytests/test_crash_groups.pytests/test_crt_options.pytests/test_damage_debug_menu.pytests/test_dev_packs.pytests/test_discover.pytests/test_display_startup_failure.pytests/test_dlss_feature_size.pytests/test_failed_compile_keeps_objects.pytests/test_guest_imported.pytests/test_hardware_report.pytests/test_hud_layout_row.pytests/test_invalidate_quick.pytests/test_invalidate_vcore.pytests/test_libc_hooks.pytests/test_lift_lookups.pytests/test_linux_preflight.pytests/test_linux_pressure.pytests/test_linux_update.pytests/test_log_open_failure.pytests/test_mirror_budget.pytests/test_missing_nup.pytests/test_mods_size_table.pytests/test_pending_guest_import.pytests/test_pipeline_play_cache.pytests/test_present_thread.pytests/test_profiling_mode.pytests/test_psychov35_fsr3_fg.pytests/test_readback_timeout_source.pytests/test_run_all_changed.pytests/test_slow_frames.pytests/test_switch_table.pytests/test_target_image_pool.pytests/test_upscaler_rows.pytests/test_vcore_escape.pytests/test_walk.pytests/test_walk_key.pyNot tested: a real publish against git.magicbean.dev: the next nightly after the merge is the first.
Must be tested:
Risks
What could break: a publish that keeps failing takes longer to fail (5 + 10 + 15 s per read).
Turning it off: revert the commit
Compatibility: Nothing changes
Issues
See LongshotLauncher#197
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.🤖 Generated with Claude Code