feat(testing): show test context and Dev metrics in agent runs #1539
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1539
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Longshot:codex/agent-test-hud"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Contributors can start a gameplay test from a disposable copy of the selected checkpoint. The window and screenshots show the build version, public agent identifier, short test label, CPU and GPU at top center. Dev FPS and performance metrics stay at bottom left during the test.
The contributor launcher lives in
scripts/longshot_ctl.pyandscripts/longshot_bridge.py. The renderer draws the same test information on the live window and capture targets. Control-bridge captures preserve clean comparison pixels from the same present. The merged Beanstalk runner sends the labels, drives a copied checkpoint into play and reads the clean comparison image.The rebase retains the current presenter and moves the launch guide to
docs/dev/reference/control-bridge.md. A periodic test capture can move to the next eligible frame when the presenter has the UI lock. Frame generation can then continue while the display releases a busy frame set.Testing
Tested: The initial rebase passed nine focused Windows fixtures covering the launcher, title auto-continue, screenshot allocation, overlay order, frame pacing and bug-report capture.
test_bug_report_defaults.pyfailed the sameauto-profilecase on the PR and exact main89c3d21e, where the fixture expects an Auto-controlledshadow_resentry.The lock regression check failed as intended on test-only
0cd0a04c. Onb324a3cb, the capture resources, overlay order, frame pacing and offscreen UI recording checks passed. Independent source review verified both exact Graphify maps and followed the replay and presenter calls through frame-set release and submission.On exact
b324a3cb, Windows 11 with an RTX 4070 and NVIDIA 621.01 loaded the disposable Kokiri checkpoint in a live window and offscreen. Both runs displayed the test HUD in their bridge screenshots and provided a clean same-present companion. The live client displayed the same banner and Dev metrics. Expanded HDR10 with built-in 2× frame generation stayed responsive during a camera pan. Both overlays appeared in a generated-frame capture and the game log confirmed the HDR10 swapchain and made-frame output. The stock and candidate ordinary-launch controls each produced a single clean PNG. All five sessions exited 0 through the bridge.Still to test:
save:kokiri-startscenario with clean exit. Verify the annotated and clean same-present captures locally and that the comparison uses the clean PNG. Test Farm after approval of the exact rebased head.Measurements
Verdict: The game-free lock check reproduced the blocking wait before the fix and passes afterwards. A matched timing run is still needed for release review.
HOS_TEST_AUTOLOADdefaults off and is enabled by the disposable contributor launch.RX_VK_TEST_AGENTis unset by default. It enables the test HUD when provided.RX_VK_TEST_LABELdefaults toGameplay test.Risks
The opt-in test capture adds an overlay draw and, for bridge captures, a second readback and PNG. Timing coverage is still open. Periodic test captures wait for the next opportunity if the display is busy. Regular launches keep the existing settings and screenshot path.
Screenshots
These bridge captures show the same disposable Kokiri checkpoint and camera, with SDR and frame generation off. The second is from the exact rebased windowed agent session.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.mainand here, for a change that shows on screen.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.Tested in game: Windows 11, NVIDIA RTX 4070, driver 621.01. The pre-rebase feature build loaded the disposable Kokiri Forest checkpoint in a visible window and offscreen. Both modes produced the test HUD and clean same-frame capture, then exited normally. Seven focused checks passed after rebasing.
mooki referenced this pull request2026-11-19 02:05:59 +00:00
mooki referenced this pull request2026-11-19 02:34:02 +00:00
c90d8f844ab324a3cb4dNew commits pushed, approval review dismissed automatically according to repository settings
feat(testing): show test context and Dev metrics in agent runsto WIP: feat(testing): show test context and Dev metrics in agent runsThese SDR captures use the same disposable Kokiri checkpoint and camera. The second capture came from the rebased Windows agent session. I also verified both overlays in its live game window.
Rebased onto
89c3d21eatb324a3cband fixed the test screenshot lock order found in independent review. On the RTX 4070, the disposable launch reached play with its HUD in the live window and offscreen capture. Expanded HDR10 with built-in 2x frame generation also produced an annotated generated frame. Ordinary-launch controls kept a single clean screenshot. The exact-head before/after pair is in the description. This remains WIP for timing and the remaining platform and CI checks.@rebase
I rebased this pull request onto
main(51f5f9da56): the new head is5ce271b73e.Conflicts resolved:
Nothing was built or run: read the resolution before merging.
Automated rebase by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
b324a3cb4d5ce271b73eRecommendation: Request changes. The test HUD adds continuous Dev-metric collection and rendering, but its effect on the gameplay measurements it is meant to support has not been measured. The capture path also adds readback and PNG work whose cost is unknown.
Disposable agent runs now copy a selected checkpoint, enter play, display test context and Dev metrics, and produce annotated bridge screenshots with clean companions. The feature has been demonstrated on Windows, but its timing cost and behavior on other required hardware remain unverified.
Does it help: Unproven. The reported Windows runs show the feature working on an RTX 4070 at an earlier head, but there are no matched timing or capture-cost numbers against the base. The latest rebase was not run.
Other systems: The change affects windowed and headless rendering, bridge and periodic captures, frame generation, HDR, and title auto-continue. An earlier head was exercised on Windows NVIDIA, including HDR10 and generated frames; Linux RADV, Steam Deck, alternate GPU presentation, and the rebased head remain untested.
Switches: HOS_TEST_AUTOLOAD defaults off; RX_VK_TEST_AGENT defaults unset and enables the HUD; RX_VK_TEST_LABEL defaults to Gameplay test. They are documented in switches.def and used by the disposable launcher. Their opt-in defaults limit ordinary-launch exposure, but the cost of the enabled configuration is unmeasured.
Reviewed:
5ce271b73eagainst51f5f9da56: Read the repository rules, contribution guide, PR template, standards, relevant control-bridge and architecture sections, commits, and changed renderer and launcher excerpts. Skimmed the test changes and recorded runs. The full changed code files and all dependent paths were not read; Tooling's adjacent AGENTS.md and docs/review-checklist.md were absent. Network access and overlapping PRs were unavailable.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No builds, tests, scripts, or game runs were executed, as requested. The author's Windows evidence is for
b324a3cb; the subsequent rebase to5ce271b73ereports no runs.Overlaps and merge order: Unknown; the network is closed.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its rebase. Nothing was run; a maintainer decides.
@ -3130,0 +3144,4 @@return agent;}static int effective_fps_level() {Please measure warmed, matched runs with the test HUD off and on, including frame times and 1% lows. For small performance comparisons, continuous Dev metrics and overlay rendering could change the result being measured.
@ -5042,1 +5095,3 @@shot_asked.on = true, shot_asked.value = value, shot_asked.present = presents, shot_asked.ask = std::move(a);const bool annotated = a.test_hud && annotate_test_shot(cmd, ask_image);if (annotated) {c.bufferOffset = (VkDeviceSize)kShotW * kShotH * 4;Please measure the readback and PNG cost at the intended capture cadence, including its effect on frame pacing. Frequent bridge captures could disturb the gameplay test they observe.
@fix
I didn't fix this pull request: it needs the author: Both points require measurements that cannot be obtained under the instruction not to run builds, tests, scripts, or the game. Whether either cost is material, and therefore needs a code change, remains for the author to determine. Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@fix
I didn't change this pull request: what the review asks needs the author.
Left for the author
Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@fix
I didn't change this pull request: what the review asks needs the author.
Left for the author
5ce271b73eto verify the rebase resolution, including colour-vision correction and screenshots. This requires a build and game run, which are prohibited here.Nothing was pushed.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
@fix
I changed this pull request by bringing it up to date: the new head is
6845d91d62. I rebased it ontomain(3df5c13ed2).Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
5ce271b73e6845d91d62Recommendation: Request changes. Disposable tests can fail to enter play on Windows when their run folder has a non-ASCII path. The previously identified HUD and capture costs also remain unmeasured.
The change adds disposable checkpoint launches, a test-context HUD and clean companion images for bridge captures. It makes test context easier to see, but the Windows path failure blocks some contributors and the cost of collecting and capturing metrics remains unknown. Since the previous review, the branch was rebased onto
3df5c13ed2; no runs of the resulting head are reported. The previous review’s requests for matched HUD and capture measurements remain outstanding.Does it help: Unproven. The author reports successful visible and offscreen gameplay, clean companion captures, HDR10 and generated-frame captures on Windows 11 with an RTX 4070 at
b324a3cb. There are no matched HUD-on/off or capture-cost numbers, and the current head has not been run.Other systems: The changed paths cover windowed and offscreen rendering, periodic and bridge screenshots, frame generation, HDR, colour-vision correction and title auto-continue. Earlier Windows NVIDIA runs provide partial evidence; Linux RADV or Steam Deck, alternate GPU presentation, current-head conflict resolution and required Tier 1 coverage remain open.
Switches: HOS_TEST_AUTOLOAD defaults off and is enabled for agent launches; RX_VK_TEST_AGENT defaults unset and enables the HUD; RX_VK_TEST_LABEL defaults to Gameplay test. All have switch-table rows. Their opt-in defaults limit ordinary-launch exposure, but the enabled configuration’s cost is unmeasured.
Reviewed:
6845d91d62against3df5c13ed2: Read the base AGENTS.md, CONTRIBUTING.md and PR template; reviewed the complete diff, commits, changed host autoload file, launcher session setup and selected renderer callers and locking paths. Skimmed the test changes, recorded runs, standards and relevant architecture sections. The full changed renderer, launcher and test files and all dependent paths were not read. Tooling’s adjacent AGENTS.md and docs/review-checklist.md were absent.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No builds, tests, scripts or game runs were executed. The author’s reported gameplay evidence is for an earlier head.
Overlaps and merge order: Unknown; network access is closed. The PR says Beanstalk runner #89 is merged.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -185,3 +191,3 @@if (!rx_option(HOS_OPT_SKIP_TITLE, 0)) return;if (!test_autoload && !rx_option(HOS_OPT_SKIP_TITLE, 0)) return;if (!hos_oot_newest_save(hos_user_dir, save_path, sizeof save_path)) {hos_log("skip title: no saved game yet: the title screen stays");This now makes agent launches depend on the Windows save search, which uses narrow FindFirstFileA/stat calls on UTF-8 paths. A run folder containing characters outside the active code page can leave the checkpoint undiscovered and launch waiting for play. Could the search use UTF-8-aware Windows filesystem calls, with a non-ASCII path test?
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
30fc1bf23d. It was already up to date withmain.Changed
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. The Windows save-search fix still fails for valid paths whose UTF-8 representation exceeds its byte buffers. The previously identified HUD and capture costs also remain unmeasured.
Disposable test launches copy a checkpoint, enter play, display test context and Dev metrics, and produce annotated bridge captures with clean companions. Since the last review, wide Windows filesystem calls and a Unicode-path fixture were added, but the fix does not cover longer valid UTF-8 paths. The feature is useful for contributors; its measurement overhead remains an open cost.
Does it help: Unproven. The author reports successful windowed and offscreen runs, clean companion captures, HDR10 and generated frames on Windows 11 with an RTX 4070 at
b324a3cb. There are no matched HUD-on/off or capture-cost numbers, and no runs are reported for head30fc1bf.Other systems: The change affects Windows and Linux, windowed and offscreen presentation, bridge and periodic captures, frame generation, HDR, colour-vision correction and title auto-continue. Earlier Windows NVIDIA runs provide partial evidence; Linux RADV or Steam Deck, alternate GPU presentation, Tier 1 coverage and the current head remain unverified.
Switches: HOS_TEST_AUTOLOAD defaults off and is enabled by agent launches. RX_VK_TEST_AGENT defaults unset and enables the HUD; RX_VK_TEST_LABEL defaults to Gameplay test. All have switch-table rows. Ordinary launches remain opt-in, but the cost of the enabled configuration has not been measured.
Reviewed:
30fc1bf23dagainst3df5c13ed2: Read the base AGENTS.md, CONTRIBUTING.md, PR template, standards, complete diff, commit list and host/oot_autoload.c. Reviewed the changed launcher setup and selected renderer capture, UI and locking paths; skimmed changed tests, documentation and reported runs. The full changed renderer, launcher and test files and all dependent paths were not read. The adjacent Tooling AGENTS.md and docs/review-checklist.md were absent.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: No builds, tests, scripts or game runs were executed. The reported gameplay evidence is from an earlier head.
Overlaps and merge order: Unknown; the network is closed. The description says Beanstalk runner #89 is merged.
Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -96,3 +117,2 @@path_part(pattern, sizeof pattern, SEP_S "save" SEP_S "*");WIN32_FIND_DATAA fd;HANDLE h = FindFirstFileA(pattern, &fd);WIN32_FIND_DATAW fd;The wide call still receives a path built in a 260-byte UTF-8 buffer. A valid Windows path with multibyte characters can fit in 260 wide characters while its UTF-8 bytes plus the save suffix exceed this buffer, so the copied checkpoint is not found and launch times out. Please size these paths for UTF-8 bytes or build them dynamically, and cover that case in the Windows fixture.
WIP: feat(testing): show test context and Dev metrics in agent runsto feat(testing): show test context and Dev metrics in agent runs@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
8abda60d40.Changed
Already done
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. The rebased UI fixture cannot compile, and an annotated capture can overwrite an existing file the caller never selected. Disposable launches also still fail to find valid checkpoints in sufficiently deep Linux run folders.
Contributors can launch a copied checkpoint, see the run context and Dev metrics, and collect an annotated screenshot with a clean image for comparison. The launcher reuses the existing test profile and title-skip logic. Since the last review, the Windows save search gained larger UTF-8 buffers, extended-length path handling, and fixtures for both long-path cases. The HUD and capture add work to the gameplay being measured.
Does it help: Unproven on this head. The author reports five successful Windows sessions on an RTX 4070 at
b324a3cb, covering windowed and offscreen play, clean companions, HDR10 with 2× frame generation, and ordinary-launch controls. The earlier lock check reportedly failed before the fix and passed afterward. There are no matched, warmed, interleaved measurements against3df5c13ed2for FPS, 1% lows, frame times, readback, PNG time, or memory.Other systems: Ordinary screenshots and bug reports still request clean pixels. The live window retains the colour-vision argument through UI recording. Agent mode affects title input, disables the audio device, and changes windowed, headless, HDR, generated-frame, and periodic captures. Periodic glitch detection now receives annotated pixels in agent mode, which can change its black-pixel and flash results. Current-head Linux RADV, Steam Deck, AMD Windows, Linux NVIDIA, and alternate presentation coverage remain open.
Switches:
HOS_TEST_AUTOLOADdefaults off and1enables title auto-continue.RX_VK_TEST_AGENTdefaults unset and enables the HUD and forced Dev metrics when set.RX_VK_TEST_LABELdefaults toGameplay test. All three have switch-table rows. The new--agentand--test-labeloptions default unset and must be paired with a selected checkpoint. Agent launches default to a window, respect--headless, and setHOS_AUDIO=0through the test profile. The opt-in defaults suit a contributor workflow. The enabled mode's timing cost is still unmeasured.Reviewed:
8abda60d40against3df5c13ed2: Reviewed8abda60d40against3df5c13ed2, the commit range, supplied comments and earlier reviews, base AGENTS.md, CONTRIBUTING.md, the Forgejo template, standards, and relevant architecture rules. Read host/oot_autoload.c and the UI recording fixture in full. Reviewed changed hunks and followed the launcher setup, bridge request, screenshot readback, presenter lock, and submission paths. Skimmed the remaining test fixtures and reported runs. Full renderer, launcher, documentation, and remaining test files were not read. The review checklist and adjacent Tooling checkout were absent. The two omitted comments, screenshot attachments, and Graphify maps were unavailable.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
tests/test_ui_record.py:67declares a six-argumentrecord_to, while the extracted production function takes seven arguments and references colour-vision types and draw-list fields absent from the fixture. The game-free UI recording check cannot compile on this head. Match the production signature, supply the colour-vision and draw-list dependencies, and exercise both window and capture recording.gpu/vk/vk_replay.cpp:5133derives a second destination from the caller's path and replaces any file at that destination. Requestingforest.pngcan silently replace an existingforest.png.scene.png, and a failed primary write can leave a newly published companion. Reserve a distinct companion destination, return it in the reply, and clean up this request's output on failure.host/oot_autoload.c:28leaves Linux save discovery limited to 260 bytes. A valid nested--rootcan produce a copiedprogress.savwhose full path exceeds 259 bytes, so discovery silently truncates it andlaunchwaits for play until timeout. Use checked path construction that supports the game filesystem's path range on Linux and add a long Linux run-folder fixture.Suggestions (the author may take or leave)
Testing: Read-only review. No builds, tests, scripts, or game runs were executed. The author named the
auto-profilefailure on both the candidate and main at the earlier rebase. The full suite and Windows path fixtures have no reported run on8abda60d40. The ready checklist remains incomplete.Overlaps and merge order: The description says Beanstalk runner #89 is merged. Other overlaps and the cause of the reported mergeability failure could not be verified from the offline checkout.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -224,3 +224,2 @@A PNG of the first present after the request (or after frame `after`), at the size `RX_VK_SHOTS` writes (1280x720, or`RX_VK_SHOT_W` x `RX_VK_SHOT_H`). It shows the game's picture without the Insert menu or FPS counter. The file iswritten under another name and renamed, so the reply's path is complete.`RX_VK_SHOT_W` x `RX_VK_SHOT_H`). A regular shot shows the game's picture. A [disposable agent test](#disposable-agent-tests)Agent bridge shots can also skip the first eligible present when the presenter holds the UI lock. Document that alongside the periodic capture deferral.
@ -5061,0 +5130,4 @@std::thread([px, a, at, bytes] {// Keep the untouched pixels from this exact frame for automated image comparisons.const bool annotated = px->size() > bytes;const bool ok = (!annotated || write_shot(a.path + ".scene.png", px->data())) &&A request for
forest.pngcan overwrite an existingforest.png.scene.png. Reserve a distinct companion path, return it to the caller, and clean it up if the primary write fails.@ -22,3 +25,4 @@#ifndef MAX_PATH#define MAX_PATH 260#endif#define SAVE_PATH_SIZE MAX_PATHA deep Linux
--rootcan put the copied checkpoint beyond this 260-byte buffer. Discovery truncates the path and launch times out waiting for play. Match the game filesystem's capacity and cover this case on Linux.@ -65,3 +65,3 @@}void vkCmdEndRendering(VkCommandBuffer) { calls += "]"; }''' + block(src, "void layout(VkCommandBuffer cmd,") + "\n" + block(src, "void record_to(VkCommandBuffer cmd,") + "\n" + block(src, "void record(VkCommandBuffer cmd,") + r'''bool record_to(VkCommandBuffer, VkImage, VkImageView, uint32_t, uint32_t, bool screenshot = false);The extracted function takes seven arguments and uses colour-vision and draw-list types missing here. Update the fixture to compile and exercise both recording paths.
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
d30aa19142.Changed
Already done
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. The changed screenshot callback still advertises the old renderer ABI, so a mixed host and renderer can pass the version check and crash on a screenshot. Companion publication also repeats a full PNG write for each occupied name and fails on Linux filesystems without hard-link support.
Contributors can launch a copied checkpoint, see the run context and Dev metrics, and collect an annotated screenshot alongside clean pixels from the same present. Since review 1932, the branch updates the UI fixture, covers deeper Linux save paths, documents capture deferral, and adds no-replace publication for companions. That protects occupied companion names during companion creation, but an explicit primary shot can still overwrite a previously returned companion.
Does it help: Unproven on
d30aa19142. The author reports five successful Windows 11 sessions on an RTX 4070 with driver 621.01 atb324a3cb, plus a lock fixture that failed on the test-only regression commit and passed onb324a3cb. The prior HUD and capture cost findings remain open. There are no warmed, interleaved timing runs against3df5c13ed2for ordinary launches, HUD-on versus HUD-off gameplay, or the intended capture cadence. Average FPS, 1% lows, frame times, readback and PNG times, and RAM and VRAM costs are missing.Other systems: The renderer ABI affects separate host and renderer builds on both platforms. Agent mode affects windowed and offscreen UI, HDR, generated frames, periodic capture and title input. The new windowed agent launch inherits the test profile’s audio disable. Ordinary screenshots and bug reports still request clean pixels, while periodic glitch detection in agent mode can see overlay pixels. Earlier Windows NVIDIA runs cover some of these paths. Exact-head colour correction, Linux RADV and Steam Deck, and the remaining Tier 1 GPU and OS coverage are open.
Switches: HOS_TEST_AUTOLOAD defaults off. RX_VK_TEST_AGENT defaults unset and enables the banner and forced Dev metrics when supplied. RX_VK_TEST_LABEL defaults to Gameplay test. All three have switch-table rows. The paired --agent and --test-label options default unset and require a checkpoint. Agent launches default to a window and honor --headless. The opt-in defaults suit contributor testing. Their enabled costs and ordinary-launch timing still need measurements.
Reviewed:
d30aa19142against3df5c13ed2: Reviewedd30aa19142against3df5c13ed2, the commits, supplied comments and reviews, base AGENTS.md, CONTRIBUTING.md, the Forgejo template, and standards. Read host/oot_autoload.c, gpu/vk/vk_imgui.h, tests/test_capture_resources.py, tests/test_fps_overlay_order.py, tests/test_png_publication.py, tests/png_publication_test.cpp and tests/capture_dimensions_test.cpp in full. Reviewed changed regions elsewhere and traced renderer loading, screenshot callbacks, readback, presenter locking and launcher setup. Skimmed reported runs and other fixture context. Full renderer, bridge, launcher and remaining test files were not read. The review checklist and adjacent Tooling checkout were absent. Omitted comments, attachment images and Graphify maps were unavailable.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: Read-only review. The diff whitespace check passed. No builds, fixtures, project scripts or game sessions were run. The reported Windows sessions and baseline auto-profile failure predate this head. Exact-head CI, the game-free suite, Tier 1 hardware results and the Graphics guide source review remain outstanding.
Overlaps and merge order: The PR reports Beanstalk #89 already merged. Other overlaps and merge order could not be verified with the network closed.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -413,2 +412,3 @@path on a thread of its own, which then calls done(ctx, present, ok, scene), with an optional clean companion path. 0: not taken(too many waiting) */int (*shot)(const char *path, int64_t after, void (*done)(void *ctx, int64_t present, int ok), void *ctx);int (*shot)(const char *path, int64_t after, void (*done)(void *ctx, int64_t present, int ok, const char *scene), void *ctx);This callback gains a fourth argument while the ABI remains at 36. A new host can accept an old renderer and dereference a missing scene pointer when a shot finishes. Bump MKWVK_API_VERSION and rebuild both binaries.
@ -4600,2 +4606,3 @@if (!ok && collision && (error == ERROR_FILE_EXISTS || error == ERROR_ALREADY_EXISTS)) *collision = true;#elseok = rename(temporary.c_str(), path) == 0;ok = collision ? link(temporary.c_str(), path) == 0 : rename(temporary.c_str(), path) == 0;A Linux shot to a writable exFAT folder can publish by rename in ordinary mode, but the annotated shot fails because exFAT has no hard links. Support no-replace publication on rename-capable filesystems without hard links.
@ -5059,2 +5167,3 @@}if (!ok) std::remove(part.c_str());const bool ok = scene_written &&write_shot(a.path, px->data() + (annotated ? bytes : 0));A later shot can use an earlier scene_path as its explicit primary and overwrite that clean companion. Reserve a namespace that primary paths cannot replace and exercise this with two bridge requests.
@ -5059,0 +5161,4 @@if (scene == a.path) continue;#endifbool collision = false;scene_written = write_png(scene.c_str(), px->data(), kShotW, kShotH, &collision);Each occupied name causes a full encode and temporary write under the publication mutex. With 100 prior 720p companions that is roughly 276 MB of failed writes for one shot. Encode once and retry publishing the completed temporary under fresh names.
@fix
I changed this pull request where the review's points could be done here (the rest needs runs, measurements or decisions): the new head is
067fd00ae4.Changed
Already done
Left for the author
Nothing was built or run: check the change. It will be reviewed again.
Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.
Recommendation: Request changes. The new Linux fallback exposes an incomplete companion PNG under its final name. The new publication lock also serializes encoding behind detached writers without bounding the number of frames they can retain.
Contributors can launch a copied checkpoint, see the build and test context beside Dev metrics, and get a clean comparison image from the same present. Since review 1936, the branch bumped the renderer ABI, stopped re-encoding on filename collisions, and added no-replace publication and companion-name protection. Those changes resolve the ABI and repeated-encoding findings. The fallback and writer backlog still need changes, and the earlier measurement requests remain open.
Does it help: Unproven on
067fd00ae4. The author reports five successful Windows 11 sessions on an RTX 4070 with driver 621.01 atb324a3cb, and a frame-generation lock fixture that failed on the regression commit and passed atb324a3cb. There are no matched, warmed, interleaved runs against3df5c13ed2showing ordinary-launch cost, HUD-on/off average FPS, 1% lows and frame times, or readback, PNG and memory costs at the intended capture cadence.Other systems: The ABI bump requires matching host and renderer builds on Windows and Linux. Earlier Windows NVIDIA evidence covers live and offscreen play, ordinary screenshots, expanded HDR10 and built-in 2× frame generation. Exact-head colour correction, Linux RADV and Steam Deck, and the remaining Tier 1 GPU and OS combinations are unverified. Agent-mode periodic captures also feed annotated pixels into the existing black-pixel and flash detectors. Bug-report screenshots still explicitly request clean pixels.
Switches: HOS_TEST_AUTOLOAD defaults off and the agent launcher sets it to 1. RX_VK_TEST_AGENT defaults unset and enables the banner and Dev metrics. RX_VK_TEST_LABEL defaults to Gameplay test. All three have switch-table rows. The paired --agent and --test-label options default unset and require a checkpoint. Agent launches open a window by default, honor --headless, and inherit HOS_AUDIO=0 and an empty HOS_ENV_FILE from the test profile. The opt-in defaults fit contributor runs. The enabled timing cost is still open.
Reviewed:
067fd00ae4against3df5c13ed2: Reviewed067fd00ae4against3df5c13ed2, the seven commits, the supplied comments and reviews, base AGENTS.md, CONTRIBUTING.md, the Forgejo template, standards, and relevant renderer architecture rules. Read host/oot_autoload.c, gpu/vk/vk_imgui.h, tests/capture_dimensions_test.cpp, tests/test_capture_dimensions.py and tests/test_png_publication.py in full. Reviewed changed regions in the remaining files and traced screenshot recording, readback, publication, callback wiring and launcher setup. Skimmed remaining fixture context and reported runs. Full renderer, launcher, bridge and remaining test files were outside the full-file coverage. The review checklist, adjacent Tooling checkout, omitted comments, screenshot attachments and Graphify maps were unavailable.; nothing run (a code review).Checked and fine:
Blocking (to change before merge)
Suggestions (the author may take or leave)
Testing: Static review only. git diff --check passed. No builds, tests, scripts or game runs were executed. The reported Windows gameplay and lock fixture results predate the current head.
Overlaps and merge order: The description says Beanstalk runner #89 is already merged. Other overlaps could not be checked offline.
Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.
@ -4594,17 +4604,62 @@ bool write_png(const char* path, const uint8_t* rgba, uint32_t w, uint32_t h) {}if (ok) {phase = "publish";for (unsigned i = 0; i < (companion ? 10000u : 1u); i++) {Every shot rescans from zero, and a directory with 10,000 companions can never accept another annotated shot. Use unique short names and keep the atomic collision check.
@ -4604,0 +4626,4 @@// Claim the name exclusively, then copy the already encoded PNG.FILE* in = fopen(temporary.c_str(), "rb");if (in) {FILE* out = fopen(candidate.c_str(), "wbx");This exposes the final companion name during the copy. A watcher can read a partial PNG, and interruption can leave it behind. Keep publication atomic and report unsupported filesystems explicitly.
@ -5056,3 +5205,1 @@if (ok) {std::remove(a.path.c_str());ok = std::rename(part.c_str(), a.path.c_str()) == 0;std::thread([px, a, at, bytes] {The request limit stops applying once this detached writer starts. Slow storage can pile up threads behind publication_mu, each retaining about 63 MiB at 4K. Bound outstanding writes and include them in admission.
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.