docs(tested): one measured run per file, as docs/tested/README.md asks #1457
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1457
Loading…
Reference in a new issue
No description provided.
Delete branch "omgitsgela/Longshot:fix/tested-one-row-per-file"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Linux, no GPU needed · Needs: none
Why
docs/tested/README.mdasks for one measured run per file, andscripts/tested_configurations.pyenforces it: it reads each file expecting the header, the separator and exactly one row. Four files carried several runs in one file, so the reader raised andtests/test_tested_configurations.pyfailed onmain. The website catalogue builds from that same reader, so it cannot list those runs either.Any pull request whose checks run that test is red through no fault of its own, including the mesh-fallback work I am posting alongside this.
What changed
No measured run's text was edited, merged or dropped. Each row moved into its own file, named with the run identifier the row already carries in its Result cell, so every run keeps a distinct name and the
YYYY-MM-DD-topic-tester-run.mdscheme holds.docs/tested/2026-11-16-dead-targets-every-present-gumminaomi-new.md(2 rows) →…-new-prdn-mkt-new-1.md,…-new-prdn-mkt-new-2.mddocs/tested/2026-11-16-dead-targets-every-present-gumminaomi-old.md(2 rows) →…-old-prdn-mkt-old-1.md,…-old-prdn-mkt-old-2.mddocs/tested/2026-11-16-shadow-map-slots-gumminaomi-off.md(6 rows) →…-off-prsl-mkt-off-1..5.md,…-off-prsl-4k-off.mddocs/tested/2026-11-16-shadow-map-slots-gumminaomi-on.md(6 rows) →…-on-prsl-mkt-on-1..5.md,…-on-prsl-4k-on.mdMeasurements
Nothing to measure: a documentation change the game never runs, so the applicable evidence is the game-free check that was failing, quoted under Testing.
Flags and settings
None.
Testing
Tested:
python -I -B tests/test_tested_configurations.pyon Linux, before and after, in a clean tree so the difference is only this change:The reader
scripts/tested_configurations.pyrenders the wholedocs/testeddirectory with no error after the change (it raised the error above before). 18 files changed: 4 removed, 16 created, 3 lines each, so the same 16 runs exist after as before, one per file.Not tested: the website catalogue build (
website/) that consumes this reader; the reader is the same code path and it renders, and no row's text changed.Must be tested: none for merge. If the catalogue's owner wants it confirmed:
npm run buildthennpm run previewinwebsite/and check the 16 renamed runs appear under their new names.Risks
What could break: only how these runs are named: anyone linking a run by its old file name finds the run under the new one. Nothing in the game, the build or the ABI.
Turning it off: revert the commit.
Compatibility: nothing changes for a player.
Issues
See #2245 — the measurement work held in the companion pull request (mesh fallback on the Steam Deck) is blocked by this check failing on
main, not by its own changes.Checklist
Everyone
type(scope): description) of the status line's type.main. Base is544229a2withmainatc14641a6:git merge --no-commitof origin/main into this branch reports 0 conflicts, so no rebase is needed (docs/agent-pull-requests.md: rebase if it conflicts; main moving past the base is not, by itself, a reason).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Possibly related, for context:
WIP: docs(tested): one measured run per file, as docs/tested/README.md asksto docs(tested): one measured run per file, as docs/tested/README.md asksThis is the fix for a check that is red on main independently of any pull request: four docs/tested files hold several runs each, so scripts/tested_configurations.py raises and tests/test_tested_configurations.py fails (Ran 25 tests, FAILED errors=1 on main @
c14641a6, OK here). Row text is byte-for-byte unchanged: each run moved to its own file named by the run identifier it already carries. Any PR touching gpu/, host/ or docs/tested is gated by this check, including #1460.Closing as superseded: main took #1378, which split the same multi-row files one row per file. On current main (
257c5491) tests/test_tested_configurations.py passes (Ran 25 tests, OK), so this branch is duplicate work. My branch's split names (-prdn-mkt-*) differ from main's (-new1/-new2); nothing here is needed.Closing as superseded by #1378, which main merged: it splits the same multi-row docs/tested files one per file, and on current main (
257c5491) tests/test_tested_configurations.py passes (Ran 25 tests, OK). This branch is duplicate work.Pull request closed