fix(build): the crash window copies log lines by a name the MSVC target links (no "undefined symbol: strdup") #1379

Merged
HumanBean merged 1 commit from GummiNaomi/Longshot:fix/crash-dialog-strdup-msvc into main 2026-11-17 15:57:11 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11, clang for the MSVC target (the emsdk's clang, a Windows SDK without oldnames.lib); the Test Farm's builds: Windows (RX 9070 XT), Linux (RADV RX 7900 XT, RTX 3080 Ti) · Needs: nothing

Why

Since #983, a Windows build for the MSVC target stops at the link, after the whole game has been translated and compiled:

link FAILED (2s), 1 undefined symbols
lld-link: error: undefined symbol: strdup

The crash window's report reads the log again and copies its lines with strdup (host/hos_crash_dialog.c, lines_add and crash_lines). The MSVC target links without oldnames.lib (issue 439: recent Windows SDKs no longer ship it), and without it the C runtime has that function only as _strdup. third_party/a64-kit/tools/toolchain.py says so where it leaves the library out: "The game and host use no legacy non-underscore name". The llvm-mingw and Linux builds have the plain name, so they kept building and nothing caught it.

How to reproduce

Seen on: Windows 11, a build for the MSVC target (LONGSHOT_MINGW not set: clang with lld-link, a Windows SDK that has no oldnames.lib); no GPU involved
Settings and switches: defaults
Steps: python -I nx2/make_game.py --nup <the dump> --out <a game folder> on main @ 8e9cfc3a, 6d72ca93 or 544229a2
Expected: the game folder is built
Actual: link FAILED (2s), 1 undefined symbols, lld-link: error: undefined symbol: strdup, after the translation and the compile

What changed

The two copies go by the name each C runtime links: _strdup on Windows, strdup elsewhere.

  • host: line_copy in host/hos_crash_dialog.c, used by lines_add and crash_lines.
  • tests: tests/test_msvc_oldnames.py reads the host's sources (host/*.c, host/*.h) for the legacy names only oldnames.lib gave (strdup, stricmp, unlink, getcwd and so on; not the ones host/msvc_oldnames.c aliases) and fails on a call the Windows build compiles: one that is not under #ifndef _WIN32, in the #else of an #ifdef _WIN32 chain, or in another system's section. Comments, strings, members (x.unlink() and names a file defines for itself are left alone. A second test checks that scan on a small made-up source.

Measurements

Nothing to measure: a link error, and the same call on the builds that linked.

Flags and settings

None.

Testing

Tested: Windows 11, the MSVC target (emsdk clang, lld-link): main @ 8e9cfc3a (and 6d72ca93) stops at undefined symbol: strdup; with this change the same builds link, as does main @ 544229a2, and the game ran the scripted market and area-change routes on them (about sixty runs of 95-105 s, for other work). tests/test_msvc_oldnames.py passes; with host/hos_crash_dialog.c put back to main's it fails and names host/hos_crash_dialog.c:1232 strdup and :1255 strdup, and nothing else in the host. tests/test_crash_dialog.py --cxx clang++ compiles and links the crash window with the change and fails later at its "quote" check here, the same as on main on this PC. python -I -B tests/run_all.py with clang here, this PR @ 65945ab4: 393 passed, 107 failed, 221 skipped; main @ 544229a2 in the same session: 392 passed, 108 failed, 221 skipped. Nothing fails here that does not fail on main (this PC's toolchain: no gcc, Windows line endings, fixtures needing tools not installed); the one more on main was tests/test_gpu_hang_watch.py in that run.

The Test Farm built this PR @ 65945ab and started the game, against main @ 544229a: on Windows (RX 9070 XT, 2.0.416) and on two Linux PCs (RX 7900 XT on RADV 26.2.6, RTX 3080 Ti on 620.70.6), the title and a new save's first area, no crash on any (the reports are linked in its comment below).

Not tested: the crash window itself after a real crash, on any build.

Must be tested: None: the two builds this asked for are done (the Test Farm, above).

Risks

What could break: nothing I can name: the same function by its other name.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Issues

None found for this (searched strdup, oldnames, undefined symbol, lld-link). #983 added the calls; issue 439 is why the name is missing.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (The Test Farm's builds on Windows and Linux; built here for the MSVC target.)

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, clang for the MSVC target (the emsdk's clang, a Windows SDK without `oldnames.lib`); the Test Farm's builds: Windows (RX 9070 XT), Linux (RADV RX 7900 XT, RTX 3080 Ti) · **Needs:** nothing ## Why Since #983, a Windows build for the MSVC target stops at the link, after the whole game has been translated and compiled: ``` link FAILED (2s), 1 undefined symbols lld-link: error: undefined symbol: strdup ``` The crash window's report reads the log again and copies its lines with `strdup` (`host/hos_crash_dialog.c`, `lines_add` and `crash_lines`). The MSVC target links without `oldnames.lib` (issue 439: recent Windows SDKs no longer ship it), and without it the C runtime has that function only as `_strdup`. `third_party/a64-kit/tools/toolchain.py` says so where it leaves the library out: "The game and host use no legacy non-underscore name". The llvm-mingw and Linux builds have the plain name, so they kept building and nothing caught it. ## How to reproduce **Seen on:** Windows 11, a build for the MSVC target (`LONGSHOT_MINGW` not set: clang with lld-link, a Windows SDK that has no `oldnames.lib`); no GPU involved **Settings and switches:** defaults **Steps:** `python -I nx2/make_game.py --nup <the dump> --out <a game folder>` on main @ 8e9cfc3a, 6d72ca93 or 544229a2 **Expected:** the game folder is built **Actual:** `link FAILED (2s), 1 undefined symbols`, `lld-link: error: undefined symbol: strdup`, after the translation and the compile ## What changed The two copies go by the name each C runtime links: `_strdup` on Windows, `strdup` elsewhere. - host: `line_copy` in `host/hos_crash_dialog.c`, used by `lines_add` and `crash_lines`. - tests: `tests/test_msvc_oldnames.py` reads the host's sources (`host/*.c`, `host/*.h`) for the legacy names only `oldnames.lib` gave (`strdup`, `stricmp`, `unlink`, `getcwd` and so on; not the ones `host/msvc_oldnames.c` aliases) and fails on a call the Windows build compiles: one that is not under `#ifndef _WIN32`, in the `#else` of an `#ifdef _WIN32` chain, or in another system's section. Comments, strings, members (`x.unlink(`) and names a file defines for itself are left alone. A second test checks that scan on a small made-up source. ## Measurements Nothing to measure: a link error, and the same call on the builds that linked. ### Flags and settings None. ## Testing **Tested:** Windows 11, the MSVC target (emsdk clang, lld-link): main @ 8e9cfc3a (and 6d72ca93) stops at `undefined symbol: strdup`; with this change the same builds link, as does main @ 544229a2, and the game ran the scripted market and area-change routes on them (about sixty runs of 95-105 s, for other work). `tests/test_msvc_oldnames.py` passes; with `host/hos_crash_dialog.c` put back to main's it fails and names `host/hos_crash_dialog.c:1232 strdup` and `:1255 strdup`, and nothing else in the host. `tests/test_crash_dialog.py --cxx clang++` compiles and links the crash window with the change and fails later at its "quote" check here, the same as on main on this PC. `python -I -B tests/run_all.py` with clang here, this PR @ 65945ab4: 393 passed, 107 failed, 221 skipped; main @ 544229a2 in the same session: 392 passed, 108 failed, 221 skipped. Nothing fails here that does not fail on main (this PC's toolchain: no gcc, Windows line endings, fixtures needing tools not installed); the one more on main was `tests/test_gpu_hang_watch.py` in that run. The Test Farm built this PR @ 65945ab and started the game, against main @ 544229a: on Windows (RX 9070 XT, 2.0.416) and on two Linux PCs (RX 7900 XT on RADV 26.2.6, RTX 3080 Ti on 620.70.6), the title and a new save's first area, no crash on any (the reports are linked in its comment below). **Not tested:** the crash window itself after a real crash, on any build. **Must be tested:** None: the two builds this asked for are done (the Test Farm, above). ## Risks **What could break:** nothing I can name: the same function by its other name. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Issues None found for this (searched `strdup`, `oldnames`, `undefined symbol`, `lld-link`). #983 added the calls; issue 439 is why the name is missing. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (The Test Farm's builds on Windows and Linux; built here for the MSVC target.) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(build): the crash window copies log lines by a name the MSVC target links (no "undefined symbol: strdup")
Some checks are pending
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 14s
CI / Workflow lint (actionlint) (pull_request) Successful in 18s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 15s
Third-party parts / As their notes say (pull_request) Successful in 20s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/any 0/1 pass, 0 running, 0 queued
PR description / Description follows the template (pull_request_target) Successful in 4s
beanstalk/approval approved by GummiNaomi (reviewed)
beanstalk/windows 2/1 pass
65945ab482
Since #983 the crash window's report reads the log again and copies its
lines with strdup (host/hos_crash_dialog.c, lines_add and crash_lines).
The Windows build for the MSVC target links without oldnames.lib (issue
439), where that name is not found: after the whole game had been
translated and compiled the link stopped at
"lld-link: error: undefined symbol: strdup". The llvm-mingw and Linux
builds have the name and were not affected.

The two copies go through line_copy: _strdup on Windows, strdup elsewhere.

tests/test_msvc_oldnames.py now reads the host's sources for the legacy
names only oldnames.lib gave (strdup, stricmp, unlink, getcwd ...) and
fails on a call the Windows build compiles: not under #ifndef _WIN32, the
#else of an #ifdef _WIN32 chain or another system's section. On main it
names hos_crash_dialog.c:1232 and :1255 and nothing else.

Assisted-by: Claude Mythos 5.2
Co-Authored-By: Claude Mythos 5.2 <[email protected]>
Author
Member

@Beanstalk windows and linux: build this branch and start the game (the title screen, then a new save's first area for a few seconds). Expecting: it builds and links on both as main does, starts, and does not crash. The change is one name in host/hos_crash_dialog.c (_strdup on Windows, strdup elsewhere), so there is nothing to measure: the build and the start are the test.

🤖 Generated with Claude Code

@Beanstalk windows and linux: build this branch and start the game (the title screen, then a new save's first area for a few seconds). Expecting: it builds and links on both as main does, starts, and does not crash. The change is one name in `host/hos_crash_dialog.c` (`_strdup` on Windows, `strdup` elsewhere), so there is nothing to measure: the build and the start are the test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Member
Beanstalk test farm · an earlier run: commit 65945ab (the newer results are in a comment below)

Commit 65945ab · tier reviewed · approved by GummiNaomi · dashboard

What will be tested · default plan (AI failed: the model's response ended with error)

The AI plan failed: the model's response ended with error; using the default plan.

  • Where: any (any PC, 1-2 reports).
  • title: from the title screen, then measure title for 20 s (after 5 s warm-up); 2 runs on each side.
  • hyrule-field: from a new save, then teleport to Hyrule Field, measure field for 60 s (after 10 s warm-up); 2 runs on each side.
  • Measured: crashes, boot time, frame times, stutters and hitches, VRAM use, the game's log.
  • The PR fails if: it crashes; or peak VRAM is more than 10% above main; or frame time (p99) is more than 15% above main.
  • Time: about 51 min of game runs per tester (8 game starts), plus the two builds.

Done (started 08:15 UTC, last report 09:11 UTC). Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
any · 1: linux+amd+radv+dgpu AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6; 2: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3080 Ti, 620.70.6 2/1 1 2 none 5.0 vs 5.0 (−0%) 1,812 vs 1,812 (+0%) pass

Measurements · any

Verdict: pass on any (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: linux+amd+radv+dgpu AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6 AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM; 2: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3080 Ti, 620.70.6 AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM
Scene: title, from the title screen; hyrule-field, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 2 game starts a side, title 20 s after 5 s warm-up; hyrule-field: 2 game starts a side, field 60 s after 10 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Before: main @ 544229a After: this PR @ 65945ab
title · title · peak VRAM (MB) 1,812 1,812 (+0%)
title · title · frame time (p99) (ms) 5.0 5.0 (−0%)
hyrule-field · field · peak VRAM (MB) 8,760 8,920 (+2%)
hyrule-field · field · frame time (p99) (ms) 21.7 22.4 (+3%)

Flags and settings

None: the plan varied no setting, switch or build option.

Markdown for the PR description
## Measurements

**Verdict:** pass on any (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM`  
Scene: title, from the title screen; hyrule-field, from a new save; each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 2 game starts a side, title 20 s after 5 s warm-up; hyrule-field: 2 game starts a side, field 60 s after 10 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

| | Before: main @ 544229a | After: this PR @ 65945ab |
|---|---|---|
| title · title · peak VRAM (MB) | 1,812 | 1,812 (+0%) |
| title · title · frame time (p99) (ms) | 5.0 | 5.0 (−0%) |
| hyrule-field · field · peak VRAM (MB) | 8,760 | 8,920 (+2%) |
| hyrule-field · field · frame time (p99) (ms) | 21.7 | 22.4 (+3%) |

### Flags and settings

None: the plan varied no setting, switch or build option.
<!-- beanstalk:previous --> <details><summary>Beanstalk test farm · an earlier run: commit <code>65945ab</code> (the newer results are in a comment below)</summary> Commit `65945ab` · tier **reviewed** · approved by GummiNaomi · [dashboard](https://beanstalk.magicbean.dev/prs/1379) **What will be tested** · default plan (AI failed: the model's response ended with error) The AI plan failed: the model's response ended with error; using the default plan. - **Where:** any (any PC, 1-2 reports). - **title:** from the title screen, then measure title for 20 s (after 5 s warm-up); 2 runs on each side. - **hyrule-field:** from a new save, then teleport to Hyrule Field, measure field for 60 s (after 10 s warm-up); 2 runs on each side. - **Measured:** crashes, boot time, frame times, stutters and hitches, VRAM use, the game's log. - **The PR fails if:** it crashes; or peak VRAM is more than 10% above main; or frame time (p99) is more than 15% above main. - **Time:** about 51 min of game runs per tester (8 game starts), plus the two builds. Done (started 08:15 UTC, last report 09:11 UTC). Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | any · 1: linux+amd+radv+dgpu `AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` | 2/1 [1](https://beanstalk.magicbean.dev/reports/rp_efe64c8c68d0f276) [2](https://beanstalk.magicbean.dev/reports/rp_77d43b2ef4fcadc1) | none | 5.0 vs 5.0 (−0%) | 1,812 vs 1,812 (+0%) | pass | #### Measurements · any **Verdict:** pass on any (2/1 report): no rule failed and no PR run crashed. Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM` Scene: title, from the title screen; hyrule-field, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 2 game starts a side, title 20 s after 5 s warm-up; hyrule-field: 2 game starts a side, field 60 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 544229a | After: this PR @ 65945ab | |---|---|---| | title · title · peak VRAM (MB) | 1,812 | 1,812 (+0%) | | title · title · frame time (p99) (ms) | 5.0 | 5.0 (−0%) | | hyrule-field · field · peak VRAM (MB) | 8,760 | 8,920 (+2%) | | hyrule-field · field · frame time (p99) (ms) | 21.7 | 22.4 (+3%) | ### Flags and settings None: the plan varied no setting, switch or build option. <details><summary>Markdown for the PR description</summary> ```markdown ## Measurements **Verdict:** pass on any (2/1 report): no rule failed and no PR run crashed. Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM` Scene: title, from the title screen; hyrule-field, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 2 game starts a side, title 20 s after 5 s warm-up; hyrule-field: 2 game starts a side, field 60 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 544229a | After: this PR @ 65945ab | |---|---|---| | title · title · peak VRAM (MB) | 1,812 | 1,812 (+0%) | | title · title · frame time (p99) (ms) | 5.0 | 5.0 (−0%) | | hyrule-field · field · peak VRAM (MB) | 8,760 | 8,920 (+2%) | | hyrule-field · field · frame time (p99) (ms) | 21.7 | 22.4 (+3%) | ### Flags and settings None: the plan varied no setting, switch or build option. ``` </details> </details>
GummiNaomi changed title from WIP: fix(build): the crash window copies log lines by a name the MSVC target links (no "undefined symbol: strdup") to fix(build): the crash window copies log lines by a name the MSVC target links (no "undefined symbol: strdup") 2026-11-17 08:55:26 +00:00
TrashPanda left a comment

The crash window's two copies use _strdup on Windows and strdup everywhere else. I read head 65945ab. It applies onto current main. This is not a merge yet.

The MSVC target links without oldnames.lib, so the plain name is not there and the link stopped after the game had been compiled. _strdup is the name that runtime provides, and free is still how those copies are released. The check reads the host sources and fails if a Windows build still calls one of those old names. Putting this file back names the two strdup calls.

The Linux farm already built this head and started it: a title and Hyrule Field on a Radeon RX 7900 XT, no crash. The Windows llvm-mingw build named in Must be tested is still open. The farm's plan took one Linux machine and finished.

The crash window's two copies use `_strdup` on Windows and `strdup` everywhere else. I read head `65945ab`. It applies onto current main. This is not a merge yet. The MSVC target links without `oldnames.lib`, so the plain name is not there and the link stopped after the game had been compiled. `_strdup` is the name that runtime provides, and `free` is still how those copies are released. The check reads the host sources and fails if a Windows build still calls one of those old names. Putting this file back names the two `strdup` calls. The Linux farm already built this head and started it: a title and Hyrule Field on a Radeon RX 7900 XT, no crash. The Windows llvm-mingw build named in Must be tested is still open. The farm's plan took one Linux machine and finished.
Author
Member

Thank you: built and started on two Linux PCs (RADV and NVIDIA), no crash. The farm took "any PC" and both were Linux, so one more for the other half:

@Beanstalk windows: build this branch and start the game (the title screen, then a new save's first area for a few seconds). Expecting: the Windows build links as main's does (_strdup is the name this PR calls there), the game starts, and it does not crash.

🤖 Generated with Claude Code

Thank you: built and started on two Linux PCs (RADV and NVIDIA), no crash. The farm took "any PC" and both were Linux, so one more for the other half: @Beanstalk windows: build this branch and start the game (the title screen, then a new save's first area for a few seconds). Expecting: the Windows build links as main's does (`_strdup` is the name this PR calls there), the game starts, and it does not crash. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Member

Beanstalk test farm

Commit 65945ab · tier reviewed · approved by GummiNaomi · dashboard

What will be tested · AI plan (gpt-6.1-terra)

On Windows, the farm will build main and the pull request, then start the title screen and a new save's first area for a few seconds. The game runs take about 20–25 minutes per tester, apart from build time. A build or link failure, failure to reach either screen, or a crash fails the test; this smoke test does not exercise the crash dialog.

  • Where: windows (1-2 reports).
  • title: from the title screen; 1 run on each side.
  • new-save: from a new save; 1 run on each side.
  • Measured: crashes.
  • The PR fails if: it crashes.
  • Time: about 23 min of game runs per tester (4 game starts), plus the two builds.

Done (started 09:28 UTC, last report 10:46 UTC). Run 2: re-planned by GummiNaomi. Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
windows · 1: windows+amd+amd-proprietary+dgpu AMD Radeon RX 9070 XT, 2.0.416; 2: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 4070, 621.1.0 2/1 1 2 none — — pass

Measurements · windows

Verdict: pass on windows (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: windows+amd+amd-proprietary+dgpu AMD Radeon RX 9070 XT, 2.0.416 AMD Ryzen 9 5900X 12-Core Processor, 32 GB RAM; 2: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 4070, 621.1.0 13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM
Scene: title, from the title screen; new-save, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 1 game start a side; new-save: 1 game start a side; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Nothing was measured: no metric came back.

Flags and settings

None: the plan varied no setting, switch or build option.

Markdown for the PR description
## Measurements

**Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9070 XT, 2.0.416` `AMD Ryzen 9 5900X 12-Core Processor, 32 GB RAM`; 2: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM`  
Scene: title, from the title screen; new-save, from a new save; each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 1 game start a side; new-save: 1 game start a side; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

Nothing was measured: no metric came back.

### Flags and settings

None: the plan varied no setting, switch or build option.
<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `65945ab` · tier **reviewed** · approved by GummiNaomi · [dashboard](https://beanstalk.magicbean.dev/prs/1379) **What will be tested** · AI plan (`gpt-6.1-terra`) On Windows, the farm will build main and the pull request, then start the title screen and a new save's first area for a few seconds. The game runs take about 20–25 minutes per tester, apart from build time. A build or link failure, failure to reach either screen, or a crash fails the test; this smoke test does not exercise the crash dialog. - **Where:** windows (1-2 reports). - **title:** from the title screen; 1 run on each side. - **new-save:** from a new save; 1 run on each side. - **Measured:** crashes. - **The PR fails if:** it crashes. - **Time:** about 23 min of game runs per tester (4 game starts), plus the two builds. Done (started 09:28 UTC, last report 10:46 UTC). Run 2: re-planned by GummiNaomi. Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | windows · 1: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9070 XT, 2.0.416`; 2: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` | 2/1 [1](https://beanstalk.magicbean.dev/reports/rp_b2c8c83c68d243c4) [2](https://beanstalk.magicbean.dev/reports/rp_0cbe3af6eb9cf02d) | none | — | — | pass | #### Measurements · windows **Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed. Hardware: 1: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9070 XT, 2.0.416` `AMD Ryzen 9 5900X 12-Core Processor, 32 GB RAM`; 2: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM` Scene: title, from the title screen; new-save, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 1 game start a side; new-save: 1 game start a side; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) Nothing was measured: no metric came back. ### Flags and settings None: the plan varied no setting, switch or build option. <details><summary>Markdown for the PR description</summary> ```markdown ## Measurements **Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed. Hardware: 1: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9070 XT, 2.0.416` `AMD Ryzen 9 5900X 12-Core Processor, 32 GB RAM`; 2: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM` Scene: title, from the title screen; new-save, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); title: 1 game start a side; new-save: 1 game start a side; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) Nothing was measured: no metric came back. ### Flags and settings None: the plan varied no setting, switch or build option. ``` </details>
HumanBean deleted branch fix/crash-dialog-strdup-msvc 2026-11-17 15:57:12 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1379
No description provided.