feat(menu): number rows step by 1, and the Stick dead zone takes any percent #1294

Open
kendowashere wants to merge 3 commits from kendowashere/Longshot:feat/menu-fine-steps into main
First-time contributor

Type: feat · Risk: low · Tested on: Windows 11, RTX 5070 Ti, DualSense · Needs: Linux, any GPU

TL;DR

The menu's number rows jumped in big steps (5, 10, 25 or 100), so exact values like 97% field of view couldn't be picked, and the Stick dead zone offered only six fixed choices. Now a tap moves a number row by 1 and holding the arrow speeds up to the old steps, and the Stick dead zone takes any percent from 0 to 50. Both were checked in the game on Windows with a DualSense and by game-free tests.

Breakdown

  • Who it helps: players who want an exact value (field of view, volume, camera speed and the like), and anyone whose stick needs a dead zone between the old choices (#710).
  • What was wrong: number rows moved only by their coarse step; the Stick dead zone was a list of six choices.
  • What changes: a tap moves 1, a hold past 1.5 s moves by the row's own step; the Stick dead zone is a 0 to 50% row in steps of 1, saved as stick_dead_zone_percent.
  • What does not change: the rows' ranges and defaults (the dead zone stays Default (24%), XInput's own), and saved settings: an old dead zone choice becomes its percent.
  • How it was checked: in the game on Windows 11, RTX 5070 Ti, DualSense; new and updated game-free tests; the full suite fails only what main fails.
  • Still open: a Linux build (asked of the Test Farm).
  • Risk: low: menu input and one threshold formula that keeps every old value's threshold.

Why

The Insert menu's number rows move in coarse steps: Field of view and Volume by 5, Sharpness and Mouse sensitivity by 10, Camera speed and Vibration strength by 25, HDR peak brightness by 100. A player who wants 97% field of view or 80% camera speed can't pick it. Players asked for steps of 1: issue #710 asks it for the Stick dead zone, which isn't even a number row but six fixed choices (Default (24%), 5%, 10%, 15%, 20%, 30%). This makes every number row take steps of 1, keeps a long scale quick to cross, and makes the Stick dead zone a number row of its own, any percent from 0 to 50.

What changed

A number row (a scale of more than two values whose step is above 1) moves by 1 for a tap of an arrow and for the first 1.5 s it is held, the repeat's slow part. Held longer, the repeat's fast part, it moves by the row's own step, to the next of its steps counted from the row's low end (52 → 55 → 60 on Volume), so HDR peak brightness's 400 to 4000 still takes seconds, not minutes. Rows of step 1 and two-value rows are unchanged. The rows' definitions are unchanged: their step stays the coarse one, so nothing that reads a row's step changes.

  • gpu/vk/vk_menu.cpp:
    • row_next(r, dir, fast): the value one press away, before set_row's ends (which still stop or wrap as before).
    • arrow_held_ns[5]: kept by menu_tick's existing repeat (how long each arrow is held).
    • arrow_fast(dir): whether that arrow is past 1.5 s.
    • Both places a Left or Right press changes a row (the tabs, and the Controls page's own rows) go through row_next.
    • The value column's width also measures the value just under each step, which a 1 between steps can make wider (88% against 90%).
    • rumble_step keeps an options file's Vibration strength within 25 to 200 (main's range since the Vibration row) instead of rounding it to 25, so a value the arrows picked survives the next start.
  • docs/user/graphics-and-controls.md: each number row's choices say "in steps of 1 (N while held)", and a line above the table says how the arrows step.
  • Tests:
    • tests/test_menu_fine_steps.py (new): see Testing.
    • tests/test_rumble_menu.py: a tap moves 1, a long hold moves to the next 25, an options file's value is kept. Its stand-ins also gain framegen_by_dlss_offered, which set_row calls since main's frame generation rows; without it the check failed to compile on main too.
    • tests/test_camera_speed.py: the guide row's new text.
    • tests/test_menu_text_field.py: arrow_held_ns in its stand-ins.

The Stick dead zone (Controls tab; second commit, ba4c9159):

  • The row takes any whole percent from 0 to 50 in steps of 1 instead of its six choices. 24% still shows as Default (24%), and the arrows and a click stop at its ends (stops_at_ends, is_slider).
  • host/nn_hid.c hos_filter_stick: the threshold is the percent of a full tilt, (zone * 32767 + 50) / 100; 24 (and anything out of range) stays XInput's own 7849, so the default is unchanged, and the old choices (5, 10, 15, 20, 30) land on the thresholds they had. The host's readers (nn_hid.c, host/pad_sdl.c) default to 24 when there is no menu.
  • The options file keeps it as stick_dead_zone_percent. An older file's stick_dead_zone= (the choice, 0 to 5) is read once and becomes its percent (stick_dead_zone_from_choice), and save() drops the old line, so nobody's setting changes.
  • gpu/vk/menu/controller.cpp: the row, a module since #1633: a Slider from 0 to 50 in steps of 1, saved as stick_dead_zone_percent; vk_menu.cpp keeps stick_dead_zone_from_choice and the old line's reading in menu_init.
  • docs/user/graphics-and-controls.md: the row's choices and its paragraph.
  • Tests: tests/test_stick_dead_zone.py compiles the row's options code and checks the ini key, reading stick_dead_zone_percent (clamped to 0 to 50), each old choice becoming its percent, the new key winning over the old one, the row's texts and range, and that the host reads option 11 with 24 as its default. tests/test_stick_inversion_rest.py runs hos_filter_stick with the old choices' percents, which still cut at their old thresholds. Stand-ins in tests/test_audio_output_menu.py, test_menu_keys.py and test_upscaler_round_trip.py.

Measurements

Verdict: nothing to measure: a menu input change; the repeat keeps one more number per arrow.

Flags and settings

No new row, switch or build flag. The number rows' steps change as the player guide's table now says.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
The number rows' arrows Field of view, Volume, Sharpness, Mouse sensitivity, Camera speed, Vibration strength, Walk speed, Motion sensitivity X/Y, HDR paper white, peak brightness and contrast their step (5 to 100) 1; their step once held past 1.5 s Any value can be picked Helps: players who want an exact value -
Stick dead zone (stick_dead_zone_percent) how far a stick moves before it counts Default (24%), 5%, 10%, 15%, 20%, 30% (stick_dead_zone=, a choice) 0% to 50% in steps of 1; Default (24%) Any dead zone can be picked; an old choice becomes its percent Helps: a precise stick (lower) or a drifting one (in between the old steps) Default (24%), as before

Testing

Tested:

  • Game-free:

    • tests/test_menu_fine_steps.py (new) cuts row_next and the Row struct out of vk_menu.cpp, compiles them with a C++ compiler and runs them: a tap moves 1; a long hold goes to the next step from the row's low end in either direction (Volume, Mouse sensitivity from 10, HDR peak brightness); a step-1 row and a two-value row are unchanged; the ends are set_row's.
    • It also checks that both arrow sites go through row_next, that the repeat keeps the hold's length, that the whole steps start at 1.5 s, that an options file's Vibration strength is no longer rounded, and that the guide's rows give their steps of 1. It fails with a tap moving the row's whole step (tried).
    • python -I -B tests/run_all.py on this branch (ba4c9159, both commits) on main @ 4408ce0d: 631 passed, 40 failed, 112 skipped. A clean main @ 4408ce0d on this PC: 630 passed, 40 failed, 112 skipped. The same 40 fail on both: test_auto_handheld, test_bug_report_defaults, test_cpu_report, test_crash_dialog, test_crt_options, test_damage_debug_menu, test_dev_packs, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_fastfp_fma, test_fpx_sticky, test_game_menu_mouse_buttons, test_guest_imported, test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_job_queue, test_libc_hooks, test_linux_preflight, test_linux_pressure, test_mirror_budget, test_missing_nup, test_pads_after_menu, test_pending_guest_import, test_pipeline_play_cache, test_portable_builder_home, test_portable_builder_startup, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_sdiv_overflow, test_slow_frames, test_spawn_emit, test_switch_table, test_tested_configurations, test_upscaler_rows, test_walk_key.
  • In the game: Windows 11 Pro, GeForce RTX 5070 Ti, a DualSense through SDL, a pack of this change on an earlier main (6c9edffe), together with my other branches. Tapping Field of view and Volume moves them by 1, and holding speeds up to their old steps; it works as intended.

  • In the game, the Stick dead zone (same PC and controller, a pack of both commits on main @ 8e9cfc3a, together with my other branches): the row takes any percent from 0 to 50 and the stick's dead zone follows it; it works as intended.

Not tested: a run of this exact commit on current main in the game (both commits were run on earlier mains, 6c9edffe and 8e9cfc3a; the code they change is the same); Linux and Steam Deck (the host change in host/nn_hid.c and host/pad_sdl.c is plain C both share).

Must be tested:

  • Linux, any GPU (the Test Farm): build this branch and start the game, expecting it to build and start and the Insert menu's Field of view to move by 1 a press and the Controls tab's Stick dead zone to show Default (24%).
  • Any platform, by hand: Insert menu, Gameplay, Field of view: tap Right, expecting 101%; hold Right for two seconds, expecting it to speed up and land on multiples of 5; restart the game, expecting the value kept. Controls, Stick dead zone: Right from Default (24%), expecting 25%; set 40%, expecting the stick to need a bigger tilt before Link moves; with an options file from before this PR holding stick_dead_zone=3 (15%), expecting the row to show 15%.

Risks

What could break: a row with a step above 1 whose values between steps mean nothing would now accept them. Every such row is a number (the twelve above), and their text functions print any value. An options file's Vibration strength is no longer rounded to 25: a hand-edited 60 stays 60 (the rumble is a percentage).

An options file from this PR read by an older build: its stick_dead_zone= line is gone, so the older build shows Default (24%).

Turning it off: revert the commits.

Compatibility: the options file gains stick_dead_zone_percent in place of stick_dead_zone; older files load as before, their dead zone choice carried over. No caches, no API change, nothing for the player's build to translate again.

Issues

Fixes #710

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Open: built and run on Windows; gpu/vk/vk_menu.cpp, host/nn_hid.c and host/pad_sdl.c not built for Linux here.)
  • Docs updated.
**Type:** feat · **Risk:** low · **Tested on:** Windows 11, RTX 5070 Ti, DualSense · **Needs:** Linux, any GPU ## TL;DR The menu's number rows jumped in big steps (5, 10, 25 or 100), so exact values like 97% field of view couldn't be picked, and the Stick dead zone offered only six fixed choices. Now a tap moves a number row by 1 and holding the arrow speeds up to the old steps, and the Stick dead zone takes any percent from 0 to 50. Both were checked in the game on Windows with a DualSense and by game-free tests. ## Breakdown - **Who it helps:** players who want an exact value (field of view, volume, camera speed and the like), and anyone whose stick needs a dead zone between the old choices (#710). - **What was wrong:** number rows moved only by their coarse step; the Stick dead zone was a list of six choices. - **What changes:** a tap moves 1, a hold past 1.5 s moves by the row's own step; the Stick dead zone is a 0 to 50% row in steps of 1, saved as `stick_dead_zone_percent`. - **What does not change:** the rows' ranges and defaults (the dead zone stays Default (24%), XInput's own), and saved settings: an old dead zone choice becomes its percent. - **How it was checked:** in the game on Windows 11, RTX 5070 Ti, DualSense; new and updated game-free tests; the full suite fails only what `main` fails. - **Still open:** a Linux build (asked of the Test Farm). - **Risk:** low: menu input and one threshold formula that keeps every old value's threshold. ## Why The Insert menu's number rows move in coarse steps: Field of view and Volume by 5, Sharpness and Mouse sensitivity by 10, Camera speed and Vibration strength by 25, HDR peak brightness by 100. A player who wants 97% field of view or 80% camera speed can't pick it. Players asked for steps of 1: issue #710 asks it for the Stick dead zone, which isn't even a number row but six fixed choices (Default (24%), 5%, 10%, 15%, 20%, 30%). This makes every number row take steps of 1, keeps a long scale quick to cross, and makes the Stick dead zone a number row of its own, any percent from 0 to 50. ## What changed A number row (a scale of more than two values whose step is above 1) moves by **1** for a tap of an arrow and for the first 1.5 s it is held, the repeat's slow part. Held longer, the repeat's fast part, it moves by the row's own step, to the next of its steps counted from the row's low end (52 → 55 → 60 on Volume), so HDR peak brightness's 400 to 4000 still takes seconds, not minutes. Rows of step 1 and two-value rows are unchanged. The rows' definitions are unchanged: their step stays the coarse one, so nothing that reads a row's step changes. - `gpu/vk/vk_menu.cpp`: - `row_next(r, dir, fast)`: the value one press away, before `set_row`'s ends (which still stop or wrap as before). - `arrow_held_ns[5]`: kept by `menu_tick`'s existing repeat (how long each arrow is held). - `arrow_fast(dir)`: whether that arrow is past 1.5 s. - Both places a Left or Right press changes a row (the tabs, and the Controls page's own rows) go through `row_next`. - The value column's width also measures the value just under each step, which a 1 between steps can make wider (88% against 90%). - `rumble_step` keeps an options file's Vibration strength within 25 to 200 (main's range since the Vibration row) instead of rounding it to 25, so a value the arrows picked survives the next start. - `docs/user/graphics-and-controls.md`: each number row's choices say "in steps of 1 (N while held)", and a line above the table says how the arrows step. - Tests: - `tests/test_menu_fine_steps.py` (new): see Testing. - `tests/test_rumble_menu.py`: a tap moves 1, a long hold moves to the next 25, an options file's value is kept. Its stand-ins also gain `framegen_by_dlss_offered`, which `set_row` calls since main's frame generation rows; without it the check failed to compile on `main` too. - `tests/test_camera_speed.py`: the guide row's new text. - `tests/test_menu_text_field.py`: `arrow_held_ns` in its stand-ins. **The Stick dead zone** (Controls tab; second commit, ba4c9159): - The row takes any whole percent from 0 to 50 in steps of 1 instead of its six choices. 24% still shows as Default (24%), and the arrows and a click stop at its ends (`stops_at_ends`, `is_slider`). - `host/nn_hid.c` `hos_filter_stick`: the threshold is the percent of a full tilt, `(zone * 32767 + 50) / 100`; 24 (and anything out of range) stays XInput's own 7849, so the default is unchanged, and the old choices (5, 10, 15, 20, 30) land on the thresholds they had. The host's readers (`nn_hid.c`, `host/pad_sdl.c`) default to 24 when there is no menu. - The options file keeps it as `stick_dead_zone_percent`. An older file's `stick_dead_zone=` (the choice, 0 to 5) is read once and becomes its percent (`stick_dead_zone_from_choice`), and `save()` drops the old line, so nobody's setting changes. - `gpu/vk/menu/controller.cpp`: the row, a module since #1633: a Slider from 0 to 50 in steps of 1, saved as `stick_dead_zone_percent`; `vk_menu.cpp` keeps `stick_dead_zone_from_choice` and the old line's reading in `menu_init`. - `docs/user/graphics-and-controls.md`: the row's choices and its paragraph. - Tests: `tests/test_stick_dead_zone.py` compiles the row's options code and checks the ini key, reading `stick_dead_zone_percent` (clamped to 0 to 50), each old choice becoming its percent, the new key winning over the old one, the row's texts and range, and that the host reads option 11 with 24 as its default. `tests/test_stick_inversion_rest.py` runs `hos_filter_stick` with the old choices' percents, which still cut at their old thresholds. Stand-ins in `tests/test_audio_output_menu.py`, `test_menu_keys.py` and `test_upscaler_round_trip.py`. ## Measurements **Verdict:** nothing to measure: a menu input change; the repeat keeps one more number per arrow. ### Flags and settings No new row, switch or build flag. The number rows' steps change as the player guide's table now says. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | The number rows' arrows | Field of view, Volume, Sharpness, Mouse sensitivity, Camera speed, Vibration strength, Walk speed, Motion sensitivity X/Y, HDR paper white, peak brightness and contrast | their step (5 to 100) | 1; their step once held past 1.5 s | Any value can be picked | Helps: players who want an exact value | - | | Stick dead zone (`stick_dead_zone_percent`) | how far a stick moves before it counts | Default (24%), 5%, 10%, 15%, 20%, 30% (`stick_dead_zone=`, a choice) | 0% to 50% in steps of 1; Default (24%) | Any dead zone can be picked; an old choice becomes its percent | Helps: a precise stick (lower) or a drifting one (in between the old steps) | Default (24%), as before | ## Testing **Tested:** - Game-free: - `tests/test_menu_fine_steps.py` (new) cuts `row_next` and the `Row` struct out of `vk_menu.cpp`, compiles them with a C++ compiler and runs them: a tap moves 1; a long hold goes to the next step from the row's low end in either direction (Volume, Mouse sensitivity from 10, HDR peak brightness); a step-1 row and a two-value row are unchanged; the ends are `set_row`'s. - It also checks that both arrow sites go through `row_next`, that the repeat keeps the hold's length, that the whole steps start at 1.5 s, that an options file's Vibration strength is no longer rounded, and that the guide's rows give their steps of 1. It fails with a tap moving the row's whole step (tried). - `python -I -B tests/run_all.py` on this branch (ba4c9159, both commits) on `main` @ 4408ce0d: 631 passed, 40 failed, 112 skipped. A clean `main` @ 4408ce0d on this PC: 630 passed, 40 failed, 112 skipped. The same 40 fail on both: `test_auto_handheld`, `test_bug_report_defaults`, `test_cpu_report`, `test_crash_dialog`, `test_crt_options`, `test_damage_debug_menu`, `test_dev_packs`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_fastfp_fma`, `test_fpx_sticky`, `test_game_menu_mouse_buttons`, `test_guest_imported`, `test_hud_layout_row`, `test_invalidate_quick`, `test_invalidate_vcore`, `test_job_queue`, `test_libc_hooks`, `test_linux_preflight`, `test_linux_pressure`, `test_mirror_budget`, `test_missing_nup`, `test_pads_after_menu`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_portable_builder_home`, `test_portable_builder_startup`, `test_present_thread`, `test_profiling_mode`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_run_all_changed`, `test_sdiv_overflow`, `test_slow_frames`, `test_spawn_emit`, `test_switch_table`, `test_tested_configurations`, `test_upscaler_rows`, `test_walk_key`. - In the game: Windows 11 Pro, GeForce RTX 5070 Ti, a DualSense through SDL, a pack of this change on an earlier `main` (6c9edffe), together with my other branches. Tapping Field of view and Volume moves them by 1, and holding speeds up to their old steps; it works as intended. - In the game, the Stick dead zone (same PC and controller, a pack of both commits on `main` @ 8e9cfc3a, together with my other branches): the row takes any percent from 0 to 50 and the stick's dead zone follows it; it works as intended. **Not tested:** a run of this exact commit on current `main` in the game (both commits were run on earlier `main`s, 6c9edffe and 8e9cfc3a; the code they change is the same); Linux and Steam Deck (the host change in `host/nn_hid.c` and `host/pad_sdl.c` is plain C both share). **Must be tested:** - Linux, any GPU (the Test Farm): build this branch and start the game, expecting it to build and start and the Insert menu's Field of view to move by 1 a press and the Controls tab's Stick dead zone to show Default (24%). - Any platform, by hand: Insert menu, Gameplay, Field of view: tap Right, expecting 101%; hold Right for two seconds, expecting it to speed up and land on multiples of 5; restart the game, expecting the value kept. Controls, Stick dead zone: Right from Default (24%), expecting 25%; set 40%, expecting the stick to need a bigger tilt before Link moves; with an options file from before this PR holding `stick_dead_zone=3` (15%), expecting the row to show 15%. ## Risks **What could break:** a row with a step above 1 whose values between steps mean nothing would now accept them. Every such row is a number (the twelve above), and their text functions print any value. An options file's Vibration strength is no longer rounded to 25: a hand-edited 60 stays 60 (the rumble is a percentage). An options file from this PR read by an older build: its `stick_dead_zone=` line is gone, so the older build shows Default (24%). **Turning it off:** revert the commits. **Compatibility:** the options file gains `stick_dead_zone_percent` in place of `stick_dead_zone`; older files load as before, their dead zone choice carried over. No caches, no API change, nothing for the player's build to translate again. ## Issues Fixes #710 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Open: built and run on Windows; `gpu/vk/vk_menu.cpp`, `host/nn_hid.c` and `host/pad_sdl.c` not built for Linux here.) - [x] Docs updated.
Author
First-time contributor

Tested in game: Windows 11 Pro, GeForce RTX 5070 Ti, a DualSense through SDL; a pack of this change (with my other branches) on main @ 6c9edffe. Field of view and Volume move by 1 a tap and speed up to their old steps when held.

Tested in game: Windows 11 Pro, GeForce RTX 5070 Ti, a DualSense through SDL; a pack of this change (with my other branches) on main @ 6c9edffe. Field of view and Volume move by 1 a tap and speed up to their old steps when held.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Testing's Tested and the author's comments: in the game on Windows 11, RTX 5070 Ti, DualSense, on an earlier main.
  • Nothing gets worse that I know of: ticked: Measurements says nothing to measure for a menu input change, and Risks names no speed cost.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Testing's Tested and the author's comments: in the game on Windows 11, RTX 5070 Ti, DualSense, on an earlier main. - *Nothing gets worse that I know of*: ticked: Measurements says nothing to measure for a menu input change, and Risks names no speed cost.
kendowashere changed title from WIP: feat(menu): number rows step by 1, a long hold by their own steps to WIP: feat(menu): number rows step by 1, and the Stick dead zone takes any percent 2026-11-18 21:50:49 +00:00
kendowashere force-pushed feat/menu-fine-steps from bf885f8fa4
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to ba4c9159f6
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval waiting for a BigBean's 👍 on the request
PR description / Description follows the template (pull_request_target) Failing after 11s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-18 21:50:50 +00:00
Compare
Author
First-time contributor

@Beanstalk On Linux, any GPU: build this branch and start the game with default settings, expecting it to build, start and reach gameplay. This is a build check for the host and menu files; the menu's arrow steps and the Stick dead zone need no farm check.

@Beanstalk On Linux, any GPU: build this branch and start the game with default settings, expecting it to build, start and reach gameplay. This is a build check for the host and menu files; the menu's arrow steps and the Stick dead zone need no farm check.
Member

@kendowashere only members of BigBeans can start the farm.

One of them can approve this request by reacting 👍 to it or to this comment. This request was for ba4c915, and the PR has changed since (0930b0b), so a 👍 no longer approves it. Comment @Beanstalk again to ask for the new commit.

@kendowashere only members of `BigBeans` can start the farm. ~~One of them can approve this request by reacting 👍 to it or to this comment.~~ This request was for `ba4c915`, and the PR has changed since (`0930b0b`), so a 👍 no longer approves it. Comment `@Beanstalk` again to ask for the new commit.
kendowashere changed title from WIP: feat(menu): number rows step by 1, and the Stick dead zone takes any percent to feat(menu): number rows step by 1, and the Stick dead zone takes any percent 2026-11-21 06:27:58 +00:00
Merge remote-tracking branch 'origin/main' into upd/menu-fine-steps
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
beanstalk/approval changed since the request: ask again
PR description / Description follows the template (pull_request_target) Failing after 5s
0930b0ba12
# Conflicts:
#	README.md
#	gpu/vk/vk_menu.cpp
#	gpu/vk/vk_menu.h
#	tests/test_audio_output_menu.py
#	tests/test_camera_speed.py
#	tests/test_menu_keys.py
#	tests/test_rumble_menu.py
#	tests/test_stick_dead_zone.py
#	tests/test_upscaler_round_trip.py
Some checks failed
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
beanstalk/approval changed since the request: ask again
PR description / Description follows the template (pull_request_target) Failing after 5s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'feat/menu-fine-steps:kendowashere-feat/menu-fine-steps'
git switch 'kendowashere-feat/menu-fine-steps'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1294
No description provided.