test(nvn): cover every guarded memory-pool accessor #541

Merged

nicholasgower merged 1 commit from test/pool-guard-coverage into main

2026-11-08 10:18:41 +00:00

nicholasgower commented

2026-11-08 09:27:09 +00:00

(Migrated from github.com)

What

Extends the test from #287 / PR #510 to every memory-pool accessor guarded by no_pool() in host/nvn_native.c: nvnMemoryPoolGetFlags, nvnMemoryPoolGetSize, nvnMemoryPoolMap, nvnMemoryPoolGetBufferAddress and nvnMemoryPoolInvalidateMappedRange.

Null calls answer 0 or return without touching memory; a real pool still returns its flags, size, mapped pointer and GPU address. The fixture is built from the real function bodies at -O2.

Test

python -I -B tests/test_nvn_null_pool.py (existing CI step)
No game files or GPU needed.

Refs #287.

## What Extends the test from #287 / PR #510 to every memory-pool accessor guarded by `no_pool()` in `host/nvn_native.c`: `nvnMemoryPoolGetFlags`, `nvnMemoryPoolGetSize`, `nvnMemoryPoolMap`, `nvnMemoryPoolGetBufferAddress` and `nvnMemoryPoolInvalidateMappedRange`. Null calls answer 0 or return without touching memory; a real pool still returns its flags, size, mapped pointer and GPU address. The fixture is built from the real function bodies at `-O2`. ## Test - `python -I -B tests/test_nvn_null_pool.py` (existing CI step) - No game files or GPU needed. Refs #287.

nicholasgower commented

2026-11-08 09:32:06 +00:00

(Migrated from github.com)

The appimage job is the packaging workflow; it fails on main at the same AppImage step too. The relevant checks pass: Python source checks on Ubuntu and Windows, including the extended Check a null NVN memory pool is answered, not dereferenced, and the SPIR-V fixture job.

The `appimage` job is the packaging workflow; it fails on `main` at the same AppImage step too. The relevant checks pass: `Python source checks` on Ubuntu and Windows, including the extended `Check a null NVN memory pool is answered, not dereferenced`, and the SPIR-V fixture job.

Commenting is not possible because the repository is archived.

No reviewers