Windows builder: choose compiler workers for this session #517

Merged

monsterlag merged 3 commits from fix/windows-build-workers into main

2026-11-08 10:20:25 +00:00

monsterlag commented

2026-11-08 07:48:55 +00:00

(Migrated from github.com)

Validate selection before progress or process startup and forward it through the common source/update build path. Fresh updater windows remain Automatic. No preference store, compiler or default worker policy changes.

Validation:

The harness links the actual Runner and selection helper. Its 69 assertions cover Automatic inheritance, manual overrides of valid/malformed inherited values, unchanged parent environment, source/folder/update arguments, Check, invalid selection and actual delivery through authored Python children.
WPF Debug builds without warnings/errors. Exact-head self-contained Release publishes with both GUI files embedding 38de6d88834f3437df563a07d1fd73e2efe8faff.
Native UI inspection of that Release at 960x600/current desktop DPI verified Automatic/manual 4, keyboard navigation, visible focus and no obvious clipping of note/footer/path/language. The window closed normally; no Build, installer or game action occurred. Initial captures intermittently appeared gray before later interface frames.
Existing CI steps are preserved; Windows gains the focused harness and WPF compile. A normal merge includes the shared #488 fixture correction. All four hosted checks passed at 38de6d8, including the actual Runner harness and WPF compile.

No actual game build or throughput benchmark, other DPI/locale matrix, physical-device test or SteamOS validation was performed. The installed player and owner data were unchanged.

Refs #502 and #503. Their early estimates are not a completed-build regression measurement; more workers are not guaranteed to make a build faster.

The Windows Builder has no visible worker-count choice although its build tools already accept an inherited override. Add a session-only Build workers dropdown: Automatic or a count up to the PC's logical processor count. Explicit selection changes only the build child's HOOKSHOT_JOBS; Automatic preserves inherited values and the existing memory policy. Validate selection before progress or process startup and forward it through the common source/update build path. Fresh updater windows remain Automatic. No preference store, compiler or default worker policy changes. Validation: - The harness links the actual Runner and selection helper. Its 69 assertions cover Automatic inheritance, manual overrides of valid/malformed inherited values, unchanged parent environment, source/folder/update arguments, Check, invalid selection and actual delivery through authored Python children. - WPF Debug builds without warnings/errors. Exact-head self-contained Release publishes with both GUI files embedding `38de6d88834f3437df563a07d1fd73e2efe8faff`. - Native UI inspection of that Release at 960x600/current desktop DPI verified Automatic/manual 4, keyboard navigation, visible focus and no obvious clipping of note/footer/path/language. The window closed normally; no Build, installer or game action occurred. Initial captures intermittently appeared gray before later interface frames. - Existing CI steps are preserved; Windows gains the focused harness and WPF compile. A normal merge includes the shared #488 fixture correction. All four hosted checks passed at `38de6d8`, including the actual Runner harness and WPF compile. No actual game build or throughput benchmark, other DPI/locale matrix, physical-device test or SteamOS validation was performed. The installed player and owner data were unchanged. Refs #502 and #503. Their early estimates are not a completed-build regression measurement; more workers are not guaranteed to make a build faster.