Start the built game from the builder AppImage #294
No reviewers
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot!294
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/appimage-launcher"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Linux AppImage is the builder. It already had a Play button in the window. This makes starting the game part of that same image, instead of a second download.
./Hookshot-<version>-x86_64.AppImageopens the builder.--playstarts the game the builder saved, and--play <folder>starts a different build. A desktop action named Play does the same. The start dropsHOOKSHOT_*,PYTHON*,APPDIR,APPIMAGE,ARGV0,OWDandLD_LIBRARY_PATHfirst, so the game loads SDL from beside itself.The builder window is unchanged. There is no second AppImage.
Testing:
python3 -I -B tests/test_hookshot_launch.py(4 tests). A folder named100% Gamesstarts, and those variables are gone. A folder argument wins. Nohookshotthere is an error. The pack script does not emit a launcher AppImage, and the builder's desktop entry has the Play action.desktop-file-validateaccepts the builder desktop file, including the Play action.@SkippySteve Fix conflicts please.
Thanks! This one conflicts with main now (main moved a lot today: the controller chain 335/343/350 and the input-in-background PR are merged, and the Windows package now ships SDL2 as sdl2-compat on SDL3 3.4.20). Could you rebase it on main? I'll merge it once it applies cleanly.
Thanks!