fix: main's source checks pass again after the batch of merges #2660

Closed

NotRexed wants to merge 0 commits from fix/main-tests into main

NotRexed commented

2026-11-12 04:34:31 +00:00

(Migrated from github.com)

Each of the recently merged PRs was green against its own base, but together on main they broke these source checks (they fail on every open PR):

Check	Cause	Fix
`test_env_on`	`RX_VK_CAPTURE_KEEP_OLD` and `RX_VK_CAP_BLOCKS` were read as set-means-on, so `=0` turned them on	read through `env_on`
`test_hdr_encode`	DLSS's `TemporalEngine` gained two fields after `hdr`	the check matches the fields it means, with anything after them
`test_linux_docker_packages`	the workflow's `add-apt-repository -y --no-update ppa:…` was read as PPA `--no-update`	options are skipped
`test_menu_i18n`	three English hints changed: the Controls page's ocarina note keys (#1930), mesh shaders' Linux AMD compute path (#2362), the Button prompts' keyboard face (#2435)	the 13 translations of each are updated, the new sentences translated

test_display_startup_failure and test_wayland_libdecor_hint already pass on main since #2648. All six pass locally (the Wayland one is skipped on Windows, as its runner says).

🤖 Generated with Claude Code

Each of the recently merged PRs was green against its own base, but together on main they broke these source checks (they fail on every open PR): | Check | Cause | Fix | |---|---|---| | `test_env_on` | `RX_VK_CAPTURE_KEEP_OLD` and `RX_VK_CAP_BLOCKS` were read as set-means-on, so `=0` turned them on | read through `env_on` | | `test_hdr_encode` | DLSS's `TemporalEngine` gained two fields after `hdr` | the check matches the fields it means, with anything after them | | `test_linux_docker_packages` | the workflow's `add-apt-repository -y --no-update ppa:…` was read as PPA `--no-update` | options are skipped | | `test_menu_i18n` | three English hints changed: the Controls page's ocarina note keys (#1930), mesh shaders' Linux AMD compute path (#2362), the Button prompts' keyboard face (#2435) | the 13 translations of each are updated, the new sentences translated | `test_display_startup_failure` and `test_wayland_libdecor_hint` already pass on main since #2648. All six pass locally (the Wayland one is skipped on Windows, as its runner says). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

github-sync referenced this pull request from a commit

2026-11-12 06:19:01 +00:00

test: the HDR check takes DLSS's engine with fields after hdr (#2661)

github-sync commented

2026-11-12 06:23:59 +00:00

Owner

@NotRexed commented on GitHub · 2026-11-12 04:36 UTC · original

Superseded: #2651, #2652 and #2654 fixed three of these on main meanwhile; the HDR check's fix is in its own PR.

> [@NotRexed](https://github.com/NotRexed) commented on GitHub · 2026-11-12 04:36 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2660#issuecomment-6814668150) Superseded: #2651, #2652 and #2654 fixed three of these on main meanwhile; the HDR check's fix is in its own PR.

Commenting is not possible because the repository is archived.

No reviewers