MagicBeanDev/Hookshot
Archived
Watch
6
0
Fork
You've already forked Hookshot
 0
Code Issues 125 Pull requests 205 Activity

test: restore the display startup CI fixture #2049

Closed
Arkex-ai wants to merge 1 commit from fix/display-startup-cache-fixture into main
pull from: fix/display-startup-cache-fixture
merge into: MagicBeanDev:main
Conversation 1 Commits 1 Files changed 1 +1
Arkex-ai commented 2026-11-11 01:05:17 +00:00 (Migrated from github.com)

Summary

The display startup regression test stopped compiling after #2033 added a shader-cache setup call. This restores the test on Windows and Linux, including the cases that check whether startup failures produce a useful error.

Technical changes

  • Stub the new cache setup call in the display startup fixture. The separate driver-cache test covers its environment behavior.

Validation

  • Reproduced the missing declaration on main f8efe057. It also failed in the hosted source jobs for #1954 and #2035.
  • All 11 display startup cases passed at 1adf9e79 on Windows LLVM and Ubuntu Clang 18, including missing SDL, initialization failure, window failure and visible startup.
  • Original report and dev-work claim.
## Summary The display startup regression test stopped compiling after #2033 added a shader-cache setup call. This restores the test on Windows and Linux, including the cases that check whether startup failures produce a useful error. ## Technical changes - Stub the new cache setup call in the display startup fixture. The separate driver-cache test covers its environment behavior. ## Validation - Reproduced the missing declaration on main `f8efe057`. It also failed in the hosted source jobs for #1954 and #2035. - All **11 display startup cases passed** at `1adf9e79` on Windows LLVM and Ubuntu Clang 18, including missing SDL, initialization failure, window failure and visible startup. - [Original report](https://git.magicbean.dev/MagicBeanDev/Hookshot/pulls/2033) and [dev-work claim](https://discord.com/channels/1568810484818378804/1569019786766188665/1569880427387424872).
Arkex-ai commented 2026-11-11 01:26:56 +00:00 (Migrated from github.com)

Closing as superseded by #2051, which restored the same driver-cache stub on main. The Windows and Linux suites here passed before the upstream fix landed.

Closing as superseded by #2051, which restored the same driver-cache stub on main. The Windows and Linux suites here passed before the upstream fix landed.
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
autorelease: pending

   
autorelease: tagged

   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
testing wanted

   
wontfix
This will not be worked on

No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Hookshot!2049
No description provided.