test: two stale tests keep main red (lift cleanup's PREPARE, launcher keys of renamed rows) #1836

Merged

Joey-Magnus merged 2 commits from fix/test-lift-cleanup-prepare into main

2026-11-10 17:52:35 +00:00

Joey-Magnus commented

2026-11-10 17:49:28 +00:00

(Migrated from github.com)

Two tests fail on main. Neither is a bug in the code they check.

tests/test_lift_cleanup_error.py: NameError: name 'PREPARE' is not defined (3 errors). Since b946c44 (--prepare for RecompLauncher), say() reads the module global PREPARE. The test cuts say/fail out of make_game.py and runs them in its own namespace, which didn't have it. The builder itself is fine (PREPARE = False at module level). The namespace now has PREPARE=False.
tests/test_recomplauncher_json.py: resolution and upscaling are "not menu rows". They are the ini keys of the rows now named Render resolution and Upscaler, which ini_key() keeps so an options file from before still loads, and recomplauncher.json is right to set them. The test special-cased only output_res; it now takes every key ini_key() returns explicitly.

run_all.py on this branch: 260 passed, 0 failed (Linux).

🤖 Generated with Claude Code

Two tests fail on `main`. Neither is a bug in the code they check. 1. **`tests/test_lift_cleanup_error.py`**: `NameError: name 'PREPARE' is not defined` (3 errors). Since b946c44 (`--prepare` for RecompLauncher), `say()` reads the module global `PREPARE`. The test cuts `say`/`fail` out of `make_game.py` and runs them in its own namespace, which didn't have it. The builder itself is fine (`PREPARE = False` at module level). The namespace now has `PREPARE=False`. 2. **`tests/test_recomplauncher_json.py`**: `resolution` and `upscaling` are "not menu rows". They are the ini keys of the rows now named Render resolution and Upscaler, which `ini_key()` keeps so an options file from before still loads, and `recomplauncher.json` is right to set them. The test special-cased only `output_res`; it now takes every key `ini_key()` returns explicitly. `run_all.py` on this branch: 260 passed, 0 failed (Linux). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Commenting is not possible because the repository is archived.

No reviewers