fix(linux): the AppImage's parts list names the repository it is built in #1312

Merged

notquiteog merged 1 commit from pr/linux-parts-base into main

2026-11-09 23:04:12 +00:00

notquiteog commented

2026-11-09 21:32:16 +00:00

(Migrated from github.com)

What

scripts/linux/appimage.sh now passes --base to make_parts.py, naming the linux-parts release of $GITHUB_REPOSITORY (falling back to NotRexed/Hookshot when it is unset, as in a local build).

Why

publish_parts.sh uploads the parts to the linux-parts release of $GITHUB_REPOSITORY, but the list hookshot-linux.txt was made without --base, so it always named NotRexed/Hookshot's release. On this repository the two are the same place, and nothing changes here. On a fork, CI uploads the parts to the fork while the list still points at this repository's release, which holds none of them, so a fork's Linux update cannot find its own parts. (Found in the fork's v2.6.4 release: its list named parts with no file behind them.)

Testing

make_parts.py run over a stand-in AppDir through the same ${GITHUB_REPOSITORY:-NotRexed/Hookshot} expansion the script now uses:
- GITHUB_REPOSITORY=notquiteog/Hookshot: every URL in hookshot-linux.txt is https://github.com/notquiteog/Hookshot/releases/download/linux-parts/...
- unset: every URL is https://github.com/NotRexed/Hookshot/releases/download/linux-parts/..., identical to before
bash -n scripts/linux/appimage.sh

One file, five lines.

🤖 Generated with Claude Code

## What `scripts/linux/appimage.sh` now passes `--base` to `make_parts.py`, naming the `linux-parts` release of `$GITHUB_REPOSITORY` (falling back to `NotRexed/Hookshot` when it is unset, as in a local build). ## Why `publish_parts.sh` uploads the parts to the `linux-parts` release of `$GITHUB_REPOSITORY`, but the list `hookshot-linux.txt` was made without `--base`, so it always named `NotRexed/Hookshot`'s release. On this repository the two are the same place, and **nothing changes here**. On a fork, CI uploads the parts to the fork while the list still points at this repository's release, which holds none of them, so a fork's Linux update cannot find its own parts. (Found in the fork's v2.6.4 release: its list named parts with no file behind them.) ## Testing - `make_parts.py` run over a stand-in AppDir through the same `${GITHUB_REPOSITORY:-NotRexed/Hookshot}` expansion the script now uses: - `GITHUB_REPOSITORY=notquiteog/Hookshot`: every URL in `hookshot-linux.txt` is `https://github.com/notquiteog/Hookshot/releases/download/linux-parts/...` - unset: every URL is `https://github.com/NotRexed/Hookshot/releases/download/linux-parts/...`, identical to before - `bash -n scripts/linux/appimage.sh` One file, five lines. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

hckrman101 (Migrated from github.com) approved these changes

2026-11-09 22:44:34 +00:00

hckrman101 (Migrated from github.com) left a comment

Looks good. I checked that make_parts.py takes --base (default is the same NotRexed URL, so builds here are unchanged), that it strips a trailing slash, and that publish_parts.sh uploads to $GITHUB_REPOSITORY's linux-parts release, so the list and the upload now agree. The ${GITHUB_REPOSITORY:-NotRexed/Hookshot} fallback covers local builds. CI is green, including the appimage job.

Looks good. I checked that `make_parts.py` takes `--base` (default is the same NotRexed URL, so builds here are unchanged), that it strips a trailing slash, and that `publish_parts.sh` uploads to `$GITHUB_REPOSITORY`'s `linux-parts` release, so the list and the upload now agree. The `${GITHUB_REPOSITORY:-NotRexed/Hookshot}` fallback covers local builds. CI is green, including the appimage job.

Commenting is not possible because the repository is archived.

No reviewers

hckrman101