Missing leaves #35
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#35
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
9060 XT 16gb
5500x3d
16gb ddr4 3200mhz
Using latest release build
same thing on my 4070, so not exclusive to AMD.
4070 12GB
5700x
48gb ddr4 3000mhz
Same here with an 9070xt and a 5900x. Maybe it could be a CPU problem, I know some emulators had problems with Zen 3
No, it isn't the CPU: the GPU culling that decides which leaves to draw was writing zero counts. https://github.com/NotRexed/Hookshot/releases/tag/foliage-linux-updater brings EvilOOT's foliage fix, which draws the canopy in more places; please try it and post a screenshot of what is still bare.
I have tried the new build and the image is exactly the same as before for me, foliage is still missing
Grass is still missing on
device-lost-fixwith an RX 7900 XTX.Setup: RX 7900 XTX, Adrenalin 32.0.31035.1003, Ryzen 9 7900X, 32 GB RAM, Windows 10 (19045). Built with Hookshot Builder from a .nup. In game: Ultra preset, frame generation 4x, resolution 100%, Lanczos.
What I see: Kokiri Forest, outside Link's house: the ground has almost no grass blades. Ground texture, rocks, trees, ferns and small bushes draw. Screenshot below.
From the log:
383a5669(16.1 s compile),53caac5f(15.0 s),abccf81b,cb2e06dd,44511d69,6344c53d.storage buffer NOT bound (reads zeros)for68642bb810ee3e7c,6b4dea601798c255,739acd678ae08655,d905f52b7517c681(stage 7, c5+0x60, size 0x3f800000),51183fe750d5d0c8(c5+0x1d0) andda7a7ab28b8e73d9. Same lines as in #224.I can share the full log.
Fixed in https://github.com/NotRexed/Hookshot/releases/tag/new-installer: the game reads its folder listings with the entry type at offset 0x304, and we wrote it at 0x302, so every file looked like a folder and the game found no leaf files. Found independently by Evil's fork, NX2navi and PR #436. Please tell me if any trees still have no leaves.
Fixed on my machine with latest update
Fixed: the missing Kokiri leaves and grass draw again since release new-installer (the GPU culling fix). Please update with HookshotBuilder.exe from https://github.com/NotRexed/Hookshot/releases/latest; reopen if anything is still missing.