Missing leaves #35

Closed
opened 2026-11-07 05:27:01 +00:00 by Kingbanana574 · 9 comments
Kingbanana574 commented 2026-11-07 05:27:01 +00:00 (Migrated from github.com)
Image

9060 XT 16gb
5500x3d
16gb ddr4 3200mhz

Using latest release build

<img width="2559" height="1439" alt="Image" src="https://github.com/user-attachments/assets/1a59abaf-8840-489c-8ede-a7ea7a0dcba4" /> 9060 XT 16gb 5500x3d 16gb ddr4 3200mhz Using latest release build
Kartoffel0 commented 2026-11-07 05:33:18 +00:00 (Migrated from github.com)

same thing on my 4070, so not exclusive to AMD.

4070 12GB
5700x
48gb ddr4 3000mhz

Image
same thing on my 4070, so not exclusive to AMD. 4070 12GB 5700x 48gb ddr4 3000mhz <img width="1282" height="752" alt="Image" src="https://github.com/user-attachments/assets/6a94384c-b05d-49cc-9b4a-3ed36cb1cf3f" />
xsm2 commented 2026-11-07 17:36:16 +00:00 (Migrated from github.com)

Same here with an 9070xt and a 5900x. Maybe it could be a CPU problem, I know some emulators had problems with Zen 3

Same here with an 9070xt and a 5900x. Maybe it could be a CPU problem, I know some emulators had problems with Zen 3
NotRexed commented 2026-11-07 19:41:24 +00:00 (Migrated from github.com)

No, it isn't the CPU: the GPU culling that decides which leaves to draw was writing zero counts. https://github.com/NotRexed/Hookshot/releases/tag/foliage-linux-updater brings EvilOOT's foliage fix, which draws the canopy in more places; please try it and post a screenshot of what is still bare.

No, it isn't the CPU: the GPU culling that decides which leaves to draw was writing zero counts. https://github.com/NotRexed/Hookshot/releases/tag/foliage-linux-updater brings EvilOOT's foliage fix, which draws the canopy in more places; please try it and post a screenshot of what is still bare.
xsm2 commented 2026-11-07 20:07:36 +00:00 (Migrated from github.com)

No, it isn't the CPU: the GPU culling that decides which leaves to draw was writing zero counts. https://github.com/NotRexed/Hookshot/releases/tag/foliage-linux-updater brings EvilOOT's foliage fix, which draws the canopy in more places; please try it and post a screenshot of what is still bare.

I have tried the new build and the image is exactly the same as before for me, foliage is still missing

Image
> No, it isn't the CPU: the GPU culling that decides which leaves to draw was writing zero counts. https://github.com/NotRexed/Hookshot/releases/tag/foliage-linux-updater brings EvilOOT's foliage fix, which draws the canopy in more places; please try it and post a screenshot of what is still bare. I have tried the new build and the image is exactly the same as before for me, foliage is still missing <img width="3822" height="2035" alt="Image" src="https://github.com/user-attachments/assets/4e5f66e3-411a-47f0-8ea3-5224756b2bed" />
MatthewFeroz commented 2026-11-08 04:54:11 +00:00 (Migrated from github.com)

Grass is still missing on device-lost-fix with an RX 7900 XTX.

Setup: RX 7900 XTX, Adrenalin 32.0.31035.1003, Ryzen 9 7900X, 32 GB RAM, Windows 10 (19045). Built with Hookshot Builder from a .nup. In game: Ultra preset, frame generation 4x, resolution 100%, Lanczos.

What I see: Kokiri Forest, outside Link's house: the ground has almost no grass blades. Ground texture, rocks, trees, ferns and small bushes draw. Screenshot below.

From the log:

  • The culling programs from #252 run: 383a5669 (16.1 s compile), 53caac5f (15.0 s), abccf81b, cb2e06dd, 44511d69, 6344c53d.
  • storage buffer NOT bound (reads zeros) for 68642bb810ee3e7c, 6b4dea601798c255, 739acd678ae08655, d905f52b7517c681 (stage 7, c5+0x60, size 0x3f800000), 51183fe750d5d0c8 (c5+0x1d0) and da7a7ab28b8e73d9. Same lines as in #224.
  • 0 skipped draws a frame. 10 rejected computes (no 16x8x16 f16 cooperative matrix, so matrix multiplies run in software). TAAU stood in for.

I can share the full log.

Grass is still missing on `device-lost-fix` with an RX 7900 XTX. **Setup:** RX 7900 XTX, Adrenalin 32.0.31035.1003, Ryzen 9 7900X, 32 GB RAM, Windows 10 (19045). Built with Hookshot Builder from a .nup. In game: Ultra preset, frame generation 4x, resolution 100%, Lanczos. **What I see:** Kokiri Forest, outside Link's house: the ground has almost no grass blades. Ground texture, rocks, trees, ferns and small bushes draw. Screenshot below. **From the log:** - The culling programs from #252 run: `383a5669` (16.1 s compile), `53caac5f` (15.0 s), `abccf81b`, `cb2e06dd`, `44511d69`, `6344c53d`. - `storage buffer NOT bound (reads zeros)` for `68642bb810ee3e7c`, `6b4dea601798c255`, `739acd678ae08655`, `d905f52b7517c681` (stage 7, c5+0x60, size 0x3f800000), `51183fe750d5d0c8` (c5+0x1d0) and `da7a7ab28b8e73d9`. Same lines as in #224. - 0 skipped draws a frame. 10 rejected computes (no 16x8x16 f16 cooperative matrix, so matrix multiplies run in software). TAAU stood in for. I can share the full log.
NotRexed commented 2026-11-08 05:39:58 +00:00 (Migrated from github.com)

Fixed in https://github.com/NotRexed/Hookshot/releases/tag/new-installer: the game reads its folder listings with the entry type at offset 0x304, and we wrote it at 0x302, so every file looked like a folder and the game found no leaf files. Found independently by Evil's fork, NX2navi and PR #436. Please tell me if any trees still have no leaves.

Fixed in https://github.com/NotRexed/Hookshot/releases/tag/new-installer: the game reads its folder listings with the entry type at offset 0x304, and we wrote it at 0x302, so every file looked like a folder and the game found no leaf files. Found independently by Evil's fork, NX2navi and PR #436. Please tell me if any trees still have no leaves.
xsm2 commented 2026-11-08 08:33:13 +00:00 (Migrated from github.com)

Fixed on my machine with latest update

Fixed on my machine with latest update
NotRexed commented 2026-11-08 09:56:12 +00:00 (Migrated from github.com)

Fixed: the missing Kokiri leaves and grass draw again since release new-installer (the GPU culling fix). Please update with HookshotBuilder.exe from https://github.com/NotRexed/Hookshot/releases/latest; reopen if anything is still missing.

Fixed: the missing Kokiri leaves and grass draw again since release new-installer (the GPU culling fix). Please update with HookshotBuilder.exe from https://github.com/NotRexed/Hookshot/releases/latest; reopen if anything is still missing.
zigzagulouszagger commented 2026-11-08 17:10:55 +00:00 (Migrated from github.com)
Image Image its kinda hard to see from these screenshots, but some leaves/shrubs still despawn when u walk up to them. ( first screenshot is from further away, the leaves render properly. as you move closer to them, you see them despawning in realtime
<img width="914" height="507" alt="Image" src="https://github.com/user-attachments/assets/d554167f-121c-40a5-9a23-f1c7f891bf6b" /> <img width="1758" height="1278" alt="Image" src="https://github.com/user-attachments/assets/4b9dafa5-5b57-4bd4-9232-6ee18bf26483" /> its kinda hard to see from these screenshots, but some leaves/shrubs still despawn when u walk up to them. ( first screenshot is from further away, the leaves render properly. as you move closer to them, you see them despawning in realtime
Commenting is not possible because the repository is archived.
No milestone
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Hookshot#35
No description provided.