Idea: switch for the plain movie upscale on small GPUs (threshold on frame period, not 40 ms) #336
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#336
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The idea
A way to run the movie upscaler as the plain linear upscale (the path that is already used on AMD) on cards where the real networks are too slow, and a trigger for it that also catches laptop GPUs that are slow but not "pathologically" slow.
What I see
RTX 3050 Ti Laptop (4 GB, about 35 W), Fedora 43 (Linux build), release
foliage-linux-updater(code fromless-stutter+movie-sync'snn_video.c). Title screen and intro movie, same log in several sessions:movie-sync.Why the planned auto-switch will probably not catch this
In #109 the maintainer says the next release will notice "a movie frame over 40 ms of GPU time" and switch the movie to a plain linear upscale. A 3050 Ti Laptop sits at 30 to 35 ms: not over 40, but already about twice the 16.7 ms a 60 fps movie needs, so it would keep stuttering. Suggestion: base the threshold on the display period (for example the movie's GPU time over about 18 ms for several frames), not on a fixed 40 ms.
Also wanted: a manual switch
On NVIDIA the networks are always kept (
vk_shader.cpp: they are left out only ifmma_softwareor the vendor is not NVIDIA).RX_VK_NETWORK_KEEPcan keep networks on AMD but cannot leave them out on NVIDIA, andRX_VK_NO_F16throws for every cooperative-matrix program, the gameplay TAAU included. Something likeRX_VK_NETWORK_KEEP=none(and a row in the Insert menu, e.g. "Movie upscaler: Auto / Networks / Plain") would let players on small GPUs choose smooth over sharp.HOS_NO_MOVIES=1is not a way out, since the title screen waits on its movie (#52).Notes
Thanks for the idea. Feature requests are now collected in #1007, which lists this one with a link back here, so closing it in favour of that list (this is not a decision against the idea).