fix(menu): the Aspect ratio's move for older files skips runs with HOS_ASPECT #2541

Merged

pmwork-personal merged 1 commit from fix/aspect-hos-aspect-guard into main

2026-11-12 03:05:14 +00:00

pmwork-personal commented

2026-11-11 22:40:41 +00:00

(Migrated from github.com)

#2119's review asked for this, and it came after the merge. menu_init takes the shape the host started with as the move of an older options file's 16:9. HOS_ASPECT, a debugging switch host/hos_main.c takes instead of the options file, sets that shape too: one run with HOS_ASPECT=1.6 and an older ultrawide=0 moved the row to Monitor's shape, and the next save kept it, a choice the player never made.

What changed

gpu/vk/vk_menu.cpp menu_init: the move skips runs with HOS_ASPECT set, as hos_main.c does.
tests/test_aspect_default.py pins the condition. Without it the check fails (tried by taking the condition out).

Tested

tests/run_all.py on Windows (llvm-mingw) on main 2dfe9011: 421 passed, 33 skipped, 2 failed, both outside this change: test_vram_budget_row (fails the same on main here: clang stops on the unused kVramMinimumOnly) and test_portable_builder_startup (its dotnet publish needs packages this PC does not have).
Not run in game: it only changes what a run with the debugging switch saves.

🤖 Generated with Claude Code

#2119's review asked for this, and it came after the merge. `menu_init` takes the shape the host started with as the move of an older options file's 16:9. `HOS_ASPECT`, a debugging switch `host/hos_main.c` takes instead of the options file, sets that shape too: one run with `HOS_ASPECT=1.6` and an older `ultrawide=0` moved the row to Monitor's shape, and the next save kept it, a choice the player never made. **What changed** - `gpu/vk/vk_menu.cpp` `menu_init`: the move skips runs with `HOS_ASPECT` set, as `hos_main.c` does. - `tests/test_aspect_default.py` pins the condition. Without it the check fails (tried by taking the condition out). **Tested** - `tests/run_all.py` on Windows (llvm-mingw) on main 2dfe9011: 421 passed, 33 skipped, 2 failed, both outside this change: `test_vram_budget_row` (fails the same on main here: clang stops on the unused `kVramMinimumOnly`) and `test_portable_builder_startup` (its `dotnet publish` needs packages this PC does not have). - Not run in game: it only changes what a run with the debugging switch saves. 🤖 Generated with [Claude Code](https://claude.com/claude-code)