test: cover UTF-8 output from isolated builder children #200
No reviewers
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot!200
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/isolated-child-utf8"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Related to #180. Isolated builder children must print Unicode paths reliably on legacy Windows code pages. The UTF-8 invocation is already present in main; add its missing game-free regression and CI coverage.
The test invokes the production
run()andPYcommand with an authored child in a Han-named temporary directory. It reproduces the legacy isolated command'sUnicodeEncodeErrorwhere the Windows locale cannot encode the character, then verifies that the current UTF-8 command round-trips the output and path. Other platforms/locales still run the positive check. The source workflow runs it on Windows and Linux.Validation: passed on Windows CP1252 with Python 3.12.16 and the official builder's bundled Python 3.14.7, including the legacy negative control in both runs.
git diff --checkpasses. No product code or game assets are changed.Thanks. Holding this until the builder/toolchain change in progress lands, since the test drives make_game.run and make_game.PY, which are changing; it can be rebased on that afterwards.