fix(agent): a report keeps the job's own fields unscrubbed #76
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!76
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:fix/report-ids-unscrubbed"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
The refusal logging from #73 showed why lick's Steam Deck and Tommy's PC kept losing their runs. The farm refused every one of their reports:
report.target does not match the job. The scrubber hides the PC's host and user names everywhere in a report, including the job's own fields:steamdeck, which is also its target's tag;tommyis part of the targetwindows+tester-tommy.What changed
Report.Buildsetsjob_id,agent_id,sha,base_shaandtargetagain after the scrub, as the ticket gave them. The rest of the report is scrubbed as before.Tests
steamdeck+tester-tommy, built with a scrubber for hoststeamdeckand usertommy, keeps its target and job id.Those PCs' tries on the jobs are spent, but they start again when their app updates (#58), so the jobs come back to them by themselves.