fix(agent): a report keeps the job's own fields unscrubbed #76

Merged
HumanBean merged 1 commit from HumanBean/Beanstalk:fix/report-ids-unscrubbed into main 2026-11-16 19:55:39 +00:00
Owner

Why

The refusal logging from #73 showed why lick's Steam Deck and Tommy's PC kept losing their runs. The farm refused every one of their reports: report.target does not match the job. The scrubber hides the PC's host and user names everywhere in a report, including the job's own fields:

  • a Steam Deck's default host name is steamdeck, which is also its target's tag;
  • Tommy's PC user name tommy is part of the target windows+tester-tommy.

What changed

  • Report.Build sets job_id, agent_id, sha, base_sha and target again after the scrub, as the ticket gave them. The rest of the report is scrubbed as before.

Tests

  • New check: a report for target steamdeck+tester-tommy, built with a scrubber for host steamdeck and user tommy, keeps its target and job id.
  • Agent: 1955 checks passed; the release build has no warnings.

Those PCs' tries on the jobs are spent, but they start again when their app updates (#58), so the jobs come back to them by themselves.

## Why The refusal logging from #73 showed why lick's Steam Deck and Tommy's PC kept losing their runs. The farm refused every one of their reports: `report.target does not match the job`. The scrubber hides the PC's host and user names everywhere in a report, including the job's own fields: - a Steam Deck's default host name is `steamdeck`, which is also its target's tag; - Tommy's PC user name `tommy` is part of the target `windows+tester-tommy`. ## What changed - `Report.Build` sets `job_id`, `agent_id`, `sha`, `base_sha` and `target` again after the scrub, as the ticket gave them. The rest of the report is scrubbed as before. ## Tests - New check: a report for target `steamdeck+tester-tommy`, built with a scrubber for host `steamdeck` and user `tommy`, keeps its target and job id. - Agent: 1955 checks passed; the release build has no warnings. Those PCs' tries on the jobs are spent, but they start again when their app updates (#58), so the jobs come back to them by themselves.
fix(agent): a report keeps the job's own fields unscrubbed
Some checks are pending
CI / Coordinator tests (pull_request) Waiting to run
CI / Agent build and checks (pull_request) Waiting to run
CI / Coordinator image (pull_request) Waiting to run
CI / Conventional Commit title (pull_request) Successful in 4s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
0bb61ee3b9
The farm refused every report from lick's Steam Deck and Tommy's PC:
"report.target does not match the job". The scrubber hides the PC's host
and user names everywhere in a report, the job's own fields too: a Steam
Deck's host name is "steamdeck", its target's tag, and Tommy's PC user
name is the tester-tommy in windows+tester-tommy. Those runs (each 25-40
min) were thrown away, and before #73 the job then waited for its lease to
run out. job_id, agent_id, sha, base_sha and target are now set again
after the scrub, as the ticket gave them.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean deleted branch fix/report-ids-unscrubbed 2026-11-16 19:55:40 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Beanstalk!76
No description provided.