fix(agent): a Windows PC without Git gets the agent's own MinGit #62
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!62
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:fix/windows-mingit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
AstraLol's Windows PC (#518) failed every job at its first git command. Since #56 the farm can see why:
Windows has no git of its own. The agent needs git outside the sandbox, for the clone and the fetches, and inside it, because
dev_packs.pyasks git which files a pull request changed.What changed
MinGit: when nogit.exeis on the PATH, the agent fetches Git for Windows' MinGit, its portable command-line git, into<data>\mingit.<data>\.cache\mingit, and a stamp file means it isn't fetched again.Workspace.GitPath: the agent's owngitcommands start that git.JobPipelinemakes sure of it before a job's first fetch.HostAsyncis now anInfraExceptionnaming it, from the process start too, not only from its exit.Testing
dotnet build agent/App -c Release: 0 warnings.cmd/git.exeand no entry outside its folder.On one tester's PC every job stopped at its first git command ("An error occurred trying to start process 'git'"): Windows has no git of its own, and the agent needs it outside the sandbox (the clone, the fetches) and in it (dev_packs.py asks git what a pull request changed). When git is not on the PATH, the agent now fetches Git for Windows' MinGit 2.56.0.windows.4, pinned by size and SHA-256, into <data>\mingit, and uses it for its own git commands and on the sandbox's PATH. A git that fails to start is now an InfraException that names it. Assisted-by: Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <[email protected]>