feat: every PC takes gameplay tests, Windows included #44

Merged
HumanBean merged 1 commit from HumanBean/Beanstalk:feat/windows-gameplay-always into main 2026-11-16 02:59:59 +00:00
Owner

Why

Gameplay tests (start = "new" or "save:<name>") were a Windows opt-in, off by default: the Settings checkbox "Run gameplay tests too (early)", or windows_gameplay in policy.toml. Only 3 of the 14 Windows testers seen in the last two days had turned it on, and the planner's plans are nearly always gameplay. So most Windows PCs never took a job, and a job aimed at one of them waited for good. Tommy's PC hit exactly that on Longshot #910: "the plan needs gameplay, which this Windows PC has not turned on".

Every PC should run every test.

What changed

  • App:
    • The setting is gone: the Setup checkbox, Policy.WindowsGameplay and the scenario runner's skip.
    • The agent always sends isolated_gameplay: true and runs every start.
    • An old policy.toml's windows_gameplay is ignored. It's mentioned once and dropped from the file at the next save, like the other retired keys.
  • Planner: it no longer keeps gameplay plans off Windows (["linux"] "when gameplay matters"). A change that isn't OS-specific gets tags = [].
  • Farm: it still doesn't offer a gameplay-only plan to an older Windows app that doesn't send isolated_gameplay, because that app would skip every scenario. Its wait note now says the PC gets the job once its app updates itself (every 15 minutes since #37).
  • Default plan: the comment about Windows is gone, in both copies.
  • Docs: agent/README.md, docs/using.md, docs/protocol.md, docs/architecture.md, docs/test-plan.md and docs/deploy.md.

Only the Setup page changes on screen, where one checkbox and its hint are removed, so there are no screenshots.

Testing

  • Agent checks: 1690 passed. The tag checks now cover a Windows agent sending isolated_gameplay: true, and an old windows_gameplay line being ignored, mentioned and dropped from the file.
  • Coordinator tests: 410 passed, 1 skipped. The planner test now checks that the prompt sends gameplay to every tester.
  • dotnet build agent/App -c Release: no errors.
  • Not tested: a Windows gameplay job end to end. No Windows PC gets past building main yet (Longshot #910, #38's probe).
## Why Gameplay tests (`start = "new"` or `"save:<name>"`) were a Windows opt-in, off by default: the Settings checkbox "Run gameplay tests too (early)", or `windows_gameplay` in `policy.toml`. Only 3 of the 14 Windows testers seen in the last two days had turned it on, and the planner's plans are nearly always gameplay. So most Windows PCs never took a job, and a job aimed at one of them waited for good. Tommy's PC hit exactly that on Longshot #910: "the plan needs gameplay, which this Windows PC has not turned on". Every PC should run every test. ## What changed - **App:** - The setting is gone: the Setup checkbox, `Policy.WindowsGameplay` and the scenario runner's skip. - The agent always sends `isolated_gameplay: true` and runs every start. - An old `policy.toml`'s `windows_gameplay` is ignored. It's mentioned once and dropped from the file at the next save, like the other retired keys. - **Planner:** it no longer keeps gameplay plans off Windows (`["linux"]` "when gameplay matters"). A change that isn't OS-specific gets `tags = []`. - **Farm:** it still doesn't offer a gameplay-only plan to an older Windows app that doesn't send `isolated_gameplay`, because that app would skip every scenario. Its wait note now says the PC gets the job once its app updates itself (every 15 minutes since #37). - **Default plan:** the comment about Windows is gone, in both copies. - **Docs:** `agent/README.md`, `docs/using.md`, `docs/protocol.md`, `docs/architecture.md`, `docs/test-plan.md` and `docs/deploy.md`. Only the Setup page changes on screen, where one checkbox and its hint are removed, so there are no screenshots. ## Testing - Agent checks: 1690 passed. The tag checks now cover a Windows agent sending `isolated_gameplay: true`, and an old `windows_gameplay` line being ignored, mentioned and dropped from the file. - Coordinator tests: 410 passed, 1 skipped. The planner test now checks that the prompt sends gameplay to every tester. - `dotnet build agent/App -c Release`: no errors. - **Not tested:** a Windows gameplay job end to end. No Windows PC gets past building `main` yet (Longshot #910, #38's probe).
feat: every PC takes gameplay tests, Windows included
Some checks are pending
CI / Coordinator tests (pull_request) Waiting to run
CI / Agent build and checks (pull_request) Waiting to run
CI / Coordinator image (pull_request) Waiting to run
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 3s
91eed8c86f
Gameplay starts (start = "new" or "save:<name>") were a Windows opt-in
(Settings' "Run gameplay tests too (early)", policy's windows_gameplay),
off by default: only 3 of the 14 Windows testers seen in two days had it on,
the planner's plans are nearly always gameplay, so most Windows PCs never
took a job and a job aimed at one could wait on it for good.

The setting is gone: the agent always says isolated_gameplay and runs every
start; an old policy.toml's windows_gameplay is ignored (said once, and gone
from the file at the next save). The planner no longer keeps gameplay plans
off Windows (tags = [] for a change that isn't OS-specific). The farm keeps
its check for older Windows apps, which run only title scenarios, and its
note now says to wait for the app to update itself.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Beanstalk!44
No description provided.