feat: every PC takes gameplay tests, Windows included #44
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!44
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:feat/windows-gameplay-always"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
Gameplay tests (
start = "new"or"save:<name>") were a Windows opt-in, off by default: the Settings checkbox "Run gameplay tests too (early)", orwindows_gameplayinpolicy.toml. Only 3 of the 14 Windows testers seen in the last two days had turned it on, and the planner's plans are nearly always gameplay. So most Windows PCs never took a job, and a job aimed at one of them waited for good. Tommy's PC hit exactly that on Longshot #910: "the plan needs gameplay, which this Windows PC has not turned on".Every PC should run every test.
What changed
Policy.WindowsGameplayand the scenario runner's skip.isolated_gameplay: trueand runs every start.policy.toml'swindows_gameplayis ignored. It's mentioned once and dropped from the file at the next save, like the other retired keys.["linux"]"when gameplay matters"). A change that isn't OS-specific getstags = [].isolated_gameplay, because that app would skip every scenario. Its wait note now says the PC gets the job once its app updates itself (every 15 minutes since #37).agent/README.md,docs/using.md,docs/protocol.md,docs/architecture.md,docs/test-plan.mdanddocs/deploy.md.Only the Setup page changes on screen, where one checkbox and its hint are removed, so there are no screenshots.
Testing
isolated_gameplay: true, and an oldwindows_gameplayline being ignored, mentioned and dropped from the file.dotnet build agent/App -c Release: no errors.mainyet (Longshot #910, #38's probe).