fix(agent): a failed build's report carries its output, and Windows says where Python's temp files go #28
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!28
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:fix/build-log-tail"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why: Windows testers' jobs stop before building with
PermissionError: [WinError 5] Access is denied: '…\\Beanstalk\\work\\longshot\\tmpXXXX'(Longshot #910: rp_402f6c1a7128222f on nightly-30, and rp_20587bc9f76c5c3f on nightly-46, which has #25).TEMPfirst. It found it unusable and fell back to the working folder, the Longshot checkout, where making a folder was refused too.What changed
Workspace: keeps the last 300 lines its sandboxed commands printed (RecentOutput).JobPipelinesends them as the log tail when the build failed before any scenario ran. They go through the usual scrubber.Workspace.ProbeTempAsync(Windows only): before the base build, it runs a short Python script in the same sandbox, with the same folders, home and environment. It prints, as@@probelines:gettempdir()settles.If the probe can't run, that is logged and the build goes on.
Testing:
win-x64build compiles.Next: with the probe lines in a failed report we can fix the cause (likely the sandbox's grant or label on its home or the checkout). This PR doesn't change behaviour.