fix: the PC pause counts only failures another PC got past, and Linux finds its Python through a linked /home #130

Merged
HumanBean merged 1 commit from HumanBean/Beanstalk:fix/pause-review-fixes into main 2026-11-21 06:42:55 +00:00
Owner

#125 was merged at its first commit (4080563). Its review fixes (commit 0e3ec1cd, which my answer to BeanBot's review describes) never reached main. This change ports them:

  • The pause counts only real PC trouble. A setup failure counts toward pausing a PC only at a job that another PC got past that point. So a failure every PC has, such as a PR on a main from before Longshot #1729 failing to build on Windows, never pauses a healthy PC.
    • Reading the .nup (stage setup) counts too.
    • Network failures don't count. The agent's own exceptions, which it also marks as passing, do.
  • Bazzite: where /home is a link (/var/home), the sandbox now also shows the agent's Python at the path it's run from. The .nup couldn't be read before ("nice: '/python/bin/python3': No such file or directory").

No PC is paused right now, so the old rule hasn't caught a healthy one yet.

Tests on throwaway containers: the coordinator, 614 passed and 1 skipped; the agent checks passed. Nothing on screen changes beyond #125's pages.

🤖 Generated with Claude Code

#125 was merged at its first commit (4080563). Its review fixes (commit 0e3ec1cd, which my answer to BeanBot's review describes) never reached main. This change ports them: - **The pause counts only real PC trouble.** A setup failure counts toward pausing a PC only at a job that another PC got past that point. So a failure every PC has, such as a PR on a main from before Longshot #1729 failing to build on Windows, never pauses a healthy PC. - Reading the `.nup` (stage `setup`) counts too. - Network failures don't count. The agent's own exceptions, which it also marks as passing, do. - **Bazzite:** where `/home` is a link (`/var/home`), the sandbox now also shows the agent's Python at the path it's run from. The `.nup` couldn't be read before ("nice: '<data>/python/bin/python3': No such file or directory"). No PC is paused right now, so the old rule hasn't caught a healthy one yet. Tests on throwaway containers: the coordinator, 614 passed and 1 skipped; the agent checks passed. Nothing on screen changes beyond #125's pages. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix: the PC pause counts only failures another PC got past, and Linux finds its Python through a linked /home
Some checks failed
CI / Conventional Commit title (pull_request) Successful in 15s
CI / Workflow lint (actionlint) (pull_request) Successful in 15s
CI / Coordinator tests (pull_request) Failing after 1m19s
CI / Agent build and checks (pull_request) Successful in 44s
CI / Coordinator image (pull_request) Successful in 10s
0c24185311
#125 was merged at its first commit; these are its review fixes, which the
review comment describes and which never reached main:

- A setup failure counts toward pausing a PC only at a job another PC got past
  that point, so a failure every PC has (a PR on a main from before Longshot
  #1729 doesn't build on Windows) never pauses a healthy PC. The stage "setup"
  (the .nup) counts too; network failures don't, the agent's own exceptions
  (which it also calls passing) do.
- Linux: the sandbox shows the agent's Python at the path it is run from as
  well as its prefix: where /home is a link (Bazzite: /var/home), the .nup
  could not be read ("nice: '<data>/python/bin/python3': No such file").

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix: the PC pause counts only failures another PC got past, and Linux finds its Python through a linked /home to fix: the PC pause counts only failures another PC got past, and Linux finds its Python through a linked /home 2026-11-21 06:42:43 +00:00
HumanBean deleted branch fix/pause-review-fixes 2026-11-21 06:42:56 +00:00
Author
Owner
@review
Member

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this review is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again.


Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this review is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again. --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Beanstalk!130
No description provided.