fix(agent): Windows always uses the agent's own MinGit, never the PC's git #122
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!122
Loadingβ¦
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:fix/always-mingit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
On some Windows PCs every job stopped before its build: git in the AppContainer died at once with
fatal: could not open '/dev/null' for reading and writing: Permission denied, and the message blamed the checkout folder's permissions. git opens /dev/null (NUL) as it starts, before any command, so evengit --versiondied; the.gitfolders were readable. Three PCs in the last three days (one of Flashman4's two, dogty's, and a BigBean's scheduled run), 30 tries; every other Windows tester's git ran in the same AppContainer. The sandbox used the first git.exe on the PC's PATH, which can be anything.Workspace.EnsureGitAsync,WinHost.Git): the agent's own git commands and its sandboxes use the pinned MinGit 2.56.0.windows.4 (fetched once into<data>\mingit, its size and SHA-256 checked), never the PC's git. PCs without git already got it; now every PC does.Workspace.GitCheckWords): git that can't open /dev/null is said to fail to start in the sandbox, not blamed on the folder.Testing
Tested: in a
mcr.microsoft.com/dotnet/sdk:10.0container on the farm's server (not a tester's PC):dotnet build agent/Beanstalk.Agent.slnx -c Release -p:RestoreLockedMode=truewith 0 warnings and 0 errors, andagent/tests/test_agent_core.py --strict: 2260 checks passed (git check: 16, with a new case: git without /dev/null stops the job with "git can't start in the sandbox" and doesn't blame the folder).Still to test: Windows, after the next nightly: a job on one of the PCs that had the error builds.
π€ Generated with Claude Code
WIP: fix(agent): Windows always uses the agent's own MinGit, never the PC's gitto fix(agent): Windows always uses the agent's own MinGit, never the PC's gitPossibly related, for context: