feat(coordinator): one BigBean's approval is enough, and the results come below it #119
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Beanstalk!119
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Beanstalk:feat/one-approval"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Removes the rule that a diff touching
nx2/,CMakeLists.txt,*.cmake,tools.lock,.farm/,.forgejo/or Longshot's dev scripts needs two BigBeans, and that a manual run of such a PR head waits for a second one (seen on Longshot #1880: "This diff touches sensitive paths, so a second member ofBigBeansmust approve it too").The rule protected nothing the sandbox doesn't:
Workspace: only git and the tool download run outside, and they run nothing from the repository);tools.lockonly, never the PR's;scheduler.NO_SANDBOX);.cppchange already runs as much of the PR's code on testers' PCs.Changes:
trust.tier_for(approvers): one approver isreviewed, twodouble-reviewed;is_sensitive/sensitive_pathsare gone.beanstalk/approval, the state label and the dashboard no longer say "needs a second approval"; the dashboard's approve-only outcome goes.awaiting_approvalstate, noPOST /api/v1/runs/{id}/approve, noapprovalfield. No run in production ever waited for one, and Tooling'sfarm_run.pynever called it.regression.py's "not on main: no run" went too: it was this rule'sneeds_approval(it fired only off main and on sensitive files).commits.sensitiveandruns.needs_approvalstay in the schema, unused, so an older image can still run on the database.Also, the results come below the approval (Longshot #1860 had them edited into a comment from 08:18, far up the thread): a new approval deletes a sticky comment that shows no run yet (
reporter.sticky_to_bottom, fromcommands.start), soupdate_prposts the results in a new comment under it. One that can't be deleted is edited to say the results are below. A comment that shows a run is left to_sticky, which already folds it and posts a new one per run.Testing
Tested: the coordinator suite in a python:3.13-alpine container with Postgres 17 (on the farm's server, not a tester): 587 passed, 3 failed, 1 skipped (with
test_the_results_come_below_the_approval). The 3 failures (test_regression.py:test_tools_lock_starts_the_chain_again,test_superseded_and_announced,test_tick_waits_its_hours) fail the same way on main @d7101761. Main also failstest_target_cell_names_what_each_report_ran_on(#117 removedreporter._hardware), which this branch fixes.Still to test: after deploy,
@Beanstalkon Longshot #1880 starts it with one approval.🤖 Generated with Claude Code
The rule that a diff touching nx2/, CMakeLists.txt, *.cmake, tools.lock, .farm/, .forgejo/ or Longshot's dev scripts needs two BigBeans (and that a manual run of such a PR head waits for a second one) is gone. It protected nothing the sandbox doesn't: every command from Longshot (the build scripts, the translator, the game) runs in a tester's sandbox, the tools come only from main's tools.lock, and a tester without a sandbox gets no job. Any .cpp change runs just as much of the PR's code on testers' PCs. - trust.tier_for takes only the approvers; is_sensitive/sensitive_paths go. - The PR comment, beanstalk/approval, the state label and the dashboard no longer say "needs a second approval"; the dashboard's approve-only outcome goes. - Manual runs: no awaiting_approval state, no POST /api/v1/runs/{id}/approve (no run ever waited for one), no approval field; jobs are reviewed with the requester as approver. - The commits.sensitive and runs.needs_approval columns stay (unused) so an older image can still run on the database. - regression.py's "not on main: no run" was this rule's needs_approval in disguise (it fired only off main AND on sensitive files): it goes with it. - test_reports: #117 removed reporter._hardware; its test now checks _hardware_line, as main's suite failed there. Assisted-by: Claude Code Co-Authored-By: Claude Opus 5.5 <[email protected]>WIP: feat(coordinator): one BigBean's approval is enough, whatever the diff touchesto WIP: feat(coordinator): one BigBean's approval is enough, and the results come below it6ca8aa903376d2eefa9bWIP: feat(coordinator): one BigBean's approval is enough, and the results come below itto feat(coordinator): one BigBean's approval is enough, and the results come below it76d2eefa9bf9689b38cc