fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they check #27
No reviewers
Labels
No labels
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Tooling!27
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Tooling:fix/release-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The launcher's CI runs this repository's
tests/test_release.py(at its.tooling-rev), and three of the tests failed onmain. That's why the launcher's Compile and test has failed on every push.check_tag(bug): it left the tag itself out of the releases the tag must be above (t != tag). Socheck-tagpassed a tag whose release was already published, though its docstring says it refuses a tag "not above every release there is", and a release's files never change. Now a published release with the same tag refuses it. A draft (a failed run's) still doesn't, becausecheck-tagonly lists published releases. This fixestest_check_tag_against_the_published_releases.test_the_bump: after taggingv4.0.0, it expected a breaking change to needv4.0.0. Withv4.0.0as the last stable, it needsv5.0.0.test_the_next_stable: it checkedv3.0.1without tagging it, so it got "no tag here" instead of the check it means.Testing
Tested:
LAUNCHER=<launcher checkout> python3 -I -B tests/test_release.pyon Linux: 42 tests OK. Onmainthe same run failed these 3.Still to test: none. The launcher's CI runs this once its
.tooling-revmoves here.Risks
A tag push whose release is already published now stops at the version step instead of building again. Releases that aren't published yet (drafts) are unaffected.
🤖 Generated with Claude Code
WIP: fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they checkto fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they check