fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they check #27

Merged
HumanBean merged 1 commit from HumanBean/Tooling:fix/release-tests into main 2026-11-21 21:50:22 +00:00
Owner

Summary

The launcher's CI runs this repository's tests/test_release.py (at its .tooling-rev), and three of the tests failed on main. That's why the launcher's Compile and test has failed on every push.

  • check_tag (bug): it left the tag itself out of the releases the tag must be above (t != tag). So check-tag passed a tag whose release was already published, though its docstring says it refuses a tag "not above every release there is", and a release's files never change. Now a published release with the same tag refuses it. A draft (a failed run's) still doesn't, because check-tag only lists published releases. This fixes test_check_tag_against_the_published_releases.
  • test_the_bump: after tagging v4.0.0, it expected a breaking change to need v4.0.0. With v4.0.0 as the last stable, it needs v5.0.0.
  • test_the_next_stable: it checked v3.0.1 without tagging it, so it got "no tag here" instead of the check it means.

Testing

Tested: LAUNCHER=<launcher checkout> python3 -I -B tests/test_release.py on Linux: 42 tests OK. On main the same run failed these 3.

Still to test: none. The launcher's CI runs this once its .tooling-rev moves here.

Risks

A tag push whose release is already published now stops at the version step instead of building again. Releases that aren't published yet (drafts) are unaffected.

🤖 Generated with Claude Code

## Summary The launcher's CI runs this repository's `tests/test_release.py` (at its `.tooling-rev`), and three of the tests failed on `main`. That's why the launcher's *Compile and test* has failed on every push. - **`check_tag` (bug):** it left the tag itself out of the releases the tag must be above (`t != tag`). So `check-tag` passed a tag whose release was already published, though its docstring says it refuses a tag "not above every release there is", and a release's files never change. Now a published release with the same tag refuses it. A draft (a failed run's) still doesn't, because `check-tag` only lists published releases. This fixes `test_check_tag_against_the_published_releases`. - **`test_the_bump`:** after tagging `v4.0.0`, it expected a breaking change to need `v4.0.0`. With `v4.0.0` as the last stable, it needs `v5.0.0`. - **`test_the_next_stable`:** it checked `v3.0.1` without tagging it, so it got "no tag here" instead of the check it means. ## Testing **Tested:** `LAUNCHER=<launcher checkout> python3 -I -B tests/test_release.py` on Linux: 42 tests OK. On `main` the same run failed these 3. **Still to test:** none. The launcher's CI runs this once its `.tooling-rev` moves here. ## Risks A tag push whose release is already published now stops at the version step instead of building again. Releases that aren't published yet (drafts) are unaffected. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
check_tag left the tag itself out of the releases it must be above, so a tag whose release was
already published passed again, though its docstring (and the test) say it refuses a tag that is
not above every release there is: a release's files never change.

The bump test expected a breaking change after its v4.0.0 tag to need v4.0.0 (v5.0.0: v4.0.0 is
the last stable then), and the next-stable test checked a v3.0.1 it never tagged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they check to fix(release): check-tag refuses a tag whose own release is published, and the release tests' tags match what they check 2026-11-21 21:45:41 +00:00
HumanBean deleted branch fix/release-tests 2026-11-21 21:50:22 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Tooling!27
No description provided.