Linux: save backups are split between two folders, and the launcher lists only one #188
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher#188
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
On Linux and the Steam Deck, save backups end up in two different folders, and the launcher only knows one of them. A player who needs a backup back (the restore list coming in #182, or by hand following docs/saves.md) doesn't see the ones in the other folder, and may think they're gone.
Where each one writes on Linux
$XDG_DATA_HOME/longshot/save-backup/(default~/.local/share/longshot/save-backup/)$XDG_DATA_HOME/oot-save-backups/scripts/longshot_saves.py(itsbackup_root())$XDG_DATA_HOME/oot-save-backups/$XDG_DATA_HOME/oot-save-backups/Windows has no such split: every writer uses
%LOCALAPPDATA%\Longshot\oot-save-backups. A portable launcher keeps its ownLongshotLauncher-data/save-backups/.The launcher reads only
Saves.BackupRoot, which on Linux islongshot/save-backup(Core/Saves.cs). Its comment says the script's and the launcher's backups are in one place, which is only true on Windows. Found in HumanBean's review of #182: #182 (comment)What fixes it
longshot/save-backupand the olderoot-save-backups), so backups made by the script, by a launcher from before #80, or by the game are found and can be restored. New launcher backups keep going tolongshot/save-backup. docs/saves.md says where each kind is.scripts/longshot_saves.py's default backup root becomes$XDG_DATA_HOME/longshot/save-backup, and #1428's game backups use the same folder, so there is one place again. Older backups stay where they are, and the launcher still lists them through (1).Nothing is moved or deleted: old backups stay where they are.
Possibly related, for context:
Longshot's side: MagicBeanDev/Longshot#1473 (ready) makes the save script back up into
$XDG_DATA_HOME/longshot/save-backupon Linux, the launcher's folder; older backups stay inoot-save-backups. Asked on MagicBeanDev/Longshot#1428 for the game's backups to use the same folder. Still to do here: the launcher listing the oldoot-save-backupsfolder too.The launcher's part is on main: listing the older Linux folder (oot-save-backups) beside longshot/save-backup came in with #184's merge (
00086cc), as #190 was stacked under it (#190 closed as included). Still open: Longshot's script part, MagicBeanDev/Longshot#1473.