WIP: fix(vk): an event signal's add writes the value the stream gives the event #772

Draft

dyst wants to merge 1 commit from dyst/Longshot:fix/event-signal-add into main

pull from: dyst/Longshot:fix/event-signal-add

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 4 Commits 1 Files changed 2 +172 -14

dyst commented 2026-11-15 11:19:41 +00:00

Member

• Copy link
• Copy Markdown

Type: fix · Risk: low · Tested on: Windows 11 (the game-free checks only; no game run) · Needs: a game run, any OS and GPU

Why

When the GPU signals an event by adding to its value (NVN's ADD mode), the renderer wrote the wrong number into the event: it added to what the event held in the game's memory, which doesn't yet have the earlier signals of the same recording. Two adds in a row wrote the same value, and an add after a set added to the value before the set. The renderer's own waits were not affected (they keep the right value), but the game's reads of the event (nvnEventGetValue) saw fewer signals than were made, which can hold a thread that waits for the count or let it go early.

In Ocarina of Time this probably doesn't happen: in 133 run logs on this PC, all 200 sampled GPU event signals are SET, none ADD. The fix is for correctness where ADD is used. Found by reading the replay. The tracker has no issue for it (forge.py issue list, pr list: nothing on event signals).

How to reproduce

Seen on: not seen in the game; reproduced by the new game-free check
Settings and switches: defaults
Steps: python -I -B tests/test_event_signal_add.py against main's gpu/vk/vk_replay.cpp: two adds of 1 from 5, a set of 10 and an add of 5 in one recording
Expected: the GPU writes 6, 7, 10, 15
Actual: main writes 6, 6, 10, 10 (serial replay, and the parallel replay's workers alike)

What changed

An event signal's GPU write now takes the value the replay already keeps for the event in stream order, instead of guest memory's value plus the add. The parallel replay's workers, which don't keep those values, take each signal's value from the dry pass, the same way they take the render conditions' results. SET signals write exactly what they wrote before.

• replay: NOP_SIGNAL_EVENT in replay() (gpu/vk/vk_replay.cpp) writes ev_values[e.gpu]; the dry pass records each signal's value in par_signals, which ParPoint and Segment carry as sig to record_segment (sig_at), beside par_conds / cond_at. A worker with no value from the dry pass falls back to the old add.
• tests: tests/test_event_signal_add.py compiles the real NOP_SIGNAL_EVENT case in a stub replay loop and runs it serially, as a dry pass, as a worker, and as a worker starting at a later segment.

Measurements

Verdict: nothing to measure for speed: the change only alters the value an ADD signal writes (one map lookup it already made). The new check fails on main and passes here.

Flags and settings

None.

Testing

Tested: Windows 11 (llvm-mingw from the builder, v2.0.14 tools):

• Rebased onto main @ 7bacf846 (this PR @ 77d41719): the 94 checks that read this diff (listed below), not the whole suite, through tests/run_all.py --jobs 6 on Windows 11 with the Builder's llvm-mingw (v2.0.14 tools): 76 passed, 4 failed, 14 skipped for want of the Vulkan headers; those 14 again with RX_CPM set to the Builder's CPM cache: all 14 pass (test_event_signal_add among the 76). The 4 failures also fail on main: test_readback_late and test_walk_key on main @ 1310ecc6 (the full suite there: 500 passed, 17 failed, 79 skipped); test_readback_wait_bounded and test_vk_occlusion_queries on main @ 7bacf846, with the same message.

  The 94 checks

  • nx2/test_timeline_modes.py
  • tests/test_antilag.py
  • tests/test_audio_mono.py
  • tests/test_audio_volume.py
  • tests/test_auto_settings.py
  • tests/test_bank_gen.py
  • tests/test_bug_report.py
  • tests/test_camera_speed.py
  • tests/test_capture_dimensions.py
  • tests/test_capture_readback_visibility.py
  • tests/test_capture_resources.py
  • tests/test_capture_slot_ownership.py
  • tests/test_crash_record.py
  • tests/test_dev_packs.py
  • tests/test_device_lost_exit.py
  • tests/test_draw_stream_visibility.py
  • tests/test_drawn_page_map.py
  • tests/test_dump_readback.py
  • tests/test_event_signal_add.py
  • tests/test_flash_sampling.py
  • tests/test_flush_nothing_held.py
  • tests/test_fps_stats.py
  • tests/test_frame_log_headless.py
  • tests/test_frame_trace_waits.py
  • tests/test_frame_wait_bounds.py
  • tests/test_framelog_clock.py
  • tests/test_framelog_sink.py
  • tests/test_fsr_image_retirement.py
  • tests/test_fsr_uniform_ownership.py
  • tests/test_gpl_cold_library.py
  • tests/test_gpu_hang_watch.py
  • tests/test_gpu_wait_stats.py
  • tests/test_hdr_encode.py
  • tests/test_hold_gpu.py
  • tests/test_inline_write_order.py
  • tests/test_input_background.py
  • tests/test_late_fix_build.py
  • tests/test_load_default.py
  • tests/test_longshot_ctl.py
  • tests/test_menu_keys.py
  • tests/test_met_wait_capture.py
  • tests/test_mouse_settings.py
  • tests/test_oot_damage.py
  • tests/test_oot_fov.py
  • tests/test_opening_skip.py
  • tests/test_option_ids.py
  • tests/test_parallel_dry_marks.py
  • tests/test_parallel_init_order.py
  • tests/test_parallel_rb_refresh.py
  • tests/test_parallel_small_cb.py
  • tests/test_png_publication.py
  • tests/test_present_ahead.py
  • tests/test_present_aspect.py
  • tests/test_present_aspect_vulkan.py
  • tests/test_present_device_loss.py
  • tests/test_present_geometry_trace.py
  • tests/test_present_semaphores.py
  • tests/test_present_source_crop.py
  • tests/test_present_thread.py
  • tests/test_readback_late.py
  • tests/test_readback_part.py
  • tests/test_readback_settle.py
  • tests/test_readback_wait_bounded.py
  • tests/test_recorded_wait_flush.py
  • tests/test_recorder_own_idle.py
  • tests/test_registration_host_copies.py
  • tests/test_replay_copies.py
  • tests/test_reserved_core.py
  • tests/test_rumble_menu.py
  • tests/test_same_bind.py
  • tests/test_scene_format.py
  • tests/test_skip_title.py
  • tests/test_slow_frame_limit.py
  • tests/test_sparse_mirror.py
  • tests/test_split_before_draw.py
  • tests/test_split_ub_flush.py
  • tests/test_status_line.py
  • tests/test_stick_dead_zone.py
  • tests/test_temporal_jitter.py
  • tests/test_text_size.py
  • tests/test_text_speed.py
  • tests/test_threaded_rendering.py
  • tests/test_ub_gap.py
  • tests/test_ub_memo.py
  • tests/test_ub_threads.py
  • tests/test_ub_word_index.py
  • tests/test_upscale_independent.py
  • tests/test_upscaler_rows.py
  • tests/test_value_rec_last_part.py
  • tests/test_vk_occlusion_queries.py
  • tests/test_vsync_row.py
  • tests/test_walk_key.py
  • tests/test_wb_diff_cpu_writes.py
  • tests/test_wb_learn.py

• tests/test_event_signal_add.py passes on this branch and fails on main @ aa95d35f (output above).

• gpu/vk/vk_replay.cpp compiles (-fsyntax-only) with the renderer's flags and the CPM Vulkan, SPIR-V and VMA headers.

• python -I -B tests/run_all.py on this branch and on main @ aa95d35f, same PC and environment: 497 passed, 19 failed, 78 skipped here; 496 passed, 19 failed, 78 skipped on main. The only difference is the new check. The 19 fail on main too, on this PC (among them test_env_on, which flags main's RX_VK_PRESENT_AFTER_SIGNAL read at vk_replay.cpp:5794): test_appimage_player_build.py, test_bake_portability.py, test_cpm_discovery.py, test_cpp_preflight.py, test_crash_dialog.py, test_env_on.py, test_fpx_sticky.py, test_lift_cleanup_error.py, test_linux_preflight.py, test_make_game_cache.py, test_make_game_prepare.py, test_missing_nup.py, test_oot_state_tap.py, test_options_budget_once.py, test_readback_late.py, test_spawn_emit.py, test_tested_configurations.py, test_vk_pgo.py, test_walk_key.py.

Not tested: the game. No build was made; this PC's builds were not used for this change. The parallel replay's segments (RX_VK_PARALLEL) and the render thread are covered by the game-free check only.

Must be tested:

• Any OS and GPU, with the defaults and once with RX_VK_PARALLEL=4: load a save in Kokiri Forest and play two minutes, expecting the same picture and frame rate as main and no new vk: a wait not met in replay order lines in the log (Test Farm: @Beanstalk any, Kokiri Forest two minutes with defaults and with RX_VK_PARALLEL=4, compare the log's wait lines with main)

Risks

What could break: the parallel replay's workers indexing the wrong signal (a segment starting at the wrong sig): an event would get another signal's value and a queue could wait too long or go on early. SET signals, the only kind seen in this game, write the same value as before in every mode.

Turning it off: revert the commit.

Compatibility: Nothing changes: no caches, settings or vk ABI involved.

Checklist

Everyone

• One topic.
• The title is a Conventional Commit (type(scope): description) of the status line's type.
• Why gives the reason plainly and links the issues that fit (the tracker searched).
• Measurements has a verdict, or one line saying why there is nothing to measure.
• Testing names what was tested, what wasn't, and what must still be tested, where and how.
• Rebased on current main.
• python -I -B tests/run_all.py passes (any failure that also fails on main is named).
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• A game-free test added for the fix, failing on main and passing here.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11 (the game-free checks only; no game run) · **Needs:** a game run, any OS and GPU ## Why When the GPU signals an event by adding to its value (NVN's ADD mode), the renderer wrote the wrong number into the event: it added to what the event held in the game's memory, which doesn't yet have the earlier signals of the same recording. Two adds in a row wrote the same value, and an add after a set added to the value before the set. The renderer's own waits were not affected (they keep the right value), but the game's reads of the event (`nvnEventGetValue`) saw fewer signals than were made, which can hold a thread that waits for the count or let it go early. In Ocarina of Time this probably doesn't happen: in 133 run logs on this PC, all 200 sampled GPU event signals are SET, none ADD. The fix is for correctness where ADD is used. Found by reading the replay. The tracker has no issue for it (`forge.py issue list`, `pr list`: nothing on event signals). ## How to reproduce **Seen on:** not seen in the game; reproduced by the new game-free check **Settings and switches:** defaults **Steps:** `python -I -B tests/test_event_signal_add.py` against main's `gpu/vk/vk_replay.cpp`: two adds of 1 from 5, a set of 10 and an add of 5 in one recording **Expected:** the GPU writes 6, 7, 10, 15 **Actual:** main writes 6, 6, 10, 10 (serial replay, and the parallel replay's workers alike) ## What changed An event signal's GPU write now takes the value the replay already keeps for the event in stream order, instead of guest memory's value plus the add. The parallel replay's workers, which don't keep those values, take each signal's value from the dry pass, the same way they take the render conditions' results. SET signals write exactly what they wrote before. - replay: `NOP_SIGNAL_EVENT` in `replay()` (`gpu/vk/vk_replay.cpp`) writes `ev_values[e.gpu]`; the dry pass records each signal's value in `par_signals`, which `ParPoint` and `Segment` carry as `sig` to `record_segment` (`sig_at`), beside `par_conds` / `cond_at`. A worker with no value from the dry pass falls back to the old add. - tests: `tests/test_event_signal_add.py` compiles the real `NOP_SIGNAL_EVENT` case in a stub replay loop and runs it serially, as a dry pass, as a worker, and as a worker starting at a later segment. ## Measurements **Verdict:** nothing to measure for speed: the change only alters the value an ADD signal writes (one map lookup it already made). The new check fails on main and passes here. ### Flags and settings None. ## Testing **Tested:** Windows 11 (llvm-mingw from the builder, v2.0.14 tools): - Rebased onto `main` @ 7bacf846 (this PR @ 77d41719): the 94 checks that read this diff (listed below), not the whole suite, through `tests/run_all.py --jobs 6` on Windows 11 with the Builder's llvm-mingw (v2.0.14 tools): 76 passed, 4 failed, 14 skipped for want of the Vulkan headers; those 14 again with `RX_CPM` set to the Builder's CPM cache: all 14 pass (`test_event_signal_add` among the 76). The 4 failures also fail on main: `test_readback_late` and `test_walk_key` on main @ 1310ecc6 (the full suite there: 500 passed, 17 failed, 79 skipped); `test_readback_wait_bounded` and `test_vk_occlusion_queries` on main @ 7bacf846, with the same message. <details><summary>The 94 checks</summary> - `nx2/test_timeline_modes.py` - `tests/test_antilag.py` - `tests/test_audio_mono.py` - `tests/test_audio_volume.py` - `tests/test_auto_settings.py` - `tests/test_bank_gen.py` - `tests/test_bug_report.py` - `tests/test_camera_speed.py` - `tests/test_capture_dimensions.py` - `tests/test_capture_readback_visibility.py` - `tests/test_capture_resources.py` - `tests/test_capture_slot_ownership.py` - `tests/test_crash_record.py` - `tests/test_dev_packs.py` - `tests/test_device_lost_exit.py` - `tests/test_draw_stream_visibility.py` - `tests/test_drawn_page_map.py` - `tests/test_dump_readback.py` - `tests/test_event_signal_add.py` - `tests/test_flash_sampling.py` - `tests/test_flush_nothing_held.py` - `tests/test_fps_stats.py` - `tests/test_frame_log_headless.py` - `tests/test_frame_trace_waits.py` - `tests/test_frame_wait_bounds.py` - `tests/test_framelog_clock.py` - `tests/test_framelog_sink.py` - `tests/test_fsr_image_retirement.py` - `tests/test_fsr_uniform_ownership.py` - `tests/test_gpl_cold_library.py` - `tests/test_gpu_hang_watch.py` - `tests/test_gpu_wait_stats.py` - `tests/test_hdr_encode.py` - `tests/test_hold_gpu.py` - `tests/test_inline_write_order.py` - `tests/test_input_background.py` - `tests/test_late_fix_build.py` - `tests/test_load_default.py` - `tests/test_longshot_ctl.py` - `tests/test_menu_keys.py` - `tests/test_met_wait_capture.py` - `tests/test_mouse_settings.py` - `tests/test_oot_damage.py` - `tests/test_oot_fov.py` - `tests/test_opening_skip.py` - `tests/test_option_ids.py` - `tests/test_parallel_dry_marks.py` - `tests/test_parallel_init_order.py` - `tests/test_parallel_rb_refresh.py` - `tests/test_parallel_small_cb.py` - `tests/test_png_publication.py` - `tests/test_present_ahead.py` - `tests/test_present_aspect.py` - `tests/test_present_aspect_vulkan.py` - `tests/test_present_device_loss.py` - `tests/test_present_geometry_trace.py` - `tests/test_present_semaphores.py` - `tests/test_present_source_crop.py` - `tests/test_present_thread.py` - `tests/test_readback_late.py` - `tests/test_readback_part.py` - `tests/test_readback_settle.py` - `tests/test_readback_wait_bounded.py` - `tests/test_recorded_wait_flush.py` - `tests/test_recorder_own_idle.py` - `tests/test_registration_host_copies.py` - `tests/test_replay_copies.py` - `tests/test_reserved_core.py` - `tests/test_rumble_menu.py` - `tests/test_same_bind.py` - `tests/test_scene_format.py` - `tests/test_skip_title.py` - `tests/test_slow_frame_limit.py` - `tests/test_sparse_mirror.py` - `tests/test_split_before_draw.py` - `tests/test_split_ub_flush.py` - `tests/test_status_line.py` - `tests/test_stick_dead_zone.py` - `tests/test_temporal_jitter.py` - `tests/test_text_size.py` - `tests/test_text_speed.py` - `tests/test_threaded_rendering.py` - `tests/test_ub_gap.py` - `tests/test_ub_memo.py` - `tests/test_ub_threads.py` - `tests/test_ub_word_index.py` - `tests/test_upscale_independent.py` - `tests/test_upscaler_rows.py` - `tests/test_value_rec_last_part.py` - `tests/test_vk_occlusion_queries.py` - `tests/test_vsync_row.py` - `tests/test_walk_key.py` - `tests/test_wb_diff_cpu_writes.py` - `tests/test_wb_learn.py` </details> - `tests/test_event_signal_add.py` passes on this branch and fails on main @ aa95d35f (output above). - `gpu/vk/vk_replay.cpp` compiles (`-fsyntax-only`) with the renderer's flags and the CPM Vulkan, SPIR-V and VMA headers. - `python -I -B tests/run_all.py` on this branch and on main @ aa95d35f, same PC and environment: 497 passed, 19 failed, 78 skipped here; 496 passed, 19 failed, 78 skipped on main. The only difference is the new check. The 19 fail on main too, on this PC (among them `test_env_on`, which flags main's `RX_VK_PRESENT_AFTER_SIGNAL` read at `vk_replay.cpp:5794`): `test_appimage_player_build.py`, `test_bake_portability.py`, `test_cpm_discovery.py`, `test_cpp_preflight.py`, `test_crash_dialog.py`, `test_env_on.py`, `test_fpx_sticky.py`, `test_lift_cleanup_error.py`, `test_linux_preflight.py`, `test_make_game_cache.py`, `test_make_game_prepare.py`, `test_missing_nup.py`, `test_oot_state_tap.py`, `test_options_budget_once.py`, `test_readback_late.py`, `test_spawn_emit.py`, `test_tested_configurations.py`, `test_vk_pgo.py`, `test_walk_key.py`. **Not tested:** the game. No build was made; this PC's builds were not used for this change. The parallel replay's segments (`RX_VK_PARALLEL`) and the render thread are covered by the game-free check only. **Must be tested:** - Any OS and GPU, with the defaults and once with `RX_VK_PARALLEL=4`: load a save in Kokiri Forest and play two minutes, expecting the same picture and frame rate as main and no new `vk: a wait not met in replay order` lines in the log (Test Farm: @Beanstalk any, Kokiri Forest two minutes with defaults and with RX_VK_PARALLEL=4, compare the log's wait lines with main) ## Risks **What could break:** the parallel replay's workers indexing the wrong signal (a segment starting at the wrong `sig`): an event would get another signal's value and a queue could wait too long or go on early. SET signals, the only kind seen in this game, write the same value as before in every mode. **Turning it off:** revert the commit. **Compatibility:** Nothing changes: no caches, settings or vk ABI involved. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

dyst added 1 commit 2026-11-15 11:19:42 +00:00

fix(vk): an event signal's add writes the value the stream gives the event ... 2c5a62e56d

The replay keeps each event's value in stream order (ev_values) for the GPU's waits, but the GPU write of an
NVN_EVENT_SIGNAL_MODE_ADD signal took guest memory's value plus the add. Guest memory does not have the writes of the
signals before it while their recording has not run on the GPU, so two adds in one recording wrote the same value, and
an add after a set added to the value before the set: the game's nvnEventGetValue saw fewer adds than the stream made.

The GPU write now takes the value from ev_values. The parallel replay's workers, which do not keep ev_values, take each
signal's value from the dry pass in stream order (par_signals, carried by ParPoint and Segment as sig), as they take
the render conditions' results. SET signals write what they wrote before.

tests/test_event_signal_add.py compiles the real NOP_SIGNAL_EVENT case and replays adds and a set serially and as a
dry pass and a worker: main writes 6 6 10 10 where the stream makes 6 7 10 15.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

dyst commented 2026-11-15 11:19:53 +00:00

Author

Member

• Copy link
• Copy Markdown

@Beanstalk any OS and GPU: load a save in Kokiri Forest and play two minutes, once with the defaults and once with RX_VK_PARALLEL=4, on this PR and on main. Expected: the same picture and frame rate as main, and no new 'vk: a wait not met in replay order' lines in longshot_log.txt. SET signals (all this game uses) write the same values as before, so nothing should change on screen.

@Beanstalk any OS and GPU: load a save in Kokiri Forest and play two minutes, once with the defaults and once with RX_VK_PARALLEL=4, on this PR and on main. Expected: the same picture and frame rate as main, and no new 'vk: a wait not met in replay order' lines in longshot_log.txt. SET signals (all this game uses) write the same values as before, so nothing should change on screen.

👀 1

Beanstalk commented 2026-11-15 11:19:55 +00:00

Member

• Copy link
• Copy Markdown

Beanstalk test farm

Commit 77d4171 · tier untrusted · approved by nobody yet · dashboard

A member of BigBeans can review this commit and comment @Beanstalk to test it.

<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `77d4171` · tier **untrusted** · approved by nobody yet · [dashboard](https://beanstalk.magicbean.dev/prs/772) A member of `BigBeans` can review this commit and comment `@Beanstalk` to test it.

Beanstalk added the

beanstalk: approved @ 2c5a62e

label 2026-11-15 11:20:13 +00:00

mooki added the

area/renderer

kind

bug

platform/linux

platform/windows

priority

high

labels 2026-11-15 13:59:37 +00:00

dyst commented 2026-11-15 14:56:48 +00:00

Author

Member

• Copy link
• Copy Markdown

The farm's first run (rp_20b7db7482e51065, Linux RTX 4070) judged no scenario: 'a step ran out of time: timeout: the game did not read the controller', on main and on this PR alike, before any measurement, so it says nothing about the change either way. @Beanstalk once more, please: the same plan (Kokiri Forest two minutes, defaults and RX_VK_PARALLEL=4, this PR against main).

The farm's first run (rp_20b7db7482e51065, Linux RTX 4070) judged no scenario: 'a step ran out of time: timeout: the game did not read the controller', on main and on this PR alike, before any measurement, so it says nothing about the change either way. @Beanstalk once more, please: the same plan (Kokiri Forest two minutes, defaults and RX_VK_PARALLEL=4, this PR against main).

👀 1

jabbaxipil referenced this pull request from MagicBeanDev/Beanstalk 2026-11-15 17:48:32 +00:00

agent: loading a save gives up after one 30 s press while the game is still building its pipelines #10

dyst force-pushed fix/event-signal-add from 2c5a62e56d to 77d417195d 2026-11-15 19:04:11 +00:00 Compare

Beanstalk removed the

beanstalk: approved @ 2c5a62e

label 2026-11-15 19:04:13 +00:00

dyst commented 2026-11-15 19:17:00 +00:00

Author

Member

• Copy link
• Copy Markdown

Rebased onto main @ 7bacf846 (this PR @ 77d41719). The 94 checks that read this diff: 4 fail, each also on main (2 @ 1310ecc6, 2 @ 7bacf846); test_event_signal_add passes. No change to the code. Still WIP for the Test Farm rerun.

Rebased onto main @ 7bacf846 (this PR @ 77d41719). The 94 checks that read this diff: 4 fail, each also on main (2 @ 1310ecc6, 2 @ 7bacf846); test_event_signal_add passes. No change to the code. Still WIP for the Test Farm rerun.

Some checks failed

Hide checks

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped

Details

Third-party parts / The same as upstream (pull_request) Has been skipped

Details

Website / Website on Cloudflare (pull_request) Has been skipped

Details

beanstalk/approval not approved yet

Details

CI / Conventional Commit title (pull_request) Successful in 3s

Details

CI / Workflow lint (actionlint) (pull_request) Successful in 5s

Details

Guide screenshots / Guide images and local UI source review (pull_request) Failing after 5s

Details

Third-party parts / As their notes say (pull_request) Successful in 7s

Details

PR description / Description follows the template (pull_request_target) Successful in 4s

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix/event-signal-add:dyst-fix/event-signal-add'

git switch 'dyst-fix/event-signal-add'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/tooling

Developer tools: scripts, CI, build and release tooling

  

area/upscaling

DLSS, FSR, frame generation

  

beanstalk: approved @ 1697603

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 2c5a62e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 4fd82b7

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 64d6d09

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 6f91fae

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 70a78f9

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8015c9a

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 8d361dc

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ 9d8356e

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ abf2227

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ d82f202

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ e5f1e40

Set by Beanstalk for show; the farm's database is what counts

  

beanstalk: approved @ ee8ab5f

Set by Beanstalk for show; the farm's database is what counts

  

ci: approved

A maintainer approved CircleCI for this fork PR (sticky; removed after 14 quiet days)

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Affects Linux (a change for every system carries both Windows and Linux)

  

platform/macos

macOS (Apple silicon or Intel Macs)

  

platform/steam-deck

Steam Deck

  

platform/windows

Affects Windows (a change for every system carries both Windows and Linux)

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

regression

Worked in an earlier build, broken in a newer one: highest priority, above other bugs

  

risk

high

Broad or core change: the renderer, defaults on many systems, saves, installs, security

  

risk

low

Small, contained change: little can break

  

risk

medium

Changes behaviour in one area, or a default on some systems

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

  

ci: approved

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/tooling

area/upscaling

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8015c9a

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

ci: approved

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/macos

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

regression

risk

high

risk

low

risk

medium

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

ci: approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!772

No description provided.