test(release): reuse accepted Windows fixture fixes #86

Merged
HumanBean merged 1 commit from Anarkkie/LongshotLauncher:fix/windows-release-tests into main 2026-11-15 08:06:51 +00:00
Contributor

Windows release checks fail because the Unix command stub cannot run and text-mode checksum fixtures change the signed/uploaded bytes. This ports Yeetbot90's accepted Longshot PR255 to the launcher.

Only tests/test_release.py changes, matching accepted commit 01af760 exactly: a Windows-compatible git-cliff stub, its Unicode-path regression, and byte-exact checksum fixtures. Existing assertions, production release code and trusted keys are unchanged.

Tested at 50e3e8b (base 4bab213):

Check Before After
Windows release suite 1 failure, 5 errors / 28 tests 29 passed
Windows, accented/spaced temporary path — 29 passed
Linux release suite 28 passed 29 passed
Windows strict launcher core — 1,024 passed
Locked Release build — 0 warnings/errors

Windows 11: Python 3.14, OpenSSL 3.5.9. Linux: Ubuntu 24.04, Python 3.12.3, OpenSSL 3.0.13. Commands: python -I -B tests/test_release.py -v, python -I -B tests/test_launcher_core.py --strict --longshot <game-source>, and dotnet build LongshotLauncher.slnx -c Release -p:RestoreLockedMode=true.

Final check against main 1fba5f3: clean merge; release code, fixtures and tests are unchanged upstream. Existing fake-server cleanup warnings occur before and after. No game run was needed for this test-only change.

OpenAI Codex assisted the port and validation. Independent source review found no problems; the original fix is Yeetbot90's.

Windows release checks fail because the Unix command stub cannot run and text-mode checksum fixtures change the signed/uploaded bytes. This ports **Yeetbot90's accepted [Longshot PR255](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/255)** to the launcher. Only `tests/test_release.py` changes, matching accepted commit `01af760` exactly: a Windows-compatible `git-cliff` stub, its Unicode-path regression, and byte-exact checksum fixtures. Existing assertions, production release code and trusted keys are unchanged. Tested at `50e3e8b` (base `4bab213`): | Check | Before | After | |---|---|---| | Windows release suite | 1 failure, 5 errors / 28 tests | 29 passed | | Windows, accented/spaced temporary path | — | 29 passed | | Linux release suite | 28 passed | 29 passed | | Windows strict launcher core | — | 1,024 passed | | Locked Release build | — | 0 warnings/errors | Windows 11: Python 3.14, OpenSSL 3.5.9. Linux: Ubuntu 24.04, Python 3.12.3, OpenSSL 3.0.13. Commands: `python -I -B tests/test_release.py -v`, `python -I -B tests/test_launcher_core.py --strict --longshot <game-source>`, and `dotnet build LongshotLauncher.slnx -c Release -p:RestoreLockedMode=true`. Final check against main `1fba5f3`: clean merge; release code, fixtures and tests are unchanged upstream. Existing fake-server cleanup warnings occur before and after. No game run was needed for this test-only change. OpenAI Codex assisted the port and validation. Independent source review found no problems; the original fix is Yeetbot90's.
test(release): reuse accepted Windows fixtures
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
50e3e8b21e
Port tests/test_release.py from Longshot commit
01af7608bf93c524abe3900a7a3613268bd371ba, accepted PR255 by Yeetbot90.
The Windows git-cliff stand-in handles Unicode paths, and checksum
fixtures are signed and served as the same bytes. Production release
code, trusted keys and rejection assertions are unchanged.

Windows Python 3.14: 29 tests pass with normal and Unicode/space temp
paths; 1024 launcher core checks pass; locked Release build has no
warnings or errors. Linux validation is tracked separately.

Source: MagicBeanDev/Longshot#255
Assisted-by: OpenAI Codex
HumanBean deleted branch fix/windows-release-tests 2026-11-15 08:06:52 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Compile and test (pull_request) Blocked by required conditions
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!86
No description provided.