test(release): reuse accepted Windows fixture fixes #86
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!86
Loading…
Reference in a new issue
No description provided.
Delete branch "Anarkkie/LongshotLauncher:fix/windows-release-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Windows release checks fail because the Unix command stub cannot run and text-mode checksum fixtures change the signed/uploaded bytes. This ports Yeetbot90's accepted Longshot PR255 to the launcher.
Only
tests/test_release.pychanges, matching accepted commit01af760exactly: a Windows-compatiblegit-cliffstub, its Unicode-path regression, and byte-exact checksum fixtures. Existing assertions, production release code and trusted keys are unchanged.Tested at
50e3e8b(base4bab213):Windows 11: Python 3.14, OpenSSL 3.5.9. Linux: Ubuntu 24.04, Python 3.12.3, OpenSSL 3.0.13. Commands:
python -I -B tests/test_release.py -v,python -I -B tests/test_launcher_core.py --strict --longshot <game-source>, anddotnet build LongshotLauncher.slnx -c Release -p:RestoreLockedMode=true.Final check against main
1fba5f3: clean merge; release code, fixtures and tests are unchanged upstream. Existing fake-server cleanup warnings occur before and after. No game run was needed for this test-only change.OpenAI Codex assisted the port and validation. Independent source review found no problems; the original fix is Yeetbot90's.