WIP: fix(translations): drop the catalog texts #244 replaced, so CI's compile-and-test passes again #246
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!246
Loading…
Reference in a new issue
No description provided.
Delete branch "dyst/LongshotLauncher:fix/ci-translations"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
CI's Compile and test fails on every
maincommit since at least5abb5b0(#242).tests/test_launcher_core.pyrunsscripts/translations.pyfirst, and that check treats a catalog text the window no longer shows as a fault. #244 reworded the old-folder-layout card, and its old texts ("Details", the card's notice and its count) stayed in all twelve catalogs, so the test stops before it compiles anything.Summary
Core/Lang/*.json: the four texts no source shows any more are dropped from each of the twelve catalogs (48 lines, nothing else touched). Their replacements show in English until they are translated.Testing
Tested (Windows 11, .NET SDK 10.0.404):
python -I scripts/translations.py: no faults are left; it still lists the texts each catalog lacks, which the test allows.python -I tests/test_launcher_core.py --strict --longshot <Longshot main>: the translation step passes. The app checks and the core checks then compile, and the core checks run up toSavesChecks.LinkSavesChecks("A link whose shared save folder is gone…"), which fails here on Windows, onmainas well. That check passes on CI's Linux.Still to test: this PR's CI on Linux. If Compile and test still fails there, the failure is a second one, and this PR's comments will say what it is.
Risks
None for players: no text the window shows changes.
🤖 Generated with Claude Code
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.