WIP: fix(translations): drop the catalog texts #244 replaced, so CI's compile-and-test passes again #246

Draft
dyst wants to merge 1 commit from dyst/LongshotLauncher:fix/ci-translations into main
Member

CI's Compile and test fails on every main commit since at least 5abb5b0 (#242). tests/test_launcher_core.py runs scripts/translations.py first, and that check treats a catalog text the window no longer shows as a fault. #244 reworded the old-folder-layout card, and its old texts ("Details", the card's notice and its count) stayed in all twelve catalogs, so the test stops before it compiles anything.

Summary

  • Core/Lang/*.json: the four texts no source shows any more are dropped from each of the twelve catalogs (48 lines, nothing else touched). Their replacements show in English until they are translated.

Testing

Tested (Windows 11, .NET SDK 10.0.404):

  • python -I scripts/translations.py: no faults are left; it still lists the texts each catalog lacks, which the test allows.
  • python -I tests/test_launcher_core.py --strict --longshot <Longshot main>: the translation step passes. The app checks and the core checks then compile, and the core checks run up to SavesChecks.LinkSavesChecks ("A link whose shared save folder is gone…"), which fails here on Windows, on main as well. That check passes on CI's Linux.

Still to test: this PR's CI on Linux. If Compile and test still fails there, the failure is a second one, and this PR's comments will say what it is.

Risks

None for players: no text the window shows changes.

🤖 Generated with Claude Code

CI's **Compile and test** fails on every `main` commit since at least 5abb5b0 (#242). `tests/test_launcher_core.py` runs `scripts/translations.py` first, and that check treats a catalog text the window no longer shows as a fault. #244 reworded the old-folder-layout card, and its old texts ("Details", the card's notice and its count) stayed in all twelve catalogs, so the test stops before it compiles anything. ## Summary - `Core/Lang/*.json`: the four texts no source shows any more are dropped from each of the twelve catalogs (48 lines, nothing else touched). Their replacements show in English until they are translated. ## Testing **Tested** (Windows 11, .NET SDK 10.0.404): - `python -I scripts/translations.py`: no faults are left; it still lists the texts each catalog lacks, which the test allows. - `python -I tests/test_launcher_core.py --strict --longshot <Longshot main>`: the translation step passes. The app checks and the core checks then compile, and the core checks run up to `SavesChecks.LinkSavesChecks` ("A link whose shared save folder is gone…"), which fails here on Windows, on `main` as well. That check passes on CI's Linux. **Still to test:** this PR's CI on Linux. If **Compile and test** still fails there, the failure is a second one, and this PR's comments will say what it is. ## Risks None for players: no text the window shows changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(translations): drop the catalog texts #244 replaced, so CI's compile-and-test passes again
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 13s
610e8465bd
#244 reworded the old-folder-layout card ("Details", its notice and its count) and left the old texts in the twelve
catalogs. scripts/translations.py calls a catalog text the window no longer shows a fault, so tests/test_launcher_core.py
stops there on main (CI's "Compile and test" fails since 3fc4de3). The new texts show in English until they are translated.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
All checks were successful
CI / Compile and test (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 13s
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/ci-translations:dyst-fix/ci-translations'
git switch 'dyst-fix/ci-translations'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!246
No description provided.