fix(ui): the window can be resized, and long translations wrap instead of being cut #234
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!234
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:fix/resizable-window-long-labels"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In German the home's blue Update button reads "Aktualisi…", and the window can't be resized, so a translation that runs longer than the English has no room to go. This lets the window be resized and makes the parts that were cut wrap instead.
Fixes #226
Fixes #113
Summary
CanResize="True"with a minimum of 960x560. The window has no system frame (WindowDecorations="None"), so its own 5 px edges and 12 px corners callBeginResizeDrag. They're hidden while the window fills the screen, where the pages are still scaled up as before. F11 no longer turns resizing off when it leaves full screen. On a screen smaller than 1040x680 (a laptop scaled to 125%), the window now opens inside the work area.NoWrap), the save editor's "Backed up first…" note, and the Saves page's "From Hookshot…" line, which was already cut at 1040 px in German.tools/screenshotstakes--lang <code>and--size <w>x<h>, so a screen can be checked in another language and at another window size (README).Testing
python -I tests/test_launcher_core.py: 2601 checks passed. It has new checks for the resizable window (grips, minimum size, fit to screen, in PadChecks with the other window checks) and for Update wrapping under Play (InstanceFolderChecks).LAUNCHER=$PWD python -I ../Tooling/tests/test_release.py: 42 tests, 3 failures (test_the_bump,test_the_next_stable,test_check_tag_against_the_published_releases). They fail the same way on an unchanged checkout of main, are about tags and releases, and are not touched here.tools/screenshotsat 1040x680, and the home, Saves, Storage, Settings, step 2, Ready, the save editor and the zip import at the 960x560 minimum (the home at 1400x860 too), and looked through them for cut text. In English, the home and step 2 look the same as before at 1040x680.Screenshots
These are posted in the first comment, all German unless noted:
before-home-de.png(main): the Update button reads "Aktualisi…".after-home-de.png: Update under Play, with the whole word.after-home-en.png: English, with Update still beside Play.after-home-de-960x560.png,after-settings-de-960x560.png,after-save-editor-de-960x560.png: the window at its minimum size, with nothing cut.🤖 Generated with Claude Code
Screenshots from
tools/screenshots, in German unless noted.Before (main), 1040x680: the Update button reads "Aktualisi…"

After, 1040x680: Update under Play, with the whole word

After, English, 1040x680: Update still beside Play

After, at the 960x560 minimum: the home with a banner, step 2's upscaler rows and the save editor, with nothing cut


