fix(release): the upload address is the organization variable RELEASE_UPLOAD_API, and no compiled Python in the repository #2

Merged
HumanBean merged 1 commit from HumanBean/LongshotLauncher:fix/release-upload-variable into main 2026-11-13 02:17:05 +00:00
Owner

Why

The release workflow reads the upload address (the Forgejo API without Cloudflare's 100 MB limit) from an organization variable named FORGEJO_UPLOAD_API, but Forgejo refuses variable names that start with FORGEJO_ ("invalid secret name"), so it could never be set and every upload over 100 MB would fail.

What changed

  • .forgejo/workflows/release.yml: reads vars.RELEASE_UPLOAD_API and passes it to release.py as FORGEJO_UPLOAD_API (the script's own name is unchanged).
  • RELEASING.md, docs/releases.md, and .gitignore (__pycache__/, *.pyc); scripts/__pycache__/release.cpython-314.pyc, merged by mistake with #1, is removed: name the variable RELEASE_UPLOAD_API and say why. The shared files stay byte-identical with the other repository.
  • The organization variable RELEASE_UPLOAD_API=http://magicbean-git:3000/api/v1 is set on MagicBeanDev.

Flags and settings

None

Measurements

main: f929a9a3
this PR: fix/release-upload-variable @ 3a9291d2

main @ f929a9a3 this PR @ 3a9291d2
tests/test_release.py OK OK

Testing

Tested: the checks in Measurements on Linux; the variable RELEASE_UPLOAD_API was created on MagicBeanDev (the FORGEJO_ name was refused by the API with "invalid secret name").

Not tested: a release run that uploads a file over 100 MB (no release has run yet).

Needs other testers: None

Risk and rollback

Only the variable's name changes; revert this commit to go back.

Checklist

For everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description).
  • Rebased on current main.
  • python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
  • Tested in the game, or what wasn't is named under Testing.
  • Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
  • Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

  • Docs updated.
## Why The release workflow reads the upload address (the Forgejo API without Cloudflare's 100 MB limit) from an organization variable named `FORGEJO_UPLOAD_API`, but Forgejo refuses variable names that start with `FORGEJO_` ("invalid secret name"), so it could never be set and every upload over 100 MB would fail. ## What changed - `.forgejo/workflows/release.yml`: reads `vars.RELEASE_UPLOAD_API` and passes it to `release.py` as `FORGEJO_UPLOAD_API` (the script's own name is unchanged). - `RELEASING.md`, `docs/releases.md`, and `.gitignore` (`__pycache__/`, `*.pyc`); `scripts/__pycache__/release.cpython-314.pyc`, merged by mistake with #1, is removed: name the variable `RELEASE_UPLOAD_API` and say why. The shared files stay byte-identical with the other repository. - The organization variable `RELEASE_UPLOAD_API=http://magicbean-git:3000/api/v1` is set on MagicBeanDev. ## Flags and settings None ## Measurements main: f929a9a3 this PR: fix/release-upload-variable @ 3a9291d2 | | main @ f929a9a3 | this PR @ 3a9291d2 | |---|---|---| | `tests/test_release.py` | OK | OK | ## Testing **Tested:** the checks in Measurements on Linux; the variable `RELEASE_UPLOAD_API` was created on MagicBeanDev (the `FORGEJO_` name was refused by the API with "invalid secret name"). **Not tested:** a release run that uploads a file over 100 MB (no release has run yet). **Needs other testers:** None ## Risk and rollback Only the variable's name changes; revert this commit to go back. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] Docs updated.
fix(release): the upload address is the organization variable RELEASE_UPLOAD_API, and no compiled Python in the repository
All checks were successful
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Compile and test (pull_request) Successful in 1m8s
3a9291d2c5
HumanBean deleted branch fix/release-upload-variable 2026-11-13 02:17:05 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/LongshotLauncher!2
No description provided.