ci(release): no nightly when nothing new since the nightly before goes in its notes #133
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!133
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/LongshotLauncher:ci/nightly-only-with-news"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: ci · Risk: low · Tested on: none (the release workflow runs only on main) · Needs: none
Why
A push to main made of
ci:orchore:commits alone makes a launcher nightly whose "new since" section is empty, because git-cliff leaves those commits out of the notes. Longshot's nightly-322-5bc54c6c is one, made of a singleci(release)commit. This repository has the same workflow.What changed
This is the same change as in MagicBeanDev/Longshot: a nightly is not made when the commits since the nightly before would put nothing in its notes. The next one comes with what follows.
scripts/release.py:nightly_news()andrelease.py nightly-news(yes/no). It runs git-cliff withcliff.tomlover<newest nightly on HEAD's history>..HEAD. The first nightly is always yes, and a nightly tag on HEAD itself doesn't count, so a nightly that is run again still builds..forgejo/workflows/release.yml, the version job: on a push, after the "main has moved on" check, it fetches the pinned git-cliff and asksnightly-news. If the answer is no,tagis left empty. If it gets no answer, it builds.docs/releases.md: the rule.tests/test_release.py:test_a_nightly_with_nothing_new_is_not_made.Testing
Tested: the Python parses. I ran no checks on this PC; CI runs the tests.
Must be tested: after merge, this PR's own merge (
ci:) should make no nightly, and the next listed commit should make one.Risks
A commit that changes what ships but is titled
chore:waits for the next listed commit. To turn it off, revert the commit.🤖 Generated with Claude Code
WIP: ci(release): no nightly when nothing new since the nightly before goes in its notesto ci(release): no nightly when nothing new since the nightly before goes in its notes