fix(release): the upload address is the organization variable RELEASE_UPLOAD_API

HumanBean commented

2026-11-13 02:15:36 +00:00

Owner

Why

The release workflow reads the upload address (the Forgejo API without Cloudflare's 100 MB limit) from an organization variable named FORGEJO_UPLOAD_API, but Forgejo refuses variable names that start with FORGEJO_ ("invalid secret name"), so it could never be set and every upload over 100 MB would fail.

What changed

.forgejo/workflows/release.yml: reads vars.RELEASE_UPLOAD_API and passes it to release.py as FORGEJO_UPLOAD_API (the script's own name is unchanged).
RELEASING.md, docs/releases.md, docs/forgejo-runners.md: name the variable RELEASE_UPLOAD_API and say why. The shared files stay byte-identical with the other repository.
The organization variable RELEASE_UPLOAD_API=http://magicbean-git:3000/api/v1 is set on MagicBeanDev.

Flags and settings

None

Measurements

main: 77f605a2
this PR: fix/release-upload-variable @ d11ebb2a

	main @ `77f605a2`	this PR @ `d11ebb2a`
`tests/run_all.py` (Linux, interleaved: main, PR)	490 passed, 2 failed, 36 skipped	490 passed, 2 failed, 36 skipped
`tests/test_release.py`	OK	OK

The 2 failures are the known ones on main (test_bake_portability: no zstandard; test_builder_log_read_only: no libtk).

Testing

Tested: the checks in Measurements on Linux; the variable RELEASE_UPLOAD_API was created on MagicBeanDev (the FORGEJO_ name was refused by the API with "invalid secret name").

Not tested: a release run that uploads a file over 100 MB (no release has run yet).

Needs other testers: None

Risk and rollback

Only the variable's name changes; revert this commit to go back.

Checklist

For everyone

One topic.
The title is a Conventional Commit (type(scope): description).
Rebased on current main.
python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
Tested in the game, or what wasn't is named under Testing.
Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
No game files, dumps, build output or generated files.
third_party/ untouched (a new folder with a PROVENANCE.md instead).
The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

Docs updated.

## Why The release workflow reads the upload address (the Forgejo API without Cloudflare's 100 MB limit) from an organization variable named `FORGEJO_UPLOAD_API`, but Forgejo refuses variable names that start with `FORGEJO_` ("invalid secret name"), so it could never be set and every upload over 100 MB would fail. ## What changed - `.forgejo/workflows/release.yml`: reads `vars.RELEASE_UPLOAD_API` and passes it to `release.py` as `FORGEJO_UPLOAD_API` (the script's own name is unchanged). - `RELEASING.md`, `docs/releases.md`, `docs/forgejo-runners.md`: name the variable `RELEASE_UPLOAD_API` and say why. The shared files stay byte-identical with the other repository. - The organization variable `RELEASE_UPLOAD_API=http://magicbean-git:3000/api/v1` is set on MagicBeanDev. ## Flags and settings None ## Measurements main: 77f605a2 this PR: fix/release-upload-variable @ d11ebb2a | | main @ 77f605a2 | this PR @ d11ebb2a | |---|---|---| | `tests/run_all.py` (Linux, interleaved: main, PR) | 490 passed, 2 failed, 36 skipped | 490 passed, 2 failed, 36 skipped | | `tests/test_release.py` | OK | OK | The 2 failures are the known ones on main (`test_bake_portability`: no zstandard; `test_builder_log_read_only`: no libtk). ## Testing **Tested:** the checks in Measurements on Linux; the variable `RELEASE_UPLOAD_API` was created on MagicBeanDev (the `FORGEJO_` name was refused by the API with "invalid secret name"). **Not tested:** a release run that uploads a file over 100 MB (no release has run yet). **Needs other testers:** None ## Risk and rollback Only the variable's name changes; revert this commit to go back. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] Docs updated.

HumanBean added 1 commit

2026-11-13 02:15:37 +00:00

fix(release): the upload address is the organization variable RELEASE_UPLOAD_API (Forgejo refuses variable names that start with FORGEJO_)

Third-party parts / The same as upstream (pull_request) Has been skipped

Details

PR description / Description follows the template (pull_request_target) Has been cancelled

Details

Linux AppImage / appimage (pull_request) Has been cancelled

Details

Windows builder / Longshot Builder zip (pull_request) Has been cancelled

Details

Windows builder / Windows Vulkan back end (llvm-mingw) (pull_request) Has been cancelled

Details

Windows builder / dav1d for Windows (llvm-mingw) (pull_request) Has been cancelled

Details

CI / Conventional Commit title (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled

Details

CI / Python source checks (windows-2022, part 1/2) (pull_request) Has been cancelled

Details

CI / Python source checks (windows-2022, part 2/2) (pull_request) Has been cancelled

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled

Details

CI / Workflow lint (actionlint) (pull_request) Has been cancelled

Details

Third-party parts / As their notes say (pull_request) Has been cancelled

Details

d11ebb2a70

HumanBean merged commit f41db065cf into main

2026-11-13 02:17:09 +00:00

HumanBean deleted branch fix/release-upload-variable

2026-11-13 02:17:09 +00:00

HumanBean referenced this pull request from a commit

2026-11-13 02:17:10 +00:00

fix(release): the upload address is the organization variable RELEASE_UPLOAD_API (#79)

Rows
Columns

fix(release): the upload address is the organization variable RELEASE_UPLOAD_API #79

Why

What changed

Flags and settings

Measurements

Testing

Risk and rollback

Checklist

For everyone

If applicable