fix(vk): LONGSHOT_FSR=1 builds fail since #1989: the FSR 4 warm calls make_context with 3 of its 4 arguments #2122
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#2122
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since #1989 (
d76d202f5, merged 2026-11-21 18:41 UTC), a build withLONGSHOT_FSR=1stops atgpu/vk/vk_fsr4.cpp:Each PR built on its own, but they conflict:
69769ac96, 17:17 UTC) added the preparation's warm call,make_context(width, height, mode != 0)(line 1536).make_contexta fourth parameter with no default,Fsr4Model want(line 1168). It updated the per-frame call (line 1330) but not the warm call.The code is inside
#ifdef LONGSHOT_FSR, so builds without AMD FSR 4 are unaffected. CI sets the flag:.forgejo/workflows/build-linux.yml:248and.forgejo/workflows/vulkan-dlss.yml:64. Those jobs should be failing on main fromd76d202f5on; I haven't looked at their runs.Likely fix: pass the model the per-frame path uses (
prepare, line 1320), so the preparation warms the pipelines of the model the player picked:How it was found: reading the code, then a syntax-only compile of the one file on main
e7579b0a4with the renderer's include folders and-DLONGSHOT_FSR(llvm-mingw clang++,--target=x86_64-w64-mingw32). That one error is the only one. No full build, and no run.Possibly related, for context: