fix(website): remove game branding from public pages #193

Merged
HumanBean merged 1 commit from bibiburl/Longshot:fix/website-game-branding into main 2026-11-13 13:08:38 +00:00
Member

Why

The public website currently displays game titles, console branding and named characters/places. This emergency change replaces that wording with neutral descriptions while retaining technical product names and usable instructions.

What changed

  • Homepage, footer, About, requirements and imported guides: neutral public copy, with Longshot as the main headline. The corresponding requirements sentence in the root README stays consistent.
  • website/src/lib/public-copy.ts: normalize imported settings descriptions and activity text before publishing HTML, search content and progress-feed.json. Preserve source URLs, IDs, versions and original repository records.
  • website/scripts/check-site.ts: reject listed game-brand terms in generated prose and public activity fields. New tests cover neutral wording, retained technical names and unmodified source records.
  • Preserve exact save-directory names, commands, runtime identifiers and third-party provenance. No runtime code or assets change.

Flags and settings

None. Published descriptions change; runtime settings, values and defaults do not.

Measurements

Baseline: main @ 000f19f
main: 000f19f (2026-11-13)
This PR: fix/website-game-branding @ d54ce8f
Environment: local Linux, Node v22.23.4; deterministic source/output checks, no game run or performance measurement.

Check main @ 000f19f this PR @ d54ce8f
Listed game-brand term matches across seven public page sources 17 0

The seven sources are LongshotHero.astro, LongshotHome.astro, Footer.astro, about.mdx, requirements.mdx, docs/common-issues.md and CONTRIBUTING.md. Count the named terms in check-site.ts case-insensitively in each revision. This is a deterministic copy check, not an FPS comparison or a claim about trademark status.

Build the website, then run npm run check to audit generated public prose and feed fields:

14 page(s) built
Site check passed: 14 pages, 787 local links and assets, their anchors and edit links.
tests 7
pass 7
fail 0

Testing

Tested: Production website build; all seven website test files; generated page/feed branding guard; local links, assets, anchors and edit links; source comparison above; git diff --check. Technical names and exact record IDs/URLs are covered by regression tests.

Not tested: Full python -I -B tests/run_all.py runtime suite, game execution, visual browser inspection and screenshots. This is scoped to website copy/imports. Browser capture is unavailable in this session. No claim of visual or runtime verification is made.

Needs other testers: None required before this emergency review under the user's explicit exception. A desktop/mobile visual follow-up should inspect the shortened headline and neutral settings labels for readability and unchanged navigation.

Screenshots

Unavailable: browser capture was not available. Generated HTML was inspected, but this does not replace visual review.

Risk and rollback

Neutral descriptions can be less specific than original report titles/menu labels; each source report remains linked. A newly introduced unrecognized term may require another mapping, and a listed unmapped term will fail the output check. Revert this commit to restore prior website wording. No game, launcher or download behavior changes.

Reviewer notes

This is a separate emergency branch from current main. The local install-download-version preview remains paused and is not included. Website deployment still requires maintainer review/merge. This PR does not remove names from runtime code, historical Git records, external destinations or technical paths required by users.

Emergency readiness exception: the requesting user explicitly approved “Mark ready for emergency review” using the completed website checks, without the full runtime test suite or screenshots. The incomplete checklist items below remain unticked to preserve an accurate validation record; runtime timing comparisons are inapplicable to this copy-only website change.

Issues

User-requested emergency website cleanup; no linked issue.

Checklist

For everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description).
  • Rebased on current main.
  • python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above). Not run: website-only validation for this emergency change.
  • Tested in the game, or what wasn't is named under Testing.
  • Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). No further testing is required before emergency review under the explicit user exception above.
  • Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. Deterministic source comparison and website checks above; no runtime measurements apply.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots for a change that shows on screen. Browser capture unavailable.
  • A game-free test added for the fix, failing on main and passing here. The generated-output guard rejects pre-change branding; the new normalization tests pass.
  • Docs updated.
## Why The public website currently displays game titles, console branding and named characters/places. This emergency change replaces that wording with neutral descriptions while retaining technical product names and usable instructions. ## What changed - Homepage, footer, About, requirements and imported guides: neutral public copy, with Longshot as the main headline. The corresponding requirements sentence in the root README stays consistent. - `website/src/lib/public-copy.ts`: normalize imported settings descriptions and activity text before publishing HTML, search content and `progress-feed.json`. Preserve source URLs, IDs, versions and original repository records. - `website/scripts/check-site.ts`: reject listed game-brand terms in generated prose and public activity fields. New tests cover neutral wording, retained technical names and unmodified source records. - Preserve exact save-directory names, commands, runtime identifiers and third-party provenance. No runtime code or assets change. ## Flags and settings None. Published descriptions change; runtime settings, values and defaults do not. ## Measurements Baseline: main @ 000f19f main: 000f19f (2026-11-13) This PR: fix/website-game-branding @ d54ce8f Environment: local Linux, Node v22.23.4; deterministic source/output checks, no game run or performance measurement. | Check | main @ 000f19f | this PR @ d54ce8f | |---|---|---| | Listed game-brand term matches across seven public page sources | 17 | 0 | The seven sources are `LongshotHero.astro`, `LongshotHome.astro`, `Footer.astro`, `about.mdx`, `requirements.mdx`, `docs/common-issues.md` and `CONTRIBUTING.md`. Count the named terms in `check-site.ts` case-insensitively in each revision. This is a deterministic copy check, not an FPS comparison or a claim about trademark status. Build the website, then run `npm run check` to audit generated public prose and feed fields: ```text 14 page(s) built Site check passed: 14 pages, 787 local links and assets, their anchors and edit links. tests 7 pass 7 fail 0 ``` ## Testing **Tested:** Production website build; all seven website test files; generated page/feed branding guard; local links, assets, anchors and edit links; source comparison above; `git diff --check`. Technical names and exact record IDs/URLs are covered by regression tests. **Not tested:** Full `python -I -B tests/run_all.py` runtime suite, game execution, visual browser inspection and screenshots. This is scoped to website copy/imports. Browser capture is unavailable in this session. No claim of visual or runtime verification is made. **Needs other testers:** None required before this emergency review under the user's explicit exception. A desktop/mobile visual follow-up should inspect the shortened headline and neutral settings labels for readability and unchanged navigation. ## Screenshots Unavailable: browser capture was not available. Generated HTML was inspected, but this does not replace visual review. ## Risk and rollback Neutral descriptions can be less specific than original report titles/menu labels; each source report remains linked. A newly introduced unrecognized term may require another mapping, and a listed unmapped term will fail the output check. Revert this commit to restore prior website wording. No game, launcher or download behavior changes. ## Reviewer notes This is a separate emergency branch from current main. The local install-download-version preview remains paused and is not included. Website deployment still requires maintainer review/merge. This PR does not remove names from runtime code, historical Git records, external destinations or technical paths required by users. Emergency readiness exception: the requesting user explicitly approved “Mark ready for emergency review” using the completed website checks, without the full runtime test suite or screenshots. The incomplete checklist items below remain unticked to preserve an accurate validation record; runtime timing comparisons are inapplicable to this copy-only website change. ## Issues User-requested emergency website cleanup; no linked issue. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). Not run: website-only validation for this emergency change. - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). No further testing is required before emergency review under the explicit user exception above. - [ ] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. Deterministic source comparison and website checks above; no runtime measurements apply. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [ ] Screenshots for a change that shows on screen. Browser capture unavailable. - [x] A game-free test added for the fix, failing on `main` and passing here. The generated-output guard rejects pre-change branding; the new normalization tests pass. - [x] Docs updated.
fix(website): remove game branding from public pages
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
CI / Workflow lint (actionlint) (pull_request) Successful in 7s
Third-party parts / As their notes say (pull_request) Successful in 7s
PR description / Description follows the template (pull_request_target) Failing after 4s
d54ce8f807
Use neutral public wording in page copy, imported settings and repository activity. Keep technical product names, source links and required file paths intact, and check generated prose for regressions.

Assisted-by: OpenAI Codex
HumanBean deleted branch fix/website-game-branding 2026-11-13 13:08:39 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!193
No description provided.