Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1529
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Longshot version
v3.0.0-rc.7-own (source f3ef4d06): my own build of the v3.0.0-rc.7 tag with the first patch from #1370
Channel
Built from source
What kind of problem
Graphics (missing, black or wrong-coloured things, lighting, flicker)
What happened
Follow-up to #1370 (closed) and pull request #1447 (merged). There is one more case, and I think #1447 has it too.
What I saw. Crawling through a tunnel with DLAA, a patch in the middle of the picture smears into streaks while the camera moves. Everything around it stays sharp. It shows with frame generation on and off, only in motion, and most when crawling into the small room. First clip below.
What I expected. No smear, as in the other crawl tunnel and at the vine walls since the fix for #1370.
Steps. DLAA or DLSS. Go to the spot under "Where in the game" and crawl through the tunnel towards the room with the grate.
The cause, as far as I could track it. One of Link's meshes is never treated as a skinned draw, so the hidden-mesh rule never follows it, and its depth stays in the scene while the camera is inside him.
skin_check()ingpu/vk/vk_draw.cpponly takes a draw when the bone palette is in vertex-stage binding 3:const nvn_p_bind_buf& bones = s.ubo[0][3]; if (!bones.addr || bones.size < 48 || bones.size % 48) return;e56b2a466be24f0f, colour programd4474e51baeb2570) has a block of 16,960 bytes in binding 3 and the palette in binding 4. It is the same 280-bone buffer his other meshes have in binding 3.skin_check(). This one does not.a6d37b703547222aandbd7da7a670ae8f68, a 141-bone palette in binding 4).How I found it. With
RX_VK_OCC_QUERIES=0the rule from #1370 left out all 30 meshes it follows in every frame, and the patch was still on screen. ThenRX_VK_DLSS_TRACE=300listed the frame's draws. The attachedlongshot_log-second-tunnel-important-lines.txthas those lines and says how to read them.What I have not tested. This is on my own build of the v3.0.0-rc.7 tag with my original patch from #1370, not on main or a nightly. The description of #1447 says its check sits right after
skin_check(), so I expect main to miss the same mesh, but I have not run it. Someone with a nightly can check it in a minute at the spot.What fixed it on my build. For the hidden-mesh rule only, a draw counts as skinned by its vertex layout (the joint and weight attributes
skin_check()already looks at), wherever the palette is bound. The actor motion gets exactly the draws it got before. With that, 31 depth draws a frame are left out where it was 30, and the patch is gone (second clip). Attached:dlss-hidden-body-depth-v3.0.0-rc.7-v2.patch: the whole change as a patch against v3.0.0-rc.7 (the second form of the patch on #1370).skin_check-the-three-places.txt: the three changed places inskin_check()by themselves, for reading.You are welcome to use it under the project's licence, as with the first patch. No Co-Authored-By line needed.
There could be other cases like this one. I don't expect many, if any.
Found and patched with an AI assistant (Claude). I built and ran everything myself, on one PC.
Where in the game
Hyrule Castle: the crawl tunnel at the upper end of the moat on the keep's east side (by the ladder), crawling into the small room with the grate
How often
Every time
Graphics card and driver version
RTX 5090, NVIDIA 621.14
CPU, RAM and operating system
Ryzen 9 9950X3D, 64 GB, Windows 11
Changes from the defaults
Upscaler: DLAA at 3840x2160. Frame generation on in one run and off in the others: it shows both ways.
longshot_env.txt:HOS_DISCORD=0andHOS_CRASH_WATCH=0. For the two test runs one more line each:RX_VK_OCC_QUERIES=0, thenRX_VK_DLSS_TRACE=300.longshot_log.txt
In the two whole logs my Windows account name is replaced by "account" in four paths (C:\Users\account...). Nothing else in them is changed.
longshot_log-second-tunnel-important-lines.txt: start here. The lines that matter out of four runs, with a short note on each.longshot_log-rc7-second-tunnel-draw-list.txt: the whole log of the run with the problem, withRX_VK_DLSS_TRACE=300.longshot_log-rc7-second-tunnel-fixed.txt: the whole log of the run with the second form of the patch.dlss-hidden-body-depth-v3.0.0-rc.7-v2.patchandskin_check-the-three-places.txt: the change.Screenshots or video
First clip: the problem, on the build with the first patch from #1370. Second clip: the same crawl with the second form of the patch.
Before you send it
Possibly related, for context: