Game: the crash report goes into a public comment and the Send page does not say so; paths outside the home folder stay in it #1264

Open
opened 2026-11-16 23:27:14 +00:00 by mooki · 1 comment
Member

Longshot version

main at 17394b7111 (the merge of #983). Unchanged on main 2547a8f3dd.

Channel

Built from source

What kind of problem

Something else

What happened

Two parts of what a player agrees to when they press Report automatically (or tick Send crash reports automatically in the launcher).

  1. The page says "the team", the comment is public. The Send page says "This is what goes to the Longshot team, and nothing else" (
    "This is what goes to the Longshot team, and nothing else. Show all of it opens the report as it "
    ) and the Sent page says "the team sees it" (
    snprintf(out, cap, "Sent. Thank you: the team sees it%s.%s", link[0] ? " on the crash reports' issue" : "",
    ). The report, with its 150 log lines, is posted on issue 81, which anyone can read without signing in, and it stays there. The launcher's texts were changed to say "posts its report publicly" in MagicBeanDev/LongshotLauncher#128; docs/crash-report-window.md and the game's pages do not have the word "public".
  2. Only the home folder, the user name and some device names are taken out of the log lines. With the helper's own redaction, a log with these lines posts them as follows (probe built on the test helper):
    • options: the settings file is /mnt/Games/pc-ports/Longshot-crashtest/longshot_options.ini: unchanged. This one is live, in #81 (comment).
    • fs: mounted content: -> D:\Games\Longshot\romfs: unchanged.
    • fs: mounted content: -> /run/media/<user>/JanesSSD/Longshot/romfs: the user name goes, the disk label stays.
    • fs: save dir \\NAS-NAME\share\Longshot\saves: unchanged, host name included.
    • hid: controller "Janes DualSense" (bluetooth): unchanged (a Bluetooth alias is often a person's name).
    • Home, C:\Users, /var/home, Wine's Z:\home, /Users and the user name in any case do come out right (I ran the seven cases the old Python reporter tested).

Why it matters: the report is permanent and public, the page is the player's only point of consent, and the log is the part nobody reads before sending. The review of #983 listed this under "not done, your call"; this issue is so it does not get lost.

Where in the game

The crash window, the Send page and the Sent page; and the automatic send, which shows nothing.

How often

Every time

Graphics card and driver version

Not applicable.

CPU, RAM and operating system

Linux for the probe; the code is the same on Windows, where a game folder on D:\ is the common case.

Changes from the defaults

None.

longshot_log.txt

Not attached: read from the code, from the existing game-free test helper, and from the public comment above.

Screenshots or video

Not applicable.

What would fix it

  • Say it on the Send page, the Sent page and in docs/crash-report-window.md: "posted publicly on Longshot's crash issue, where anyone can read it", with the same words as the launcher (MagicBeanDev/LongshotLauncher#128).
  • Before the shape rules, replace the game folder (s->dir) and the settings folder with <game folder> and <settings folder>; that is the common case. Cut a mount point to its root (/run/media/<user>/<label> to /run/media/<user>/<disk>), and the host of a \\host\share path.
  • Leave the hid: controller names out of the log lines that go (as the microphone and audio device names already are).
  • A test for each: the send test in tests/test_crash_dialog.py with these lines in the log.

Before you send it

  • The problem is still there on the newest release or nightly (main).
  • I searched the open issues for it (#1093 asks for redaction in general).
  • I'm not attaching game files, keys, the game's executable, its .bin caches or saves.
### Longshot version main at 17394b71111f8b7d9d6ecc65f430175145394743 (the merge of https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/983). Unchanged on main 2547a8f3dd3267be6612bbc1edd79196093a10c4. ### Channel Built from source ### What kind of problem Something else ### What happened Two parts of what a player agrees to when they press Report automatically (or tick Send crash reports automatically in the launcher). 1. **The page says "the team", the comment is public.** The Send page says "This is what goes to the Longshot team, and nothing else" (https://git.magicbean.dev/MagicBeanDev/Longshot/src/commit/17394b71111f8b7d9d6ecc65f430175145394743/host/hos_crash_dialog.c#L1434) and the Sent page says "the team sees it" (https://git.magicbean.dev/MagicBeanDev/Longshot/src/commit/17394b71111f8b7d9d6ecc65f430175145394743/host/hos_crash_dialog.h#L1056). The report, with its 150 log lines, is posted on issue 81, which anyone can read without signing in, and it stays there. The launcher's texts were changed to say "posts its report publicly" in https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/128; `docs/crash-report-window.md` and the game's pages do not have the word "public". 2. **Only the home folder, the user name and some device names are taken out of the log lines.** With the helper's own redaction, a log with these lines posts them as follows (probe built on the test helper): - `options: the settings file is /mnt/Games/pc-ports/Longshot-crashtest/longshot_options.ini`: unchanged. This one is live, in https://git.magicbean.dev/MagicBeanDev/Longshot/issues/81#issuecomment-33797. - `fs: mounted content: -> D:\Games\Longshot\romfs`: unchanged. - `fs: mounted content: -> /run/media/<user>/JanesSSD/Longshot/romfs`: the user name goes, the disk label stays. - `fs: save dir \\NAS-NAME\share\Longshot\saves`: unchanged, host name included. - `hid: controller "Janes DualSense" (bluetooth)`: unchanged (a Bluetooth alias is often a person's name). - Home, `C:\Users`, `/var/home`, Wine's `Z:\home`, `/Users` and the user name in any case do come out right (I ran the seven cases the old Python reporter tested). Why it matters: the report is permanent and public, the page is the player's only point of consent, and the log is the part nobody reads before sending. The review of #983 listed this under "not done, your call"; this issue is so it does not get lost. ### Where in the game The crash window, the Send page and the Sent page; and the automatic send, which shows nothing. ### How often Every time ### Graphics card and driver version Not applicable. ### CPU, RAM and operating system Linux for the probe; the code is the same on Windows, where a game folder on `D:\` is the common case. ### Changes from the defaults None. ### longshot_log.txt Not attached: read from the code, from the existing game-free test helper, and from the public comment above. ### Screenshots or video Not applicable. ### What would fix it - Say it on the Send page, the Sent page and in `docs/crash-report-window.md`: "posted publicly on Longshot's crash issue, where anyone can read it", with the same words as the launcher (https://git.magicbean.dev/MagicBeanDev/LongshotLauncher/pulls/128). - Before the shape rules, replace the game folder (`s->dir`) and the settings folder with `<game folder>` and `<settings folder>`; that is the common case. Cut a mount point to its root (`/run/media/<user>/<label>` to `/run/media/<user>/<disk>`), and the host of a `\\host\share` path. - Leave the `hid:` controller names out of the log lines that go (as the microphone and audio device names already are). - A test for each: the send test in `tests/test_crash_dialog.py` with these lines in the log. ### Before you send it - [x] The problem is still there on the newest release or nightly (main). - [x] I searched the open issues for it (https://git.magicbean.dev/MagicBeanDev/Longshot/issues/1093 asks for redaction in general). - [x] I'm not attaching game files, keys, the game's executable, its .bin caches or saves.
Collaborator

Possibly related, for context:

  • #1093 Idea: Redact sensitive information from generated files — Broader request to redact sensitive information from generated files, including crash reports.
  • #81 feat: crash reports sent from the game to a bot (with consent) — Original crash-report feature; its report destination and redaction scope are relevant.
Possibly related, for context: - #1093 Idea: Redact sensitive information from generated files — Broader request to redact sensitive information from generated files, including crash reports. - #81 feat: crash reports sent from the game to a bot (with consent) — Original crash-report feature; its report destination and redaction scope are relevant.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot#1264
No description provided.