Game: the crash report goes into a public comment and the Send page does not say so; paths outside the home folder stay in it #1264
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1264
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Longshot version
main at
17394b7111(the merge of #983). Unchanged on main2547a8f3dd.Channel
Built from source
What kind of problem
Something else
What happened
Two parts of what a player agrees to when they press Report automatically (or tick Send crash reports automatically in the launcher).
"This is what goes to the Longshot team, and nothing else. Show all of it opens the report as it "snprintf(out, cap, "Sent. Thank you: the team sees it%s.%s", link[0] ? " on the crash reports' issue" : "",docs/crash-report-window.mdand the game's pages do not have the word "public".options: the settings file is /mnt/Games/pc-ports/Longshot-crashtest/longshot_options.ini: unchanged. This one is live, in #81 (comment).fs: mounted content: -> D:\Games\Longshot\romfs: unchanged.fs: mounted content: -> /run/media/<user>/JanesSSD/Longshot/romfs: the user name goes, the disk label stays.fs: save dir \\NAS-NAME\share\Longshot\saves: unchanged, host name included.hid: controller "Janes DualSense" (bluetooth): unchanged (a Bluetooth alias is often a person's name).C:\Users,/var/home, Wine'sZ:\home,/Usersand the user name in any case do come out right (I ran the seven cases the old Python reporter tested).Why it matters: the report is permanent and public, the page is the player's only point of consent, and the log is the part nobody reads before sending. The review of #983 listed this under "not done, your call"; this issue is so it does not get lost.
Where in the game
The crash window, the Send page and the Sent page; and the automatic send, which shows nothing.
How often
Every time
Graphics card and driver version
Not applicable.
CPU, RAM and operating system
Linux for the probe; the code is the same on Windows, where a game folder on
D:\is the common case.Changes from the defaults
None.
longshot_log.txt
Not attached: read from the code, from the existing game-free test helper, and from the public comment above.
Screenshots or video
Not applicable.
What would fix it
docs/crash-report-window.md: "posted publicly on Longshot's crash issue, where anyone can read it", with the same words as the launcher (MagicBeanDev/LongshotLauncher#128).s->dir) and the settings folder with<game folder>and<settings folder>; that is the common case. Cut a mount point to its root (/run/media/<user>/<label>to/run/media/<user>/<disk>), and the host of a\\host\sharepath.hid:controller names out of the log lines that go (as the microphone and audio device names already are).tests/test_crash_dialog.pywith these lines in the log.Before you send it
Possibly related, for context: