Game: cutscene voices switch from Portuguese (pt-BR) to Japanese after the first boss (from Hookshot #1460) #125
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#125
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Ported from NotRexed/Hookshot#1460 (reported by deivid94, closed into the
tracking issue NotRexed/Hookshot#2506), with what has been learned since.
Not reproduced yet, on Hookshot or on Longshot.
Longshot version
Reported on Hookshot v2.0.11 (source d6369f1e). Not tried on Longshot; nothing in the code paths below has changed since.
What kind of problem
Sound
What happened
With
language.txt=pt-BR(the log saysoe: language pt-BR (language.txt)), the first cutscenes in Kokiri Forestplayed the Portuguese dub, but the cutscene right after defeating Gohma (the Great Deku Tree) played Japanese voices.
Subtitles and menus stayed in Portuguese. No setting was changed between the two
(the report,
its log).
What is ruled out
From Joey-Magnus's notes and the report:
USpt_EventFlowMsg-_Dm_Kokiri_0160and its sixstream files), the same set as the other languages, and none is byte-identical to its Japanese counterpart.
Dm_Kokiri_0160.webmhas no audio track; the voices are the.bwavfiles played alongside it.nn::oe::GetDesiredLanguagereadslanguage.txtonce and caches it.What the game does
The game has a Voice Language option of its own, apart from the text language
(mooki's lead), and static analysis of the
binary adds how it is chosen:
OptionData.VoiceLanguage(murmur3 0xa2dcdc9d), saved inoption.sav. On the game's ownOptions screen it offers nine languages: Japanese, English, French (France), French (Canada), German, Spanish (Spain),
Spanish (Latin America), Italian, Portuguese (Brazil).
GameDataList'sDefaultValue,ResetTypeValue4,SaveFileIndex1).GetDesiredLanguagegives a region and alanguage, and from them a region-language type (
pt-BRis type 4,USpt); the fonts and messages follow that type.The voice files are picked from the option's value instead, mapped through
VoiceSettingInfo'sLanguageMapping.game::NpcVoiceResource, on its first update) sets the option to thetype's default voice (Portuguese (Brazil) for
pt-BR), beforeoption.savis read; a loadedoption.savthen replacesthe value. Whenever the option is written afterwards, the voices are picked again.
JPja.Sequence/ConfirmationResetOption.module.ainb, nodeSeqOneShotSetDefaultVoiceLanguage) sets thetype's default again, Portuguese (Brazil) here, not Japanese.
So Japanese voices under Portuguese text means the option held Japanese (its game-data default) or a value the game
does not know, while the text kept following
pt-BR.The reproduction so far
mooki's runs on Hookshot
mainbdfe09cpluslogging (Linux, RTX 4090, NVIDIA 615.78.08,
pt-BR), logging the option, every save-file call and every voice fileopened:
option.savemptied (0 bytes), Continueoption.savcut to half, ContinueUSptUSptSo the scene after Gohma plays the Portuguese dub while the option holds Portuguese, and neither an empty nor a
half-written
option.savturned it Japanese. The way left is anoption.savthat holds Japanese (or an unknown value),read at the start of a session. mooki saw exactly that the other way round: save folders whose
option.savheld Japaneseplayed
JPjaunderen-UStext.The reporter's reply: they had rebuilt the
game and copied their save folder out and back in between sessions; the game's Voice Language option now shows
Portuguese; Windows is set to English.
Where in the game
The cutscene after defeating Gohma (Great Deku Tree); the earlier Kokiri Forest cutscenes were in Portuguese.
How often
Once, in the reporter's playthrough
Graphics card and driver version
Reporter: NVIDIA GeForce RTX 4060 (8 GB), NVIDIA 610.74
CPU, RAM and operating system
Reporter: AMD Ryzen 7 5700X, 32 GB, Windows 11 Pro 24H2 (build 26100)
Changes from the defaults
Reporter:
language.txtpt-BR(chosen in the builder), built from a.nup, game folder at the root of a secondarydrive, 5.1 output (
audio: device sink on mix 0, 6 channels), frame generation on, ultrawide on; no env file.What would settle it
save folder (
user/save/..., withoption.sav) was copied from another install, an emulator or another port, or withscripts/oot_saves.py.OptionData.VoiceLanguageafter the start of a session, and whenoption.savis read andwritten relative to the voice resource's first update. A live run that logs the voice manager's language changes
(with their caller) and
option.sav's value at each read would show it.option.savfrom elsewhere turns out to be the cause: nothing in Longshot validates theoption against the text language, and the game's own behaviour (Japanese voices under other text) is legitimate when a
player picks it, so any change should only cover values the game does not know.