Game: the game's reverb, delay and biquad-filter audio effects are unimplemented, so it plays without them #123
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#123
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Longshot version
longshot v2.2.0-rc.1-26-g3e78c9c7 (source a4c44921); the same in Hookshot v2.0.14
What kind of problem
Sound
What happened
The game builds part of its sound with
nn::audioeffects that Longshot does not implement: the plain reverb, thedelay and the biquad filter on its sub mixes. Every call on them goes to the generic import stub, which logs once,
sets
x0to 0 and does nothing else. SoAddReverb,AddDelayandAddBiquadFilterreturn 0 (success) to the game whileno effect is added, and the game's mix plays without them.
The log lists them (37 unimplemented
nn::audioimports in one session of the build above), all of them these threeeffects plus a few device-volume queries:
AddReverb,SetReverbInputOutput,GetReverbInputOutput,SetReverbEnabled,IsReverbEnabled,SetReverbEarlyMode,SetReverbEarlyGain,SetReverbLateMode,SetReverbLateGain,SetReverbPredelayTime,SetReverbDecayTime,SetReverbHighFrequencyDecayRatio,SetReverbColoration,SetReverbReverbGain,SetReverbOutGain,SetReverbDryGainAddDelay,SetDelayInputOutput,SetDelayEnabled,IsDelayEnabled,SetDelayTime,GetDelayTime,SetDelayFeedbackGain,SetDelayDryGain,SetDelayInGain,SetDelayLowPassAmount,SetDelayChannelSpreadAddBiquadFilter,SetBiquadFilterInputOutput,SetBiquadFilterEnabled,SetBiquadFilterParameterSetAudioRendererVoiceDropParameter,GetAudioRendererVoiceDropParameter,GetAudioDeviceOutputVolume,AcquireAudioOutputDeviceNotification,Set/IsDeviceOutputVolumeAutoTuneModeEnabledhost/nn_audio.cimplements the I3DL2 reverb (AddI3dl2Reverb), the aux bus, splitter biquads and voice biquads; thelogs never show the game adding an I3DL2 reverb. The game's own reverb is the plain one above.
How the game uses them, by static analysis of its binary (not yet confirmed by ear): its audio framework adds a reverb, a
delay and a biquad filter to sub mixes and drives their parameters from its environment data, so the expected loss is the
game's room and area reverberation, echo and filtering (caves, dungeons, large rooms), with the dry sound still playing.
The renderer settings it asks for are 48 kHz, 240 samples a frame, 96 voices and 30 mix buffers, out through one device
sink.
Where in the game
Everywhere the game sets these effects up; likely most audible in caves, dungeons and big interiors.
How often
Always
Graphics card and driver version
Not relevant (NVIDIA GeForce RTX 3080 here)
CPU, RAM and operating system
Windows 11
Changes from the defaults
None
Wanted
code in
host/nn_audio.c.