Game: the game's reverb, delay and biquad-filter audio effects are unimplemented, so it plays without them #123

Open
opened 2026-11-13 05:26:31 +00:00 by dyst · 0 comments
Member

Longshot version

longshot v2.2.0-rc.1-26-g3e78c9c7 (source a4c44921); the same in Hookshot v2.0.14

What kind of problem

Sound

What happened

The game builds part of its sound with nn::audio effects that Longshot does not implement: the plain reverb, the
delay and the biquad filter on its sub mixes. Every call on them goes to the generic import stub, which logs once,
sets x0 to 0 and does nothing else. So AddReverb, AddDelay and AddBiquadFilter return 0 (success) to the game while
no effect is added, and the game's mix plays without them.

The log lists them (37 unimplemented nn::audio imports in one session of the build above), all of them these three
effects plus a few device-volume queries:

  • Reverb: AddReverb, SetReverbInputOutput, GetReverbInputOutput, SetReverbEnabled, IsReverbEnabled,
    SetReverbEarlyMode, SetReverbEarlyGain, SetReverbLateMode, SetReverbLateGain, SetReverbPredelayTime,
    SetReverbDecayTime, SetReverbHighFrequencyDecayRatio, SetReverbColoration, SetReverbReverbGain,
    SetReverbOutGain, SetReverbDryGain
  • Delay: AddDelay, SetDelayInputOutput, SetDelayEnabled, IsDelayEnabled, SetDelayTime, GetDelayTime,
    SetDelayFeedbackGain, SetDelayDryGain, SetDelayInGain, SetDelayLowPassAmount, SetDelayChannelSpread
  • Biquad filter: AddBiquadFilter, SetBiquadFilterInputOutput, SetBiquadFilterEnabled, SetBiquadFilterParameter
  • Other: SetAudioRendererVoiceDropParameter, GetAudioRendererVoiceDropParameter, GetAudioDeviceOutputVolume,
    AcquireAudioOutputDeviceNotification, Set/IsDeviceOutputVolumeAutoTuneModeEnabled

host/nn_audio.c implements the I3DL2 reverb (AddI3dl2Reverb), the aux bus, splitter biquads and voice biquads; the
logs never show the game adding an I3DL2 reverb. The game's own reverb is the plain one above.

How the game uses them, by static analysis of its binary (not yet confirmed by ear): its audio framework adds a reverb, a
delay and a biquad filter to sub mixes and drives their parameters from its environment data, so the expected loss is the
game's room and area reverberation, echo and filtering (caves, dungeons, large rooms), with the dry sound still playing.
The renderer settings it asks for are 48 kHz, 240 samples a frame, 96 voices and 30 mix buffers, out through one device
sink.

Where in the game

Everywhere the game sets these effects up; likely most audible in caves, dungeons and big interiors.

How often

Always

Graphics card and driver version

Not relevant (NVIDIA GeForce RTX 3080 here)

CPU, RAM and operating system

Windows 11

Changes from the defaults

None

Wanted

  • HLEs for the plain reverb, the delay and the biquad filter on sub mixes, following the existing I3DL2 reverb and aux
    code in host/nn_audio.c.
  • A listening comparison against the Switch in a cave or dungeon, to confirm what the missing effects change.
### Longshot version longshot v2.2.0-rc.1-26-g3e78c9c7 (source a4c44921); the same in Hookshot v2.0.14 ### What kind of problem Sound ### What happened The game builds part of its sound with `nn::audio` effects that Longshot does not implement: the **plain reverb**, the **delay** and the **biquad filter** on its sub mixes. Every call on them goes to the generic import stub, which logs once, sets `x0` to 0 and does nothing else. So `AddReverb`, `AddDelay` and `AddBiquadFilter` return 0 (success) to the game while no effect is added, and the game's mix plays without them. The log lists them (37 unimplemented `nn::audio` imports in one session of the build above), all of them these three effects plus a few device-volume queries: - **Reverb:** `AddReverb`, `SetReverbInputOutput`, `GetReverbInputOutput`, `SetReverbEnabled`, `IsReverbEnabled`, `SetReverbEarlyMode`, `SetReverbEarlyGain`, `SetReverbLateMode`, `SetReverbLateGain`, `SetReverbPredelayTime`, `SetReverbDecayTime`, `SetReverbHighFrequencyDecayRatio`, `SetReverbColoration`, `SetReverbReverbGain`, `SetReverbOutGain`, `SetReverbDryGain` - **Delay:** `AddDelay`, `SetDelayInputOutput`, `SetDelayEnabled`, `IsDelayEnabled`, `SetDelayTime`, `GetDelayTime`, `SetDelayFeedbackGain`, `SetDelayDryGain`, `SetDelayInGain`, `SetDelayLowPassAmount`, `SetDelayChannelSpread` - **Biquad filter:** `AddBiquadFilter`, `SetBiquadFilterInputOutput`, `SetBiquadFilterEnabled`, `SetBiquadFilterParameter` - **Other:** `SetAudioRendererVoiceDropParameter`, `GetAudioRendererVoiceDropParameter`, `GetAudioDeviceOutputVolume`, `AcquireAudioOutputDeviceNotification`, `Set/IsDeviceOutputVolumeAutoTuneModeEnabled` `host/nn_audio.c` implements the **I3DL2** reverb (`AddI3dl2Reverb`), the aux bus, splitter biquads and voice biquads; the logs never show the game adding an I3DL2 reverb. The game's own reverb is the plain one above. How the game uses them, by static analysis of its binary (not yet confirmed by ear): its audio framework adds a reverb, a delay and a biquad filter to sub mixes and drives their parameters from its environment data, so the expected loss is the game's room and area reverberation, echo and filtering (caves, dungeons, large rooms), with the dry sound still playing. The renderer settings it asks for are 48 kHz, 240 samples a frame, 96 voices and 30 mix buffers, out through one device sink. ### Where in the game Everywhere the game sets these effects up; likely most audible in caves, dungeons and big interiors. ### How often Always ### Graphics card and driver version Not relevant (NVIDIA GeForce RTX 3080 here) ### CPU, RAM and operating system Windows 11 ### Changes from the defaults None ### Wanted - HLEs for the plain reverb, the delay and the biquad filter on sub mixes, following the existing I3DL2 reverb and aux code in `host/nn_audio.c`. - A listening comparison against the Switch in a cave or dungeon, to confirm what the missing effects change.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot#123
No description provided.