Idea: Hold the game at 60 FPS during timed scenes when using a higher cap #1228
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1228
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reported on Discord
The idea
Add a Graphics-tab toggle below Game frame rate cap that temporarily caps the game at 60 FPS during its own scenes (cutscenes, conversations, map changes) when the configured cap is above 60, then restores the chosen cap about half a second after the scene ends. Movies would retain the higher rate and frame generation would continue. The reporter's custom implementation watches the event manager; it cannot currently distinguish boss fights from normal play. They offered to share the code.
Why
This would preserve frame-counted scene timing while allowing higher frame rates during normal play without manually changing the cap.
Tested
The reporter tested a custom build based on Longshot v3.0.0-rc.5 with a 240 cap at the Great Deku Tree conversation: 60 through the conversation, then the higher rate afterward. The attached screenshot shows the toggle on and an FPS counter reading 210.
Missing
Implementation/code not attached; reporter offered to share it.
Files from the Discord report:
From Discord:
The reporter has now provided the implementation as
hold-60-where-needed-v3.0.0-rc.5.patch, applicable to v3.0.0-rc.5 (commite4d035e9e71a8375964052195727ff87b1845047), rather than only offering to share it. It adds the Graphics-tab toggle and event-based 60 FPS hold, with a movie exception and unchanged frame generation. They tested 13 holds over 18 minutes on Windows at a 240 cap; each ended when the event did (0.3–148 seconds; longest was the Great Deku Tree talk). The exact patch was not used for the whole game build, and the movie exception was not play-tested. The full patch is in the Discord attachmentmessage.txton message 1571991659036680243; the issue attachment is the screenshot.