Idea: preserve reusable build outputs after unrelated post-link failures #1076
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot#1076
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Reported on Discord
What happened
A change to the repository's own renderer code (functions in the
mkwvknamespace) left five symbols undefined. The build linked, then the renderer check innx2/build.py(check_vk_symbols) rejectedlongshot_vk.so:The fix for that error was in the repository's own code, but the next build translated and compiled the whole game again.
Where it comes from
nx2/make_game.py,forget_failed_build(work, linked, failed): whenlinkedis true (the link or any step after it failed), it removes the lift key, takes the objects out of the object store, and deletesobjcacheandsa/build/obj. This was added inac4fb52d("a failed build drops its compiled objects too, not only the lift"), for Hookshot issue 1197, where a cached runtime object from another version linked and lefta64_dirty/a64_icall/a64_lookup/recomp_cntpctundefined at every try.A failure before the link already has a narrower path: when every file in
failedis a repository source (host/, gpu/, third_party/), the translation is kept. A failure after the link has no such path, so the renderer symbol check, which only looks at the repository's own code, wipes everything.The idea
After a post-link failure, keep the translation (and the objects not involved) when the failure is plainly in the repository's own code. For example, when every unresolved symbol
check_vk_symbolsreports belongs to our own namespaces (mkwvk, …) and none is a game or runtime symbol. Keep the full wipe for the case issue 1197 hit.Not known yet
The Longshot version or commit the build was made from (a build from source on Linux).