foliage is still disapearing, some flower and branches glow #667
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#667
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Builder version
2.0.1
How you built
Hookshot Builder app (Windows)
Game files given to it
A .nup
The error
Visual Studio or Build Tools version, and Windows SDK version
No response
Operating system and free space on the output drive
windows 11 180 free gb
Before you send it
hookshot_log.1.txt
hookshot_log.2.txt
hookshot_log.3.txt
hookshot_log.txt
https://youtu.be/0GzDiqAwMl0
Same issue
Same issue on v2.0.2
Same here (RTX 3060 Ti, Ryzen 5 3600, Windows, a source build of
mainas of today). Some findings in case they help:A radius around Link where everything near "washes out". Inside a sphere that moves with Link, nearby undergrowth loses its stems and leaves (ferns keep only their flowers), trees lose their canopy (their shadow shows bare branches), and the shadows inside that radius go too. Walking, the edge of the sphere moves ahead of Link and "washes" what it reaches. Outside it, everything draws. Since the shadows go with it, it looks like something tied to the near region (nearest shadow cascade, the player-centred grass interaction map, or a player-centred target reused between frames) rather than the foliage meshes themselves.
Ferns and far trees drawn like mirrors (white facing the sun, sky blue when looking up; the colour comes back when the camera moves). Logging every storage buffer a draw could not bind showed the far-foliage vertex programs
95db514a35353e28andd76e73cfbe651494(and68642bb810ee3e7c,6b4dea601798c255,739acd678ae08655,d905f52b7517c681,51183fe750d5d0c8,4f0c0b40ab3a32cd) binding a "storage buffer" whose address is float data:c4+0x40 addr 0x430c0000c2480000,c5+0x60 addr 0x10001c00a size 0x3faaaaab. The address was tracked without the NVN bias to a constant buffer other than c0 while part of it comes from memory, so it was never bound and read zeros. Resetting that result for graphics stages inglobal_memory_to_storage_buffer_pass.cpp(next to the c1 rule: index != 0 andOrigins(...).load, left to the run-time search) took "storage buffer NOT bound" from ~38,000 a session to 0, and trees and bushes draw with their colours; the ferns still look reflective.Tried, no change:
RX_VK_SSBO_STRETCH=1,HOOKSHOT_OCCLUSION_OFF=1,RX_VK_FOLLOW_MESH=1(more flashes), 8 instead of 4global_tables(more black ground patches).Workaround: Hyrule Field's
ResFoliageScenehas noLodSetting. Adding one withDist_Undergrowth0= 0.5 (and growing that file's entry inResourceSizeTable.Product.111...rsizetable.zs, or the game closes while the map loads) keeps the far models up close; trees then keep their canopy.Seeing this too on AMD Radeon RX 6650 XT (Vulkan 1.4), Windows 11, hookshot v2.0.2 (source 998ef8f9): vegetation is fine at a distance, but up close only the branches remain and the leaves disappear. Details and logs (
storage buffer NOT bound (reads zeros)on stage 7 mesh programs) are in #696. I'll add a video here shortly.Analysis created with Claude; it may contain errors
https://youtu.be/YXcEmNwKbms
RX 7800 XT (RDNA3), v2.0.2-v2.0.3: some flowers/stems glowed neon-green. On v2.0.2-v2.0.4 the log had
storage buffer NOT bound (reads zeros)for programs 51183fe750d5d0c8 (stage 7, c5+0x1d0, a float-like address) and da7a7ab28b8e73d9 (stage 1, c5+0). Correction to what I first wrote: on v2.0.5 the lines are still there (40 per session) but the set is different:storage buffer NOT bound (reads zeros)for six mesh (stage 7) programs:51183fe750d5d0c8(c5+0x1d0) and4f0c0b40ab3a32cd(c5+0x228), both with a float-like address, and68642bb810ee3e7c,6b4dea601798c255,739acd678ae08655,d905f52b7517c681(all c5+0x60, addresses like0x10001c00a,0x20001c00a, ... that look like packed floats), 40 lines per session. The character lighting is fine since v2.0.4. The neon glow itself is still present for me on v2.0.5 (see #875).Tracked in #994, follow there. That issue collects every report of floating trees and missing or vanishing vegetation, and this one is linked from it with its GPU, version and log details. It is a known issue in v2.0.6 and not fixed yet. If it still happens on v2.0.6 (https://github.com/NotRexed/Hookshot/releases/tag/v2.0.6; Update next to Play in the launcher), please add a comment there with your
hookshot_log.txt.