Minor: Floating trees in Kakariko Village #352
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#352
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Builder version
Foliage and lighting
How you built
Hookshot Builder app (Windows)
Game files given to it
A .nup
The error
Visual Studio or Build Tools version, and Windows SDK version
No response
Operating system and free space on the output drive
Windows 11 25H2 / 338 GB Free on Output Drive
Before you send it
Thanks for the report and the screenshot! Could you attach
hookshot_log.txtfrom a run where the trees float (next tohookshot.exe), and say which GPU and driver you have? It would also help to know whether they're still floating after you leave Kakariko and come back.Same problem here, inside and outside of Kakariko. I also have a weird shadow flickering issue...
hookshot_log.txt
Same here, floating trees in Kakariko Village (they look like the Death Mountain slope trees with the mountain itself not drawn, as in #422).
Log from the run where the trees floated (I went from Kakariko into the Royal Family's Tomb afterwards in the same run): https://gist.github.com/hallygtree/1d14e332852279a847947fa4ad6264c4
Still happening on the latest release,
low-vram(source618e37c6), and not only in Kakariko: I see floating trees when entering the Hyrule Castle area.RX_VK_WAIT_GPU=0inhookshot_env.txt0 failed), no device loss or crash during the sessionThis fits the reading above (Death Mountain slope trees drawn without the mountain, as in #422), since Death Mountain is visible in the distance from the castle area too. I can attach
hookshot_log.txtif it helps.Still happening on v2.0.2 (latest), so not tied to low settings or VRAM:
Same pattern — trees climbing into the sky in the shape of a slope, which matches
the Death Mountain trees-without-the-mountain reading (#422). Screenshot attached.
Same here on v2.0.5 (Windows, NVIDIA). Floating trees in many places around Hyrule, not just Kakariko. In Hyrule Field, for example, trees stand where the hillside under them should be, matching the "mountain not drawn" explanation in #422.
Setup
Tracked in #994, follow there. That issue collects every report of floating trees and missing or vanishing vegetation, and this one is linked from it with its GPU, version and log details. It is a known issue in v2.0.6 and not fixed yet. This was the main floating-trees report; its details and the #422 trace are summarised there. If it still happens on v2.0.6 (https://github.com/NotRexed/Hookshot/releases/tag/v2.0.6; Update next to Play in the launcher), please add a comment there with your
hookshot_log.txt.Found which program draws the floating trees, in case it helps (v2.0.6 + local changes, RTX 3060 Ti, Windows).
I hid mesh programs one at a time while looking at the floating trees over Kakariko (
RX_VK_SKIP_FILE, bisection with screenshots). They are all drawn by one mesh program:3cb7682790143836. With only that program left out:c36a4f3f667c886a/9d8403e2e566c773, so the "mountain not drawn" reading from #422 doesn't seem to be the cause here: the mountain is there, these trees are extra).As a stopgap I skip it by default in
vk_draw.cpp(added to theRX_VK_SKIP_PROGdefault list, with a switch to draw it again). It looks like a far-LOD forest whose own culling/placement goes wrong rather than missing terrain under it. I haven't checked yet whether skipping it removes legitimate distant trees elsewhere (Hyrule Field from a distance looked fine).