MagicBeanDev/Hookshot
Archived
Watch
6
0
Fork
You've already forked Hookshot
 0
Code Issues 125 Pull requests 205 Activity

docs: add the tested-configurations row for #2748's game run #2757

Open
github-sync wants to merge 1 commit from github/pr/2757 into main
pull from: github/pr/2757
merge into: MagicBeanDev:main
Conversation 1 Commits 1 Files changed 1 +1
github-sync commented 2026-11-12 11:35:45 +00:00
Owner

@Jiro131 opened this pull request on GitHub · 2026-11-12 11:15 UTC · original

#2748 (the Windows parallel lift emit) was played before it went in, but that run was only described in the PR; docs/tested-configurations.md asks for a row per run, so the next tester can see that this setup is covered.

One row, newest first: build v2.1.0-rc.3-256-gf79aa054 (#2748's branch plus the damaged-texture check change of #2754), Windows 11, RTX 4090 on NVIDIA 621.01, 5120x1440, upscaler and frame generation off, 60 fps cap, Kokiri Forest from a save. The figures come from hookshot_log.txt: 32 windows of 120 presents in Kokiri, median 56.1 fps (43.4-60.6) at 1,764-3,926 draws, no device lost.

Docs only: no code, no test change.

🤖 Generated with Claude Code

> [@Jiro131](https://github.com/Jiro131) opened this pull request on GitHub · 2026-11-12 11:15 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2757) #2748 (the Windows parallel lift emit) was played before it went in, but that run was only described in the PR; `docs/tested-configurations.md` asks for a row per run, so the next tester can see that this setup is covered. One row, newest first: build `v2.1.0-rc.3-256-gf79aa054` (#2748's branch plus the damaged-texture check change of #2754), Windows 11, RTX 4090 on NVIDIA 621.01, 5120x1440, upscaler and frame generation off, 60 fps cap, Kokiri Forest from a save. The figures come from `hookshot_log.txt`: 32 windows of 120 presents in Kokiri, median 56.1 fps (43.4-60.6) at 1,764-3,926 draws, no device lost. Docs only: no code, no test change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- github-sync:item:2757 -->
The game run behind #2748 (Windows parallel lift emit), in Kokiri Forest on
an RTX 4090, was described in the PR but had no row here.

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-sync commented 2026-11-12 14:45:28 +00:00
Author
Owner

@Joey-Magnus approved on GitHub · 2026-11-12 14:35 UTC · original

This is docs only: one row at the top of docs/tested-configurations.md for the RTX 4090 run of #2748, which is merged. The row has what the table asks for: the build with its source commit, OS, GPU and driver, CPU and RAM, settings, where it was played, and figures taken from hookshot_log.txt. It also says plainly that the build included the #2754 damaged-texture change on top of #2748's branch, which is the honest way to record it. CI is green.

The only thing to watch is that #2755 and #2756 add a row at the same place, so whichever of the three lands later needs a trivial rebase of that line.

> [@Joey-Magnus](https://github.com/Joey-Magnus) approved on GitHub · 2026-11-12 14:35 UTC · [original](https://github.com/NotRexed/Hookshot/pull/2757#pullrequestreview-5876247659) This is docs only: one row at the top of docs/tested-configurations.md for the RTX 4090 run of #2748, which is merged. The row has what the table asks for: the build with its source commit, OS, GPU and driver, CPU and RAM, settings, where it was played, and figures taken from hookshot_log.txt. It also says plainly that the build included the #2754 damaged-texture change on top of #2748's branch, which is the honest way to record it. CI is green. The only thing to watch is that #2755 and #2756 add a row at the same place, so whichever of the three lands later needs a trivial rebase of that line. <!-- github-sync:r:5876247659 -->
Commenting is not possible because the repository is archived.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
autorelease: pending

   
autorelease: tagged

   
bug
Something isn't working

  
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
testing wanted

   
wontfix
This will not be worked on

No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Hookshot!2757
No description provided.