Audio reverb fixtures fail to compile without the production env_on dependency #2639

Open

opened 2026-11-12 03:47:04 +00:00 by Arkex-ai · 2 comments

Arkex-ai commented

2026-11-12 03:47:04 +00:00

(Migrated from github.com)

Problem

The two reverb fixtures fail to compile on clean main: test_audio_aux.py and test_audio_biquad.py extract reverb_frame, which now calls the production env_on helper, but their translation units do not provide it. This prevents the audio regressions from running in the source-check jobs.

Reproduced on clean 9c5612f0 and c356bef4, on Windows and Linux. The extraction paths are unchanged at a016b7a6.

python -I -B tests/run_all.py audio_aux audio_biquad

Both fail with an undeclared/implicit declaration of env_on in reverb_frame, with warnings treated as errors.

Scope

Restore the fixtures' production dependency and verify the no-reverb switch through its real on/off parser. Keep production audio behavior and all existing DSP assertions intact; do not disable the checks or substitute a different switch parser.

Priority: S3 (weight 1) ? reach 1.0 (source-check jobs on both platforms) ? confidence 1.0 (clean-main reproduction) = 1.0. This is a CI gate repair, not a reported gameplay/audio defect.

No overlapping open audio-fixture PR or issue was found in the current search. Other failing source fixtures and the presenter-thread work in #2622 are separate scopes.

## Problem The two reverb fixtures fail to compile on clean main: `test_audio_aux.py` and `test_audio_biquad.py` extract `reverb_frame`, which now calls the production `env_on` helper, but their translation units do not provide it. This prevents the audio regressions from running in the source-check jobs. Reproduced on clean `9c5612f0` and `c356bef4`, on Windows and Linux. The extraction paths are unchanged at `a016b7a6`. ```sh python -I -B tests/run_all.py audio_aux audio_biquad ``` Both fail with an undeclared/implicit declaration of `env_on` in `reverb_frame`, with warnings treated as errors. ## Scope Restore the fixtures' production dependency and verify the no-reverb switch through its real on/off parser. Keep production audio behavior and all existing DSP assertions intact; do not disable the checks or substitute a different switch parser. Priority: S3 (weight 1) ? reach 1.0 (source-check jobs on both platforms) ? confidence 1.0 (clean-main reproduction) = 1.0. This is a CI gate repair, not a reported gameplay/audio defect. No overlapping open audio-fixture PR or issue was found in the current search. Other failing source fixtures and the presenter-thread work in #2622 are separate scopes.

Arkex-ai commented

2026-11-12 04:09:41 +00:00

(Migrated from github.com)

This matches the combined source-fixture repair mooki000 claimed in the coordination channel, including the two audio tests after #1544.

Keeping this issue as the focused reproduction record for that work. Both checks also failed on a clean 9c5612f0 checkout on Windows and Linux, with the same missing env_on dependency as the candidate suites. No separate audio-fixture implementation has been started here.

This matches the combined source-fixture repair mooki000 claimed in [the coordination channel](https://discord.com/channels/1568810484818378804/1570103281856806962/1570285873356869663), including the two audio tests after #1544. Keeping this issue as the focused reproduction record for that work. Both checks also failed on a clean `9c5612f0` checkout on Windows and Linux, with the same missing `env_on` dependency as the candidate suites. No separate audio-fixture implementation has been started here.

github-sync commented

2026-11-12 14:43:44 +00:00

Owner

@mooki000 commented on GitHub · 2026-11-12 14:12 UTC · original

The two reverb fixtures were included in #2648, merged as 9776c36d. That supplies the production env_on dependency without changing the audio behavior. The main revisions in this report predate that merge.

> [@mooki000](https://github.com/mooki000) commented on GitHub · 2026-11-12 14:12 UTC · [original](https://github.com/NotRexed/Hookshot/issues/2639#issuecomment-6825953008) The two reverb fixtures were included in #2648, merged as `9776c36d`. That supplies the production `env_on` dependency without changing the audio behavior. The main revisions in this report predate that merge.

Commenting is not possible because the repository is archived.