An update rebuilds the game with the flags it was built with #2577
Labels
No labels
accessibility
autorelease: pending
autorelease: tagged
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
question
testing wanted
wontfix
No milestone
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Hookshot#2577
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The idea
Depends on #2576. This one is blocked until that record exists.
An update compiles whatever
RX_MARCHhappens to be in that process, orhost_march()when it is unset. Extra CPU flags are not read from anywhere. Updating a game that was built forrocketlakewith-mprefer-vector-width=256on a machine that only exports those for a hand-run build produces anx86-64-v3binary and drops the extra flag. The DLSS choice is already carried across an update. The CPU flags are not.When the game folder has a recorded flag set, the update build should use it: pass that
-marchand-mtunethrough, keep-ffp-contract=off, and pass the recorded extra CPU flags. A folder with no record keeps today's behavior. A Steam Deck with no recorded tune can still add-mtune=znver2fromhost_mtune(). An explicit record wins over that detection. The player can still override one build by settingRX_MARCHfor that run.Checked on v2.1.0, the newest release, and on
nightly(fce53453, 187 commits later, 11 November 2026). Neither rebuilds an update with the flags the game was built with.Anything else
The record has to be the source of the flags. Reading them back out of the binary with
stringsis not enough, because the current binary does not contain them, and a vendor library's embedded GCC line (-march=x86-64) is not this game's line.Thanks for the report. Reports of the same kind are collected in #2505, which lists this one with your details and links back here, so one fix closes them together. Follow #2505 for the fix and add new details there (or here). If this turns out to be separate it will be reopened.
Thanks for looking. This is a feature request, not a failed build: an update should rebuild with the CPU flags the game was already built with. It depends on #2576. #2505 is for builds that fail, run out of disk, or take too long, and its list does not mention this. Could it be reopened as separate?